On 04/18/2011 09:47 AM, Enrico Forestieri wrote:
On Mon, Apr 18, 2011 at 03:49:23AM +0200, rgh...@lyx.org wrote:

Author: rgheck
Date: Mon Apr 18 03:49:23 2011
New Revision: 38431
URL: http://www.lyx.org/trac/changeset/38431

Log:
Remove pointless variable.
Are you sure it is pointless? runparams is a reference and even if
it is constant, there are mutable members that could be changed.
The copy you removed maybe tries to protect against that.

Possibly so. I thought it was a remnant of some of the early code I did. But I cut and pasted a lot of this code originally from the docbook routines, and so maybe that is where it came from. I'll revert for now. I have to redo a lot of this anyway after 2.0.0, due to #7463.

Richard

Reply via email to