Re: r37580 - lyx-devel/trunk/development/cmake

2011-02-16 Thread Patrick Atamaniuk
On Wed, Feb 16, 2011 at 6:27 PM, Jürgen Spitzmüller wrote: > Pavel Sanda wrote: >> > I'm not sure we should backport this to branch. There will (most >> > probably) be  one release in that series anyway. >> >> i have the same feeling. if we introduce regressions, theres no much space >> to repair

Re: r37580 - lyx-devel/trunk/development/cmake

2011-02-16 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > > I'm not sure we should backport this to branch. There will (most > > probably) be one release in that series anyway. > > i have the same feeling. if we introduce regressions, theres no much space > to repair it back. Also it seems not of much use. AFAIU the reasoning was t

Re: r37580 - lyx-devel/trunk/development/cmake

2011-02-16 Thread Pavel Sanda
Patrick Atamaniuk wrote: > On Wed, Feb 16, 2011 at 3:24 PM, Pavel Sanda wrote: > > >> 2nd try attached, sorry for the mess. > > > > control check: > > when you build lyx with this patch and save new file, what the first > > line of the file? > > I double checked - with the latter patch we get: >

Re: r37580 - lyx-devel/trunk/development/cmake

2011-02-16 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Patrick Atamaniuk wrote: > > > #LyX 1.6 created this file. For more info see http://www.lyx.org/ > > > > for the 1.6.9 backport that is. for trunk, i see config.h with correct > > integers 2 and 0. > > I'm not sure we should backport this to branch. There will (most pr

Re: r37580 - lyx-devel/trunk/development/cmake

2011-02-16 Thread Jürgen Spitzmüller
Patrick Atamaniuk wrote: > > #LyX 1.6 created this file. For more info see http://www.lyx.org/ > > for the 1.6.9 backport that is. for trunk, i see config.h with correct > integers 2 and 0. I'm not sure we should backport this to branch. There will (most probably) be one release in that series a

Re: r37580 - lyx-devel/trunk/development/cmake

2011-02-16 Thread Patrick Atamaniuk
> #LyX 1.6 created this file. For more info see http://www.lyx.org/ for the 1.6.9 backport that is. for trunk, i see config.h with correct integers 2 and 0. /p

Re: r37580 - lyx-devel/trunk/development/cmake

2011-02-16 Thread Patrick Atamaniuk
On Wed, Feb 16, 2011 at 3:24 PM, Pavel Sanda wrote: >> 2nd try attached, sorry for the mess. > > control check: > when you build lyx with this patch and save new file, what the first > line of the file? I double checked - with the latter patch we get: #LyX 1.6 created this file. For more info se

Re: r37580 - lyx-devel/trunk/development/cmake

2011-02-16 Thread Pavel Sanda
Patrick Atamaniuk wrote: > > Here we go, quickfix against svn trunk for scons attached. > Which is erroneous, i missed that we need const int. Please scrap that > last patch from me. > > 2nd try attached, sorry for the mess. control check: when you build lyx with this patch and save new file, wha

Re: r37580 - lyx-devel/trunk/development/cmake

2011-02-16 Thread Patrick Atamaniuk
> Here we go, quickfix against svn trunk for scons attached. Which is erroneous, i missed that we need const int. Please scrap that last patch from me. 2nd try attached, sorry for the mess. /patrick Index: SConstruct === --- SConstru

Re: r37580 - lyx-devel/trunk/development/cmake

2011-02-16 Thread Patrick Atamaniuk
On Thu, Feb 10, 2011 at 12:34 PM, Pavel Sanda wrote: > kor...@lyx.org wrote: >> +#define LYX_MAJOR_VERSION ${LYX_MAJOR_VERSION} >> +#define LYX_MINOR_VERSION ${LYX_MINOR_VERSION} > > huh, this didn't come to my mind. now i think scons will suffer from the same > problem. > please is there anybody

Re: r37580 - lyx-devel/trunk/development/cmake

2011-02-10 Thread Pavel Sanda
kor...@lyx.org wrote: > Author: kornel > Date: Thu Feb 10 07:16:12 2011 > New Revision: 37580 > URL: http://www.lyx.org/trac/changeset/37580 > > Log: > Define LYX_(MAJOR|MINOR)_VERSION also for cmake build > > Modified: >lyx-devel/trunk/development/cmake/config.h.cmake > > Modified: lyx-deve