Re: merging controller and view

2007-10-01 Thread Abdelrazak Younes
Andre Poenitz wrote: On Mon, Oct 01, 2007 at 09:35:43PM +0200, Abdelrazak Younes wrote: Citation seems to be "Old Standard" (or whatever is left of that): class GuiCitationDialog : public GuiDialog, public Ui::CitationUi It was not before your controller cleanup. I think you changed it back to

Re: merging controller and view

2007-10-01 Thread Andre Poenitz
On Mon, Oct 01, 2007 at 09:35:43PM +0200, Abdelrazak Younes wrote: > Andre Poenitz wrote: > >On Mon, Oct 01, 2007 at 06:23:16PM +, Angus Leeming wrote: > >>Andre Poenitz <[EMAIL PROTECTED]> writes: > >>>So possible resolutions in my eyes are > >>> > >>> (1) "physically merge C and V" (that wou

Re: merging controller and view

2007-10-01 Thread Abdelrazak Younes
Andre Poenitz wrote: On Mon, Oct 01, 2007 at 06:23:16PM +, Angus Leeming wrote: Andre Poenitz <[EMAIL PROTECTED]> writes: So possible resolutions in my eyes are (1) "physically merge C and V" (that would be 1:0 for KISS vs MVC) or (2) "put C and V in the same files" (that would be so

Re: merging controller and view

2007-10-01 Thread Andre Poenitz
On Mon, Oct 01, 2007 at 06:23:16PM +, Angus Leeming wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > So possible resolutions in my eyes are > > > > (1) "physically merge C and V" (that would be 1:0 for KISS vs MVC) > > > > or > > > > (2) "put C and V in the same files" (that would

Re: merging controller and view

2007-10-01 Thread Angus Leeming
Andre Poenitz <[EMAIL PROTECTED]> writes: > So possible resolutions in my eyes are > > (1) "physically merge C and V" (that would be 1:0 for KISS vs MVC) > > or > > (2) "put C and V in the same files" (that would be something like >0.3 : 0.7 for KISS vs MVC, but would at least not ma

Re: merging controller and view

2007-09-29 Thread Andre Poenitz
On Thu, Sep 06, 2007 at 01:34:16AM +, Angus Leeming wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > Summary: > > > > Before merging controller and view for the "About" dialog: > > > >315 frontends/controllers/ControlAboutlyx.lo &g

Re: merging controller and view

2007-09-07 Thread Jean-Marc Lasgouttes
Andre Poenitz <[EMAIL PROTECTED]> writes: > On Thu, Sep 06, 2007 at 09:31:48AM +0200, Abdelrazak Younes wrote: >> >Note that I did not really move anything from src/* to >> >src/frontends/qt4/*. All the strings in the current GuiAbout dialog >> >already lived soemewehe under src/frontends/* >> >>

Re: merging controller and view

2007-09-06 Thread José Matos
On Thursday 06 September 2007 17:48:37 Andre Poenitz wrote: > Hm... would srs/suppotr be a compromise? Good try but no. :-) > Andre' -- José Abílio

Re: merging controller and view

2007-09-06 Thread Andre Poenitz
On Thu, Sep 06, 2007 at 09:31:48AM +0200, Abdelrazak Younes wrote: > >Note that I did not really move anything from src/* to > >src/frontends/qt4/*. All the strings in the current GuiAbout dialog > >already lived soemewehe under src/frontends/* > > I know but I would prefer that the string definit

Re: merging controller and view

2007-09-06 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: >> Yes, but the binary size of an object which accounts for less than !% >> of total size... > > Those of you who have an azerty keyboard in front of them have already > remarked that 1 is on the same keycap as !. !))% agree. A/

Re: merging controller and view

2007-09-06 Thread Jean-Marc Lasgouttes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > Abdelrazak Younes <[EMAIL PROTECTED]> writes: > >> Andre's point is about the source code and binary size... > > Yes, but the binary size of an object which accounts for less than !% > of total size... Those of you who have an azerty keyboard in

Re: merging controller and view

2007-09-06 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > Andre's point is about the source code and binary size... Yes, but the binary size of an object which accounts for less than !% of total size... JMarc

Re: merging controller and view

2007-09-06 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: We have a religiuos problem here as we are/were not supposed to use QString in support. That's not true anymore as we do us it now. Not in the api, do we? No, you are right. I do not see the point to introduce it i

Re: merging controller and view

2007-09-06 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> We have a religiuos problem here as we are/were not supposed to use >> QString in support. > > That's not true anymore as we do us it now. Not in the api, do we? I do not see the point to introduce it in the API just to shave a toqstr() call. I do

Re: merging controller and view

2007-09-06 Thread Abdelrazak Younes
Andre Poenitz wrote: On Thu, Sep 06, 2007 at 09:03:01AM +0200, Abdelrazak Younes wrote: Andre Poenitz wrote: The About dialog does not control anything. It just displays stuff. Arguably the stuff should come even from the kernel, not some "fat controller", but in the end the fact remains: Noth

Re: merging controller and view

2007-09-06 Thread Andre Poenitz
On Thu, Sep 06, 2007 at 09:03:01AM +0200, Abdelrazak Younes wrote: > Andre Poenitz wrote: > > >The About dialog does not control anything. It just displays stuff. > >Arguably the stuff should come even from the kernel, not some "fat > >controller", but in the end the fact remains: Nothing is "cont

Re: merging controller and view

2007-09-06 Thread Abdelrazak Younes
Andre Poenitz wrote: The About dialog does not control anything. It just displays stuff. Arguably the stuff should come even from the kernel, not some "fat controller", but in the end the fact remains: Nothing is "controlled". In this particular case you are definitely right. But, you are int

Re: merging controller and view

2007-09-05 Thread Andre Poenitz
On Thu, Sep 06, 2007 at 01:34:16AM +, Angus Leeming wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > Summary: > > > > Before merging controller and view for the "About" dialog: > > > >315 frontends/controllers/ControlAboutlyx.lo &g

Re: merging controller and view

2007-09-05 Thread Angus Leeming
Andre Poenitz <[EMAIL PROTECTED]> writes: > Summary: > > Before merging controller and view for the "About" dialog: > >315 frontends/controllers/ControlAboutlyx.lo > 88760 frontends/controllers/ControlAboutlyx.o >301 frontends/qt4/GuiAbout.

merging controller and view

2007-09-05 Thread Andre Poenitz
Some (possibly extreme?) example attached. Summary: Before merging controller and view for the "About" dialog: 315 frontends/controllers/ControlAboutlyx.lo 88760 frontends/controllers/ControlAboutlyx.o 301 frontends/qt4/GuiAbout.lo 95752 frontends/qt4/GuiAbout.o 2057