Andre Poenitz wrote:
The About dialog does not control anything. It just displays stuff.
Arguably the stuff should come even from the kernel, not some "fat
controller", but in the end the fact remains: Nothing is "controlled".
In this particular case you are definitely right. But, you are
introducing "src/version.h" in qt4/. I think we should try hard to not
add additional header dependencies to the core if our stated goal is to
have core dll. So I propose that you move the new static method to
"src/support/". I am talking about these:
+static QString credits()
+static QString copyright()
+static QString license()
+static QString disclaimer()
+static QString version()
I think most of the hardcoded strings should be put in "char const *" in
"version.h" and version.h shout be moved to src/frontend.
[Andre explanation]
Andre, I fully agree with you but still, please try to keep "source"
separation between the core and the GUI: this means that frontend/ is
the "source" interface. The core should just expose a clear set of
functions and the GUI should use that.
Abdel.
