Re: insetindex patch

2000-08-03 Thread Garst R. Reese
Jean-Marc Lasgouttes wrote: > > > "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > Angus> Not true anymore, I'm afraid. the pop-up always comes up. Only > Angus> on pressing OK on the popup is the inset actually > Angus> created/inserted in the list of insets. This is the same > Angu

Re: insetindex patch

2000-08-03 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Not true anymore, I'm afraid. the pop-up always comes up. Only Angus> on pressing OK on the popup is the inset actually Angus> created/inserted in the list of insets. This is the same Angus> behaviour as InsetCitation, InsetTOC, In

Re: insetindex patch

2000-08-03 Thread Angus Leeming
The code below would recreate exactly the behaviour of the old insert-index, insert-index-last. It has not been tested, so don't apply it. I present it merely to show that both paths are possible/easily achievable. I await a decision as to which is preferable. Angus -

Re: insetindex patch

2000-08-03 Thread Angus Leeming
JMarc> Angus> Fix made (but not attached!). However I think that we should JMarc> Angus> remove the "insert entry of last word" menu option and JMarc> Angus> corresponding LFUN_INDEX_CREATE_LAST. The code already does JMarc> Angus> this for "insert entry", LFUN_INDEX_CREATE. JMarc> It only avoids

Re: insetindex patch

2000-08-03 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Fix made (but not attached!). However I think that we should Angus> remove the "insert entry of last word" menu option and Angus> corresponding LFUN_INDEX_CREATE_LAST. The code already does Angus> this for "insert entry", LFUN_INDE

Re: insetindex patch

2000-08-03 Thread Angus Leeming
JMarc> I think that, while the restriction makes sense for JMarc> LFUN_INDEX_CREATE_LAST, it does not for insert-index, especially since JMarc> there is no error message. Inserting an empty index entry would make JMarc> more sense. Fix made (but not attached!). However I think that we should remo

Re: insetindex patch

2000-08-03 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Ok. I'll have a go. In the meantime here is the fix to the Angus> crashes. It was indeed my fault :( I was deleting the xforms Angus> structure and then trying to access its contents! I'll apply it. JMarc

Re: insetindex patch

2000-08-03 Thread Angus Leeming
JMarc> I think that, while the restriction makes sense for JMarc> LFUN_INDEX_CREATE_LAST, it does not for insert-index, especially since JMarc> there is no error message. Inserting an empty index entry would make JMarc> more sense. Ok. I'll have a go. In the meantime here is the fix to the crashe

Re: insetindex patch

2000-08-03 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: JMarc> Also Angus, it is not possible to insert an index entry at the JMarc> beginning of a paragraph. Angus> That's because LyXFunc::Dispatch() contains the code: Angus> case LFUN_INDEX_CREATE: case LFUN_INDEX_CREATE_LAST: { // Angus>

Re: insetindex patch

2000-08-03 Thread Angus Leeming
JMarc> Also Angus, it is not possible to insert an index entry at the JMarc> beginning of a paragraph. That's because LyXFunc::Dispatch() contains the code: case LFUN_INDEX_CREATE: case LFUN_INDEX_CREATE_LAST: { // Can't do that at the beginning of a parag

Re: insetindex patch

2000-08-03 Thread Angus Leeming
JMarc> Angus, if I load a file and then immediately exit, I get a crash. It JMarc> seems (sorry I compiled without debug info) to be in JMarc> FormCommand::free. JMarc> I'll commit anyway. Thanks for the feedback. I'll have a look. A.

Re: insetindex patch

2000-08-03 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> I'll apply it, hopefully with more success than last time. Jean-Marc> I was in the pro

Re: insetindex patch

2000-08-03 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> I'll apply it, hopefully with more success than last time. Jean-Marc> I was in the process of applying and testing it, so unless Jean-Marc> you have begun w

Re: insetindex patch

2000-08-03 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | | Lars> I'll apply it, hopefully with more success than last time. | | I was in the process of applying and testing it, so unless you have | begun with it, I can just continue.

Re: insetindex patch

2000-08-03 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> I'll apply it, hopefully with more success than last time. I was in the process of applying and testing it, so unless you have begun with it, I can just continue. JMarc

Re: insetindex patch

2000-08-03 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Attached is a patch to make insetindex GUI-independent. I've also cleaned up | some of my earlier work in the xforms directory (better comments etc). | | Could some kind sole with CVS write permissions please apply and | test in their | own repository

insetindex patch

2000-08-03 Thread Angus Leeming
Duuu! Here is the patch! Attached is a patch to make insetindex GUI-independent. I've also cleaned up some of my earlier work in the xforms directory (better comments etc). Could some kind sole with CVS write permissions please apply and test in their own repository before applying globally.

insetindex patch

2000-08-03 Thread Angus Leeming
Attached is a patch to make insetindex GUI-independent. I've also cleaned up some of my earlier work in the xforms directory (better comments etc). Could some kind sole with CVS write permissions please apply and test in their own repository before applying globally. I don't think anything is wro