Re: crash: click on macro instantiation - bug 2060

2006-02-03 Thread Georg Baum
Beck, Andrew Thomas - BECAT001 wrote: > >>Ok, I see now. Unfortunately your patch is not correct IMHO: If I click on >>argument 3 I expect the cursor to appear in argument 3, not in the first >>one as your patch does. In perinciple it is ok to call > > Of course you tested your original patch to

Re: crash: click on macro instantiation - bug 2060

2006-02-02 Thread Beck, Andrew Thomas - BECAT001
>Ok, I see now. Unfortunately your patch is not correct IMHO: If I click on >argument 3 I expect the cursor to appear in argument 3, not in the first >one as your patch does. In perinciple it is ok to call Of course you tested your original patch to ensure it met this requirement? I suspect l

Re: crash: click on macro instantiation - bug 2060

2006-02-02 Thread Georg Baum
Am Donnerstag, 2. Februar 2006 22:31 schrieb Beck, Andrew Thomas - BECAT001: > I just noticed this bug was targeted to 1.4.0. Is > the intention to get this new patch in? It was not now targetted to 1.4.0, it was targetted to 1.4.0 a long time ago. I only reopened it today, because you found out

RE: Re: crash: click on macro instantiation - bug 2060

2006-02-02 Thread Beck, Andrew Thomas - BECAT001
I just noticed this bug was targeted to 1.4.0. Is the intention to get this new patch in? andrew

Re: crash: click on macro instantiation - bug 2060

2006-02-02 Thread Georg Baum
Am Mittwoch, 1. Februar 2006 23:20 schrieb Beck, Andrew Thomas - BECAT001: > > > >> Here is a patch to fix bug 2060 - again. > > > >It looks sensible. Are you sure that nothing needs to be done in cursorPos > >and drawSelection? > > Nope, I have no idea. I looked at your original patch which ment

RE: Re: crash: click on macro instantiation - bug 2060

2006-02-01 Thread Beck, Andrew Thomas - BECAT001
> >> Here is a patch to fix bug 2060 - again. > >It looks sensible. Are you sure that nothing needs to be done in cursorPos >and drawSelection? Nope, I have no idea. I looked at your original patch which mentioned fixing a potential problem, but can't see how that would eventuate. If you can point

Re: crash: click on macro instantiation - bug 2060

2006-02-01 Thread Georg Baum
Beck, Andrew Thomas - BECAT001 wrote: > Here is a patch to fix bug 2060 - again. It looks sensible. Are you sure that nothing needs to be done in cursorPos and drawSelection? > - those with arguments open for editing with first selected > with a macro open, click elsewhere within the inset What

Re: crash: click on macro instantiation - bug 2060

2006-02-01 Thread Beck, Andrew Thomas - BECAT001
Title: Re: crash: click on macro instantiation - bug 2060 Here is a patch to fix bug 2060 - again. I've tested this patch in the following ways (lyx file attached) create a macro with 0 arguments create a macro with 1 argument create a macro with 3 argument use each of the above macr

Re: crash: click on macro instantiation - bug 2060

2006-02-01 Thread Beck, Andrew Thomas - BECAT001
> >> I'm working on a fix which should be available soon. > >Excellent! I just wanted to clarify the intention with this code. I tried to follow the thread, http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg82007.html but am none the wiser. Is the intention of the current code to somehow wo

Re: crash: click on macro instantiation

2006-02-01 Thread Georg Baum
Beck, Andrew Thomas - BECAT001 wrote: > Can I lodge this directly to bugzilla, or does one > need some kind of status to do that? You need an account, but you can create it yourself. > I'm working on a fix which should be available soon. Excellent! Georg

crash: click on macro instantiation

2006-01-31 Thread Beck, Andrew Thomas - BECAT001
Title: crash: click on macro instantiation I have replicated this bug in a recent cvs checkout. 1. Create a macro with > 0 arguments. 2. Use that macro, defining the arguments 3. Leave the MathMacro inset 4. Click on the MathMacro inset 5. Reach for nearest fire extinguisher 6. Spray o