Beck, Andrew Thomas - BECAT001 wrote: > >>Ok, I see now. Unfortunately your patch is not correct IMHO: If I click on >>argument 3 I expect the cursor to appear in argument 3, not in the first >>one as your patch does. In perinciple it is ok to call > > Of course you tested your original patch to ensure it met this > requirement?
Now I am confused. What do you mean with my original patch? If you mean the one that is already in, then it does not fix problems for macros with more than 0 arguments. It only dealt with the case of 0 arguments. > I suspect lyx never behaved in this way & so would be a little hesitant to > introduce new behaviour at this stage - given the discussion over toolbars > etc. My original intention was to simply fix a bug that caused a crash & > which occurs consistently doing a very common operation. The behaviour is already different than in 1.3: Nothing happens if you click on a macro in that version. Apart from that, the behaviour that I described might be new for macros, but is the standard behaviour for all insets with cells, so it is the expected one. > Of course, if it is wanted, I'm more than happy to introduce the function > described above. I will leave the current patch as it is & develop a > further patch to implement the new function. As I said: Your patch is IMO not the right long term solution, but for now good enough, since the crash is fixed, but I am not the one to decide whether it should go in for 1.4.0. Georg
