Re: [LyX/2.4.x] Adhere to semantic background color with default branches

2024-10-05 Thread José Matos
On Sat, 2024-10-05 at 16:53 +, Richard Kimberly Heck wrote: > commit 478d59f5ddd1cda62883e4ef7ae06d5ad4ea9f72 > Author: Juergen Spitzmueller > Date:   Sat Oct 5 14:15:19 2024 +0200 > >     Adhere to semantic background color with default branches >     >     This fixes

Re: Changing the background color in math menus

2021-03-04 Thread Jürgen Spitzmüller
Am Donnerstag, dem 04.03.2021 um 11:52 +0100 schrieb Stephan Witt: > Yes it works. Thank you. Great. > While thinking about the change: wouldn’t it be better to move > clear() > into fill()? > > Like the attached. In practice it’s the same probably. In theory it > looks more safe. I don't think

Re: Changing the background color in math menus

2021-03-04 Thread Stephan Witt
Am 04.03.2021 um 09:10 schrieb Jürgen Spitzmüller : > > Am Donnerstag, dem 04.03.2021 um 08:24 +0100 schrieb Jürgen > Spitzmüller: >> Ah, that's this issue. We discussed this already. I remember you >> mentioned some signal that is emitted on the Mac when the switch >> happens and that you intende

Re: Changing the background color in math menus

2021-03-04 Thread Jürgen Spitzmüller
Am Donnerstag, dem 04.03.2021 um 07:40 +0100 schrieb Stephan Witt: > I think it’s caused by the different dark mode switch.  > On Mac I can switch to dark mode after LyX start… > > > … or use it as my normal user desktop setting and then it’s probably > fine. > > > The switch at runtime should

Re: Changing the background color in math menus

2021-03-04 Thread Jürgen Spitzmüller
Am Donnerstag, dem 04.03.2021 um 08:24 +0100 schrieb Jürgen Spitzmüller: > Ah, that's this issue. We discussed this already. I remember you > mentioned some signal that is emitted on the Mac when the switch > happens and that you intended to investigate how dark mode in LyX can > be connected to th

Re: [LyX/master] No need to set background color of a newly created branch.

2021-02-03 Thread Jean-Marc Lasgouttes
Le 30/01/2021 à 09:09, Jürgen Spitzmüller a écrit : Am Freitag, dem 29.01.2021 um 18:28 +0100 schrieb Jean-Marc Lasgouttes: commit 5145694cd067e221a661e0d6c7dce4ed5ca22e37 Author: Jean-Marc Lasgouttes Date:   Fri Jan 29 18:29:55 2021 +0100     No need to set background color of a newly

Re: [LyX/master] No need to set background color of a newly created branch.

2021-01-30 Thread Jürgen Spitzmüller
Am Freitag, dem 29.01.2021 um 18:28 +0100 schrieb Jean-Marc Lasgouttes: > commit 5145694cd067e221a661e0d6c7dce4ed5ca22e37 > Author: Jean-Marc Lasgouttes > Date:   Fri Jan 29 18:29:55 2021 +0100 > >     No need to set background color of a newly created branch. >     >    

Re: [LyX/master] Prevent branch background color from leaking out of the document

2021-01-25 Thread Jürgen Spitzmüller
Am Montag, dem 25.01.2021 um 13:45 +0100 schrieb Jean-Marc Lasgouttes: > What I propose (not 2.4 business IMO) is > > * when e.g. the BranchList object requires a color, it can just give > a > rgb triplet and require a color code. The name is just an > intermediate > valuethat is of no use. If t

Re: [LyX/master] Prevent branch background color from leaking out of the document

2021-01-25 Thread Jean-Marc Lasgouttes
Le 22/01/2021 à 11:12, Jürgen Spitzmüller a écrit : My take is that the name is only needed for the colors of GUI elements that can be set in the color preferences. What about the colors set in document settings (branch background, greyedouttext, box background, index labels)? So, I have been

Re: [LyX/master] Prevent branch background color from leaking out of the document

2021-01-22 Thread Jürgen Spitzmüller
Am Freitag, dem 22.01.2021 um 11:02 +0100 schrieb Jean-Marc Lasgouttes: > What I had in mind is that we save the name when there is one, and > the hexcode when there is no name. > > Example: > * code: Color_background, name: "background", rgb: "linen" > => saved: "background" > > * code: Color_ma

Re: [LyX/master] Prevent branch background color from leaking out of the document

2021-01-22 Thread Jean-Marc Lasgouttes
Le 21/01/2021 à 14:02, Jürgen Spitzmüller a écrit : My point is saving in the document. We need \color background in the LyX header in order to dynamically assign the correct color (and yes we do that via getFromLyXName). We cannot save the color code, as we need to save it as string (to catch

Re: [LyX/master] Prevent branch background color from leaking out of the document

2021-01-21 Thread Jürgen Spitzmüller
Am Donnerstag, dem 21.01.2021 um 13:45 +0100 schrieb Jean-Marc Lasgouttes: > Hmm, what about >    code = Color_background; > or >    code = colorset.getFromLyXName("background"): > > I agree 100% that this needs thinking, but my point is that the > ColorCode is more important for LyX than the nam

Re: [LyX/master] Prevent branch background color from leaking out of the document

2021-01-21 Thread Jean-Marc Lasgouttes
Le 21/01/2021 à 10:48, Jürgen Spitzmüller a écrit : How would that work with semantic branch names (e.g. \color background)? Semantic branch names are essential to support branches properly in different color themes. Also, how would you export semantic color names in LaTeX (e.g. \textcolor{notef

Re: [LyX/master] Prevent branch background color from leaking out of the document

2021-01-21 Thread Jürgen Spitzmüller
Am Donnerstag, dem 21.01.2021 um 10:41 +0100 schrieb Jean-Marc Lasgouttes: > Le 21/01/2021 à 09:55, Jürgen Spitzmüller a écrit : > > Am Donnerstag, dem 21.01.2021 um 09:52 +0100 schrieb Jean-Marc > > Lasgouttes: > > > This is why IMO declaring a name for such colors is a mistake. An > > > enum valu

Re: [LyX/master] Prevent branch background color from leaking out of the document

2021-01-21 Thread Jean-Marc Lasgouttes
Le 21/01/2021 à 09:55, Jürgen Spitzmüller a écrit : Am Donnerstag, dem 21.01.2021 um 09:52 +0100 schrieb Jean-Marc Lasgouttes: This is why IMO declaring a name for such colors is a mistake. An enum value generated on the fly would be enough. And where would you store and access these enum valu

Re: [LyX/master] Prevent branch background color from leaking out of the document

2021-01-21 Thread Jürgen Spitzmüller
Am Donnerstag, dem 21.01.2021 um 09:55 +0100 schrieb Jürgen Spitzmüller: > Am Donnerstag, dem 21.01.2021 um 09:52 +0100 schrieb Jean-Marc > Lasgouttes: > > This is why IMO declaring a name for such colors is a mistake. An > > enum value generated on the fly would be enough. > > And where would you

Re: [LyX/master] Prevent branch background color from leaking out of the document

2021-01-21 Thread Jürgen Spitzmüller
Am Donnerstag, dem 21.01.2021 um 09:52 +0100 schrieb Jean-Marc Lasgouttes: > This is why IMO declaring a name for such colors is a mistake. An > enum value generated on the fly would be enough. And where would you store and access these enum values? (BTW the name now is as unique as it gets, as i

Re: [LyX/master] Prevent branch background color from leaking out of the document

2021-01-21 Thread Jean-Marc Lasgouttes
Le 21/01/2021 à 08:19, Jürgen Spitzmüller a écrit : BTW if you want to have fun, fire up LyX 2.3.x, define a new branch named "foreground" and see how all text (in all opened documents!) magically disappears. Amusing indeed :) This is why IMO declaring a name for such colors is a mistake. An e

Re: [LyX/master] Prevent branch background color from leaking out of the document

2021-01-20 Thread Jürgen Spitzmüller
Am Donnerstag, dem 21.01.2021 um 08:10 +0100 schrieb Juergen Spitzmueller: > commit 514cd879702dc946b75a4f688e3c67478a767a56 > Author: Juergen Spitzmueller > Date:   Thu Jan 21 08:09:41 2021 +0100 > >     Prevent branch background color from leaking out of the document >

Re: [LyX/master] Fixup d207e85c: paint sublabel with the correct background color

2020-06-07 Thread Jean-Marc Lasgouttes
Le 06/06/2020 à 19:04, Richard Kimberly Heck a écrit : Fixed in master at a71b96ac42. Riki, if we want to fix in branch, we would also have to backport 74540c98. Whatever you think is best is fine with me. OK, I backported these two commits. JMarc -- lyx-devel mailing list lyx-devel@lists.l

Re: [LyX/master] Fixup d207e85c: paint sublabel with the correct background color

2020-06-06 Thread Richard Kimberly Heck
gt; Date:   Mon Feb 24 10:37:14 2020 +0100 >>> >>> Fixup d207e85c: paint sublabel with the correct background color >>> The above mentionned patch did paint the background of the >>> sublabel to >>> avoid "bold-like" eff

Re: [LyX/master] Fixup d207e85c: paint sublabel with the correct background color

2020-06-05 Thread Jean-Marc Lasgouttes
background color The above mentionned patch did paint the background of the sublabel to avoid "bold-like" effect. However the correct backgound color is the row's one, not the inset's one. --- Starting with this commit I can reproduce another background paintin

Re: [LyX/master] Fixup d207e85c: paint sublabel with the correct background color

2020-05-25 Thread Scott Kostyshak
> Author: Jean-Marc Lasgouttes > > > Date: Mon Feb 24 10:37:14 2020 +0100 > > > > > > Fixup d207e85c: paint sublabel with the correct background color > > > > > > The above mentionned patch did paint the background of the sublabel to

Re: [LyX/master] Fixup d207e85c: paint sublabel with the correct background color

2020-05-25 Thread Kornel Benko
t; > Fixup d207e85c: paint sublabel with the correct background color > > > > The above mentionned patch did paint the background of the sublabel to > > avoid "bold-like" effect. However the correct backgound color is the > > row's

Re: [LyX/master] Fixup d207e85c: paint sublabel with the correct background color

2020-05-24 Thread Scott Kostyshak
On Mon, Feb 24, 2020 at 10:24:21AM +0100, Jean-Marc Lasgouttes wrote: > commit 74540c9896892b8f956f52258a59613af83a5cf8 > Author: Jean-Marc Lasgouttes > Date: Mon Feb 24 10:37:14 2020 +0100 > > Fixup d207e85c: paint sublabel with the correct background color >

Re: [RFC][PATCH] Set collapsable inset button background color according to inset background

2012-12-01 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Le 01/12/2012 14:23, Pavel Sanda a écrit : >> Jean-Marc Lasgouttes wrote: >>> I still have to find a better way to highlight a button. >> >> Definitely. Here insets became literally invisible unless uncollapsed >> with the current patch (using black background for most

Re: [RFC][PATCH] Set collapsable inset button background color according to inset background

2012-12-01 Thread Jean-Marc Lasgouttes
Le 01/12/2012 14:23, Pavel Sanda a écrit : Jean-Marc Lasgouttes wrote: I still have to find a better way to highlight a button. Definitely. Here insets became literally invisible unless uncollapsed with the current patch (using black background for most of them as well). With the second patc

Re: [RFC][PATCH] Set collapsable inset button background color according to inset background

2012-12-01 Thread Pavel Sanda
Liviu Andronic wrote: > Please let me know if you're interested. Not really ;) Pavel

Re: [RFC][PATCH] Set collapsable inset button background color according to inset background

2012-12-01 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > I still have to find a better way to highlight a button. Definitely. Here insets became literally invisible unless uncollapsed with the current patch (using black background for most of them as well). Pavel

Re: [RFC][PATCH] Set collapsable inset button background color according to inset background

2012-11-30 Thread Liviu Andronic
On Fri, Nov 30, 2012 at 12:52 PM, Pavel Sanda wrote: > No, that is technically different, it mainly talks about Qt dialogs, > not about editor workarea. ERT or Note can be easily adjusted in prefs. > The bug is actually about colors used in the editor workarea. Even though easily customizable, I w

Re: [RFC][PATCH] Set collapsable inset button background color according to inset background

2012-11-30 Thread Jean-Marc Lasgouttes
1:45 +0100 Subject: [PATCH] Set collapsable inset button background color according to inset background - add a color parameter to Painter::buttonText and Painter::button. The hover color is computed by making the color darker. - pass Inset::backgroundColor as parameter when drawing an collap

Re: [RFC][PATCH] Set collapsable inset button background color according to inset background

2012-11-30 Thread Pavel Sanda
Liviu Andronic wrote: > Could you take a look at http://www.lyx.org/trac/ticket/8325 ? > Addressing this bug should solve such color issues. No, that is technically different, it mainly talks about Qt dialogs, not about editor workarea. ERT or Note can be easily adjusted in prefs. Pavel

Re: [RFC][PATCH] Set collapsable inset button background color according to inset background

2012-11-30 Thread Liviu Andronic
Pavel On Fri, Nov 30, 2012 at 12:12 PM, Pavel Sanda wrote: > On contrary I would suggest adding one more (branch fg) if we are going > to touch branch coloring! :) > I constantly fight with finding 'proper' branch colors because other > people have other backgrounds (which, again, implies differ

Re: [RFC][PATCH] Set collapsable inset button background color according to inset background

2012-11-30 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Comments appreciated. I didn't test the patch, but I'm worried seeing hardcoding like this > @@ -103,7 +103,7 @@ InsetLayout Note:Note > LatexName note > BgColor notebg > LabelFont > - Color note > +

[RFC][PATCH] Set collapsable inset button background color according to inset background

2012-11-30 Thread Jean-Marc Lasgouttes
Hello, The attached patch sets the background color of branch and note insets to the color of the inset background. This is IMO much better from a usability PoV. I did not commit yet because some things are not correct: - there is currently a frame around buttons, I will get rid of it

Re: document dependent color handling - was: [patch] support to change the background color of shaded boxes

2010-04-08 Thread Pavel Sanda
Uwe Stöhr wrote: > > i was proposing to have it coded _internally_ which means that nothing > > changes from the point of the stdinstes files or gui names. only the > > functions for reading and writing would need more code to add/strip > > the filename part. > > OK. > Can you please give me a hin

Re: [patch] support to change the background color of shaded boxes

2010-04-07 Thread Uwe Stöhr
> The patch is well tested and works as expected, except of one Ui-issue: > When loading a file with a shaded box, the color is wrong within LyX. Take for example the > attached LyX-file where the color is set to yellow. Yellow is correctly recognized and used to > paint the button in the menu D

Re: document dependent color handling - was: [patch] support to change the background color of shaded boxes

2010-04-07 Thread Uwe Stöhr
> i was proposing to have it coded _internally_ which means that nothing > changes from the point of the stdinstes files or gui names. only the > functions for reading and writing would need more code to add/strip > the filename part. OK. Can you please give me a hint in what routine I would ha

Re: document dependent color handling - was: [patch] support to change the background color of shaded boxes

2010-04-06 Thread Pavel Sanda
Uwe Stöhr wrote: > This doesn't work because in stdinsets we define the color for e.g. the > greyed-out box as "gereyedouttext". If we would use another color name for > every buffer the inset won't find the color. i was proposing to have it coded _internally_ which means that nothing changes fr

Re: document dependent color handling - was: [patch] support to change the background color of shaded boxes

2010-04-06 Thread Uwe Stöhr
> use something like colorname_identificator_path_filename as color > indetificator internally inside gui? This doesn't work because in stdinsets we define the color for e.g. the greyed-out box as "gereyedouttext". If we would use another color name for every buffer the inset won't find the col

Re: document dependent color handling - was: [patch] support to change the background color of shaded boxes

2010-04-06 Thread Pavel Sanda
Uwe Stöhr wrote: > The problem is that LyX does not store the colors buffer-dependent. If you > have 2 documents opened and switch between them, the colors need to be > updated. (Another manifestation of this bug is > http://www.lyx.org/trac/ticket/6626). > > Does anybody have an idea how to fix

document dependent color handling - was: [patch] support to change the background color of shaded boxes

2010-04-05 Thread Uwe Stöhr
Am 03.04.2010 03:42, schrieb Uwe Stöhr: When loading a file with a shaded box, the color is wrong within LyX. Take for example the attached LyX-file where the color is set to yellow. Yellow is correctly recognized and used to paint the button in the menu Document->Settings->Colors, but the color

Re: [patch] distinguish between default background color and real color

2010-04-05 Thread Uwe Stöhr
the way I did this for the new document-wide font color feature, the attached patch does this for the page background color. I've put it in. regards Uwe

[patch] support to change the background color of shaded boxes

2010-04-02 Thread Uwe Stöhr
|| lc == Color_yellow || lc == Color_inherit || lc == Color_ignore - || lc == Color_greyedouttext) continue; + || lc == Color_greyedouttext + || lc == Color_shadedbg) continue; lcolors_.push_back(lc); } Index: src/frontends/qt4/ui/ColorUi.ui ========

[patch] distinguish between default background color and real color

2010-04-02 Thread Uwe Stöhr
-wide font color feature, the attached patch does this for the page background color. regards Uwe Index: src/Buffer.cpp === --- src/Buffer.cpp (revision 34042) +++ src/Buffer.cpp (working copy) @@ -668,6 +668,7 @@ params().pdfoptions

Re: Unable to reset background color (in GUI)

2009-05-17 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > fixed. > my fault, i reverted my previous 'improvement' for the time being and will > think about it some day later ;) I guess the fix would have been as simple as this: Index: src/Buffer.cpp === --- src/Buffer.c

Re: Unable to reset background color (in GUI)

2009-05-17 Thread Pavel Sanda
Kornel Benko wrote: > Now try to reset this color. GUI allows it, but the output is still yellow. > Setting to any other value than (255, 255, 255) is ok though fixed. my fault, i reverted my previous 'improvement' for the time being and will think about it some day later ;) pavel

Unable to reset background color (in GUI)

2009-05-17 Thread Kornel Benko
Trunk-version. 1.) Create a document 2.) Select background color (to e.g. yellow) Document->Settings...->Page Layout->Background Color: Change... 3.) View Output, everything is as desired Now try to reset this color. GUI allows it, but the output is still yellow. Setting to

Re: background color

2008-10-05 Thread Pavel Sanda
Uwe Stöhr wrote: > > And what was the result for the background color of any widget? > > The current color does not fit to the logo. > > Do you mean that our new "L" logo is not visible? If your OS window style > is blue, then you are right, but we should then b

Re: background color

2008-10-05 Thread Uwe Stöhr
> And what was the result for the background color of any widget? > The current color does not fit to the logo. Do you mean that our new "L" logo is not visible? If your OS window style is blue, then you are right, but we should then better draw a thin black line around the &q

Re: background color

2008-10-05 Thread Pavel Sanda
Peter Kümmel wrote: > The current color does not fit to the logo. i agree with this from aesthetical point of view. instead of changing of background we could make darker those shaded borders of the logo. pavel

Re: background color

2008-10-05 Thread Jürgen Spitzmüller
Peter Kümmel wrote: > And what was the result for the background color of any widget? > The current color does not fit to the logo. > Is it possible to change this color by the dialog or should we > say "you must use the color of your desktop settings"? I think we should let

RE: background color

2008-10-05 Thread leuven edwin
> I think we already had this discussion. i must be getting old. but then again, some discussions are worth forgetting...

Re: background color

2008-10-05 Thread Peter Kümmel
Uwe Stöhr wrote: i would like to suggest to change lyx's default background color to white for 1.6 No. We have discussed this so often in the past. We use for good reason not white. Black/white tires your eyes more than using black/light yellow that we use. In a lecture at the Univers

Re: background color

2008-10-05 Thread Uwe Stöhr
> i would like to suggest to change lyx's default background color to white for 1.6 No. We have discussed this so often in the past. We use for good reason not white. Black/white tires your eyes more than using black/light yellow that we use. In a lecture at the University I also he

Re: background color

2008-10-05 Thread Jürgen Spitzmüller
leuven edwin wrote: > i would like to suggest to change lyx's default background color to white > for 1.6 > > white seems to be the default background color for text entry on most > platforms... I think we already had this discussion. Jürgen

background color

2008-10-05 Thread leuven edwin
i would like to suggest to change lyx's default background color to white for 1.6 white seems to be the default background color for text entry on most platforms... laundry.patch Description: laundry.patch

Re: Background color for math insets

2001-07-03 Thread Andre Poenitz
> Anyway, it's configurable, so at least we have a new feature. (The only > one from the meeting? :-) No, have a look at Dekel's list... we have a lot new features now... Andre' -- André Pönitz . [EMAIL PROTECTED]

Re: Background color for math insets

2001-07-03 Thread Dekel Tsur
On Tue, Jul 03, 2001 at 01:36:20PM +0200, Asger K. Alstrup Nielsen wrote: > > - I don't like the different background color for math insets. > > If you can find a color which is *very* close to linen, I hope you will > all like a new background color for math. I think it w

Re: Background color for math insets

2001-07-03 Thread Asger K. Alstrup Nielsen
> - I don't like the different background color for math insets. If you can find a color which is *very* close to linen, I hope you will all like a new background color for math. I think it will help to subtly identify inline math in your text. That was the original plan, but I decided

Re: selection and background color

2000-07-17 Thread Jean-Marc Lasgouttes
> "Peer" == Peer Frank <[EMAIL PROTECTED]> writes: Peer> some few settings in lyxrc do not work anymore: Peer> LyX: Unknown tag `\background_color' [around line 188 of file Peer> ~/.lyx/lyxrc] LyX: Unknown tag `lightyellow' [around line 189 of Peer> file ~/.lyx/lyxrc] LyX: Unknown tag `\sel

selection and background color

2000-07-17 Thread Peer Frank
Hi: some few settings in lyxrc do not work anymore: LyX: Unknown tag `\background_color' [around line 188 of file ~/.lyx/lyxrc] LyX: Unknown tag `lightyellow' [around line 189 of file ~/.lyx/lyxrc] LyX: Unknown tag `\selection_color' [around line 192 of file ~/.lyx/lyxrc] LyX: Unknown tag `gree

Lyx Popup background color. (fwd)

1999-12-05 Thread Asger K. Alstrup Nielsen
ost) by eda01.ee.cityu.edu.hk (8.8.8+Sun/8.8.8) id JAA17608 for [EMAIL PROTECTED]; Sun, 5 Dec 1999 09:57:09 +0800 (HKT) Date: Sun, 5 Dec 1999 09:57:09 +0800 (HKT) From: Zhang Bo <[EMAIL PROTECTED]> Message-Id: <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Subject: Lyx Po