RE: [patch] Re: The disabling of submenus

2009-01-16 Thread Vincent van Ravesteijn - TNW
>Also, is there a rationale as to which ones get the >and which ones don't? I'm guessing there is, but I couldn't >figure it out. The idea was that the 'Help' items would tell the user what he should do if he wants to use a specific feature. Thus, Insert->Branch would tell the user to 'set a br

Re: [patch] Re: The disabling of submenus

2009-01-14 Thread rgheck
this looks good to me...but... Index: src/frontends/qt4/Menus.cpp === --- src/frontends/qt4/Menus.cpp (revision 28166) +++ src/frontends/qt4/Menus.cpp (working copy) @@ -95,6 +95,15 @@ Submenu, ///

[patch] Re: The disabling of submenus

2009-01-14 Thread Vincent van Ravesteijn
Solutions I see: 1/ disable the menu only if it is empty (and apply Vincent's patch to remove 'No Document Open' entries). YES, for cases like Insert->Float. Now we have a type MenuItem::Info for this kind of not so very helpful messages. 2/ gray out the submenu but keep it openabl

RE: The disabling of submenus

2009-01-07 Thread Vincent van Ravesteijn - TNW
>> This patch disables all submenus in the menu bar that have no enabled >> items. > >This is something I have not done until then because the HIG are not very clear... Oh no, not again the HIGs... >* Apple HIG states: > >Even if all of the items in a menu or submenu are unavailable, the menu >o

Re: The disabling of submenus

2009-01-07 Thread Jean-Marc Lasgouttes
Abdelrazak Younes writes: > Maybe this was not possible in the previous menu backend. Ha! JMarc

Re: The disabling of submenus

2009-01-07 Thread Jean-Marc Lasgouttes
Vincent van Ravesteijn writes: > This patch disables all submenus in the menu bar that have no enabled > items. This is something I have not done until then because the HIG are not very clear... * Apple HIG states: Even if all of the items in a menu or submenu are unavailable, the menu or s

Re: The disabling of submenus

2009-01-06 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > None from me. From me neither, but I would await Jean-Marc's comment. Jürgen

Re: The disabling of submenus

2009-01-06 Thread Abdelrazak Younes
Vincent van Ravesteijn wrote: Hi all, This patch disables all submenus in the menu bar that have no enabled items. The code for determining whether a submenu should be enabled is already present, but it is not used because the following line was missing: subMenu->setEnabled(m->

Re: The disabling of submenus

2009-01-06 Thread rgheck
Vincent van Ravesteijn wrote: Hi all, This patch disables all submenus in the menu bar that have no enabled items. The code for determining whether a submenu should be enabled is already present, but it is not used because the following line was missing: subMenu->setEnabled(m->

The disabling of submenus

2009-01-06 Thread Vincent van Ravesteijn
Hi all, This patch disables all submenus in the menu bar that have no enabled items. The code for determining whether a submenu should be enabled is already present, but it is not used because the following line was missing: subMenu->setEnabled(m->status().enabled()); However, a