Michael Gerz wrote:
Abdelrazak Younes schrieb:
Here is a slightly modified version of Stefan's patch.
I am not a QT expert but the patch seems to make sense!
OK. As Jurgen agreed and Jose did not object, I've committed it.
We are now *forced* to find proper bindings for the outline LFUNs. I'
On Fri, May 04, 2007 at 05:46:40PM +0200, Michael Gerz wrote:
> Abdelrazak Younes schrieb:
> >Here is a slightly modified version of Stefan's patch.
> I am not a QT expert but the patch seems to make sense!
I'd wager a guess that none of us is a QuickTime expert ;-)
Andre'
Abdelrazak Younes schrieb:
Here is a slightly modified version of Stefan's patch.
I am not a QT expert but the patch seems to make sense!
Michael
Michael Gerz wrote:
Jürgen Spitzmüller schrieb:
Michael Gerz wrote:
Any comments on this issues are welcome. I would like to get some
opinions before I change the po file.
remove the shortcuts from the dialog and introduce general shortcuts
for the outliner actions.
Abdel,
do you
Edwin Leuven wrote:
Abdelrazak Younes wrote:
So, does this need to be fixed? I have erased my user dir and
restarted and still don't see the icon.
just commited the fix...
thanks.
Abdelrazak Younes schrieb:
Edwin Leuven wrote:
Abdelrazak Younes wrote:
Yes, the patch from Stefan. I would like to commit it but I have a
problem: I can see that the toggle TOC menu item works correctly but
the former TOC toolbar button is not there anymore, I don't know
why... Do you see it
Abdelrazak Younes wrote:
So, does this need to be fixed? I have erased my user dir and restarted
and still don't see the icon.
just commited the fix...
Abdelrazak Younes schrieb:
Edwin Leuven wrote:
Abdelrazak Younes wrote:
Yes, the patch from Stefan. I would like to commit it but I have a
problem: I can see that the toggle TOC menu item works correctly but
the former TOC toolbar button is not there anymore, I don't know
why... Do you see it
Edwin Leuven wrote:
Abdelrazak Younes wrote:
Yes, the patch from Stefan. I would like to commit it but I have a
problem: I can see that the toggle TOC menu item works correctly but
the former TOC toolbar button is not there anymore, I don't know
why... Do you see it?
the correct toolbar item
Abdelrazak Younes wrote:
Yes, the patch from Stefan. I would like to commit it but I have a
problem: I can see that the toggle TOC menu item works correctly but the
former TOC toolbar button is not there anymore, I don't know why... Do
you see it?
the correct toolbar item has become
dialog-t
Michael Gerz wrote:
Jürgen Spitzmüller schrieb:
Michael Gerz wrote:
Any comments on this issues are welcome. I would like to get some
opinions before I change the po file.
remove the shortcuts from the dialog and introduce general shortcuts
for the outliner actions.
Abdel,
do you
Jürgen Spitzmüller schrieb:
Michael Gerz wrote:
Any comments on this issues are welcome. I would like to get some
opinions before I change the po file.
remove the shortcuts from the dialog and introduce general shortcuts for the
outliner actions.
Abdel,
do you have a suitable pat
Abdelrazak Younes wrote:
> If you agree with that, I'll commit his patch which I have locally
> applied for some days already.
I agree, but please check whether it interferes with some of my recent changes
(I remember the patch also did something about the menu toogle thing).
Jürgen
Michael Gerz wrote:
Jürgen Spitzmüller schrieb:
Michael Gerz wrote:
Any comments on this issues are welcome. I would like to get some
opinions before I change the po file.
remove the shortcuts from the dialog and introduce general shortcuts
for the outliner actions.
Abdel, shouldn'
Michael Gerz wrote:
> Abdel, shouldn't we remove the shortcuts in the UI files, too (i.e. in
> the English messages).
That's what I meant.
> This may also open the door for buttons with icons.
Probably yes.
Jürgen
Jürgen Spitzmüller schrieb:
Michael Gerz wrote:
Any comments on this issues are welcome. I would like to get some
opinions before I change the po file.
remove the shortcuts from the dialog and introduce general shortcuts for the
outliner actions.
Abdel, shouldn't we remove the shor
Michael Gerz wrote:
> Any comments on this issues are welcome. I would like to get some
> opinions before I change the po file.
remove the shortcuts from the dialog and introduce general shortcuts for the
outliner actions.
Jürgen
Jürgen Spitzmüller schrieb:
I know now what's happening. I just discovered that it's locale-dependend.
Michael, in the German localization, you cannot use the accelerator "A" for
the TOC dialog (which is in fact used twice), for this breaks the fundamental
keyboard shortcuts M-a {1,2,...} in t
Helge Hafting wrote:
> Richard Heck wrote:
>> The thing I don't understand is why I'd only get the loop sometimes.
>> Not every time. Anyway, I'm glad not to have to worry about this any
>> more.
> This is an unknown bug in qt, right? My guess is that there is indeed
> a loop somewhere, that uses
Richard Heck wrote:
Jürgen Spitzmüller wrote:
Richard Heck wrote:
By the way, look at TocWidget::setTocModel(). It enables depthSL no
matter what. Shouldn't it be: depthSL->setEnabled(buttons_enabled)?
Should reconnectSelectionModel() be called there if buttons_enabled =
false? Unfortunately,
As the original bug reporter, I confirm that this problem does not
occur with the latest svn. Thanks.
On 4/17/07, Jürgen Spitzmüller <[EMAIL PROTECTED]> wrote:
This is the case in the version I committed:
-void TocWidget::enableButtons(bool enable)
+void TocWidget::enableControls(bool enable)
Jürgen Spitzmüller wrote:
Richard Heck wrote:
By the way, look at TocWidget::setTocModel(). It enables depthSL no
matter what. Shouldn't it be: depthSL->setEnabled(buttons_enabled)?
Should reconnectSelectionModel() be called there if buttons_enabled =
false? Unfortunately, changing the former
Richard Heck wrote:
> I think maybe there should also be an "else" clause here that disables
> the slider if buttons_enabled is false. Otherwise, I worry someone could
> delete the last section, thereby emptying the TOC, and we'd see the same
> behavior.
This is the case in the version I committed
Abdelrazak Younes wrote:
> Ah, I misread your report then.
No, in fact I was missing the point.
> I suppose we could add something like
> that to the widget indeed.
> But there is an easy work-around: hit "Tab" and the focus will get back
> to the main window. I guess we could also catch for th
Jürgen Spitzmüller wrote:
Abdelrazak Younes wrote:
A first-step and short-term solution is to remove them: Just remove the
'&' in the label defined in the ui file.
A better solution would be to affect good shortcuts to the outline
functions. We already discussed that but no action were taken.
Abdelrazak Younes wrote:
> A first-step and short-term solution is to remove them: Just remove the
> '&' in the label defined in the ui file.
>
> A better solution would be to affect good shortcuts to the outline
> functions. We already discussed that but no action were taken.
I see.
So there's no
Jürgen Spitzmüller wrote:
BTW is there something we can do about TOC widget swallowing keyboard
shortcuts? This is pretty annyoing.
A first-step and short-term solution is to remove them: Just remove the
'&' in the label defined in the ui file.
A better solution would be to affect good shor
Jürgen Spitzmüller wrote:
> Good idea. I'll do that and commit, since you confirmed it works.
Actually, I only transferred the setEnabled part, because we do not have
access to type in enableControls.
Jürgen
BTW is there something we can do about TOC widget swallowing keyboard
shortcuts? This
Abdelrazak Younes wrote:
> Maybe you could transfer this code to enableButtons() instead? And maybe
> rename enableButtons() to enableControls()
Good idea. I'll do that and commit, since you confirmed it works.
Jürgen
Jürgen Spitzmüller wrote:
Index: src/frontends/qt4/TocWidget.C
===
--- src/frontends/qt4/TocWidget.C (Revision 17834)
+++ src/frontends/qt4/TocWidget.C (Arbeitskopie)
@@ -253,9 +253,11 @@
enableButtons(buttons_ena
Jürgen Spitzmüller wrote:
Richard Heck wrote:
Well, shoot. It's not working for me either, any more. Very strange
this.
It's not that strange. The clause where the slider is disabled is not
necessarily called when the TOC is empty (only when the type list is empty,
which doesn't happen for
Richard Heck wrote:
John McCabe-Dansted wrote:
Sometimes it just slows down instead of crashing. It could be that the
"crash" is in fact the software requiring more time than my patience
allows (it takes a minute or so just to allow the mouse to move. In
several minutes nothing draws.)
Yes, I t
Richard Heck wrote:
Jürgen Spitzmüller wrote:
Richard Heck wrote:
Try the patch below, then.
Unfortunately, it does not work for me.
Well, shoot. It's not working for me either, any more. Very strange
this. For what it's worth, I haven't been able to trigger the freeze if
I hide th
Richard Heck wrote:
> Well, shoot. It's not working for me either, any more. Very strange
> this.
It's not that strange. The clause where the slider is disabled is not
necessarily called when the TOC is empty (only when the type list is empty,
which doesn't happen for me, there's always the one
Jürgen Spitzmüller wrote:
> Richard Heck wrote:
>
>> Try the patch below, then.
>>
> Unfortunately, it does not work for me.
>
Well, shoot. It's not working for me either, any more. Very strange
this. For what it's worth, I haven't been able to trigger the freeze if
I hide the slider alt
John McCabe-Dansted wrote:
> Sometimes it just slows down instead of crashing. It could be that the
> "crash" is in fact the software requiring more time than my patience
> allows (it takes a minute or so just to allow the mouse to move. In
> several minutes nothing draws.)
Yes, I think it's more a
On 4/17/07, Richard Heck <[EMAIL PROTECTED]> wrote:
I don't know exactly what's going on here, but I think I can solve the
problem. I also think it's a QT bug, not ours.
OK, my qt4 is 4.2.3:
% rpm -qa | grep qt4
qt4-4.2.3-3.fc6.1
qt4-devel-4.2.3-3.fc6.1
qt4-x11-4.2.3-3.fc6.1
-
Richard Heck wrote:
> Leaving the slider enabled is harmless: It doesn't do anything if
> there's nothing in the TOC, anyway.
Sure? It used to crash LyX (that' why we disabled it).
> Try the patch below, then.
Unfortunately, it does not work for me.
Jürgen
Richard Heck wrote:
> I don't know exactly what's going on here, but I think I can solve the
> problem. I also think it's a QT bug, not ours.
>
> At first I thought there must be some kind of event loop. But adding
> some lyxerr's to GuiApplication::notify() showed me that it wasn't:
> You'd get a
I don't know exactly what's going on here, but I think I can solve the
problem. I also think it's a QT bug, not ours.
At first I thought there must be some kind of event loop. But adding
some lyxerr's to GuiApplication::notify() showed me that it wasn't:
You'd get a paint event for the slider, bu
Jürgen Spitzmüller wrote:
John McCabe-Dansted wrote:
I am getting ToC crashes again. This is with SVN of 16 Apr on FC6.
I don't get the crash, but I see the (dramatic) slowdown.
I've been investigating this bug for a long time without success :-(
Do you have a backtrace?
On windows, the
John McCabe-Dansted wrote:
> I am getting ToC crashes again. This is with SVN of 16 Apr on FC6.
I don't get the crash, but I see the (dramatic) slowdown.
Do you have a backtrace?
Jürgen
On 4/10/07, Jürgen Spitzmüller <[EMAIL PROTECTED]> wrote:
excellent detective work!
I can confirm that the crash is gone.
I am getting ToC crashes again. This is with SVN of 16 Apr on FC6.
To replicate:
1) Start LyX
2) Press "Cntl-N" (new document)
3) Press "Alt-D", then "T" (Table of contents
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
>> The solution was incredibly stupid: there was a (unused!)
>> header included *before* . This was defining
>> std::string without stdlib-debug support, and this does not have
>> the same memory layout as the code in the rest o
Abdelrazak Younes wrote:
Jean-Marc Lasgouttes wrote:
"Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
Jean-Marc> I think that the problem is that the QToc thingy has not
Jean-Marc> been properly allocated. See the following gbb session
Jean-Marc> snippet. Note that
Jean-Marc Lasgouttes wrote:
"Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
Jean-Marc> I think that the problem is that the QToc thingy has not
Jean-Marc> been properly allocated. See the following gbb session
Jean-Marc> snippet. Note that lfun_name_ value is 0x0, w
Jean-Marc Lasgouttes wrote:
> The solution was incredibly stupid: there was a (unused!)
> header included *before* . This was defining std::string
> without stdlib-debug support, and this does not have the same memory
> layout as the code in the rest of LyX.
excellent detective work!
I can confir
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
Jean-Marc> I think that the problem is that the QToc thingy has not
Jean-Marc> been properly allocated. See the following gbb session
Jean-Marc> snippet. Note that lfun_name_ value is 0x0, which is AFAIK
Jean-Marc> not possible
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> The only thing to do is to debug step to step and verify
Abdelrazak> that 'data' are passed correctly in initialiseParams().
Abdelrazak> You should start by putting a breakpoint at
Abdelrazak> ControlToc::initialisePa
Abdelrazak Younes wrote:
> I just committed some cleanup, please try again.
Still the same :-(
Jürgen
Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Jean-Marc Lasgouttes wrote:
I decided to try again the table of contents (which was always
disabled), and now it crashes LyX with file Intro.lyx.
Backtrace follows. If I look at frame 2, lfun
Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Jean-Marc Lasgouttes wrote:
I decided to try again the table of contents (which was always
disabled), and now it crashes LyX with file Intro.lyx.
Backtrace follows. If I look at frame 2, lfun
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Jean-Marc Lasgouttes wrote:
>> I decided to try again the table of contents (which was always
>> disabled), and now it crashes LyX with file Intro.lyx.
>>
>> Backtrace follows. If I look at frame 2, lfun_name_ is not
Abdelrazak Younes wrote:
> Does the attached patch fixes the problem?
Not for me.
Jürgen
Jean-Marc Lasgouttes wrote:
I decided to try again the table of contents (which was always
disabled), and now it crashes LyX with file Intro.lyx.
Backtrace follows. If I look at frame 2, lfun_name_ is not initialized
correctly:
Interesting... Does the attached patch fixes the problem?
Abdel.
I decided to try again the table of contents (which was always
disabled), and now it crashes LyX with file Intro.lyx.
Backtrace follows. If I look at frame 2, lfun_name_ is not initialized
correctly:
(gdb) frame 2
#2 0x08b0ee5f in lyx::frontend::ControlCommand::initialiseParams (
this=0x934
56 matches
Mail list logo
