Re: Road to rc2

2007-06-26 Thread José Matos
On Tuesday 26 June 2007 17:11:26 Stefan Schimanski wrote: > > Fixed in r18741. > Fixed in r18774. > Fixed in 18742. > Fixed in 18737. > > Stefan OK. Nice to know. :-) -- José Abílio

Re: Road to rc2

2007-06-26 Thread Stefan Schimanski
Am 26.06.2007 um 16:18 schrieb José Matos: On Sunday 10 June 2007 16:17:48 Stefan Schimanski wrote: I have posted several patches which are waiting to go in or a comment why not: * [patch] sometimes only paragraph of cursor is visible, #3231 Fixed in r18741. * [patch] Up/down cursor in ma

Re: Road to rc2

2007-06-26 Thread José Matos
On Sunday 10 June 2007 16:17:48 Stefan Schimanski wrote: > I have posted several patches which are waiting to go in or a comment   > why not: > > * [patch] sometimes only paragraph of cursor is visible, #3231 > * [patch] Up/down cursor in math-macro jumps out of the macro, #3830 > * [patch] fixing

Re: Road to rc2

2007-06-11 Thread Abdelrazak Younes
Stefan Schimanski wrote: - What are the patches submitted that you think deserve attention? I would like to give special attention to critical bugs and so on... I have posted several patches which are waiting to go in or a comment why not: * [patch] sometimes only paragraph of cursor

Re: Road to rc2 - fixIfBroken

2007-06-11 Thread Stefan Schimanski
CursorSlice & CursorSlice::operator=(CursorSlice const & cs) { inset_ = cs.inset_; idx_ = cs.idx_; pit_ = cs.pit_; pos_ = cs.pos_; - if (inset_ && inset_->destroyedSignal()) { - inset_connection_ = inset_->destroyedSignal()->connect( -

Re: Road to rc2 - fixIfBroken

2007-06-10 Thread Andre Poenitz
On Sat, Jun 09, 2007 at 12:49:09PM +0200, Stefan Schimanski wrote: > It works fine (as far as I can judge after 2 minutes testing). I > added some comments and pulled apart the loop to make the control > flow easier. Alfredo, can you check please? I would be happy if we > could get rid of the

Re: Road to rc2

2007-06-10 Thread Andre Poenitz
On Fri, Jun 08, 2007 at 10:40:45PM +0200, [EMAIL PROTECTED] wrote: > On Fri, 8 Jun 2007, José Matos wrote: > > >On Friday 08 June 2007 16:59:35 [EMAIL PROTECTED] wrote: > >>In Sweden, June 22nd would be a bad choice because it's a big holiday - > >>everybody is off. I'll be in the archipelago for

Re: Road to rc2

2007-06-10 Thread Stefan Schimanski
- What are the patches submitted that you think deserve attention? I would like to give special attention to critical bugs and so on... I have posted several patches which are waiting to go in or a comment why not: * [patch] sometimes only paragraph of cursor is visible, #323

Re: Road to rc2 - fixIfBroken

2007-06-09 Thread Stefan Schimanski
Am 09.06.2007 um 15:05 schrieb Abdelrazak Younes: Stefan Schimanski wrote: Am 09.06.2007 um 14:46 schrieb Abdelrazak Younes: Stefan Schimanski wrote: Ok, committed. So let's see if everything is alright now. We still have some days to the RC2 for testing. If the testing reveals that we do

Re: Road to rc2 - fixIfBroken

2007-06-09 Thread Abdelrazak Younes
Stefan Schimanski wrote: Am 09.06.2007 um 14:46 schrieb Abdelrazak Younes: Stefan Schimanski wrote: Ok, committed. So let's see if everything is alright now. We still have some days to the RC2 for testing. If the testing reveals that we don't need the Inset::destroyed() signal, this should

Re: Road to rc2 - fixIfBroken

2007-06-09 Thread Abdelrazak Younes
Stefan Schimanski wrote: Am 09.06.2007 um 14:46 schrieb Abdelrazak Younes: Stefan Schimanski wrote: Ok, committed. So let's see if everything is alright now. We still have some days to the RC2 for testing. If the testing reveals that we don't need the Inset::destroyed() signal, this should

Re: Road to rc2 - fixIfBroken

2007-06-09 Thread Stefan Schimanski
Am 09.06.2007 um 14:46 schrieb Abdelrazak Younes: Stefan Schimanski wrote: Ok, committed. So let's see if everything is alright now. We still have some days to the RC2 for testing. If the testing reveals that we don't need the Inset::destroyed() signal, this should be deleted before RC2 t

Re: Road to rc2 - fixIfBroken

2007-06-09 Thread Abdelrazak Younes
Stefan Schimanski wrote: Ok, committed. So let's see if everything is alright now. We still have some days to the RC2 for testing. If the testing reveals that we don't need the Inset::destroyed() signal, this should be deleted before RC2 too. Abdel.

Re: Road to rc2 - fixIfBroken

2007-06-09 Thread Stefan Schimanski
Ok, committed. So let's see if everything is alright now. We still have some days to the RC2 for testing. Stefan Am 09.06.2007 um 14:32 schrieb Alfredo Braunstein: Abdelrazak Younes wrote: Stefan Schimanski wrote: It works fine (as far as I can judge after 2 minutes testing). I added som

Re: Road to rc2 - fixIfBroken

2007-06-09 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > Stefan Schimanski wrote: >> It works fine (as far as I can judge after 2 minutes testing). I added >> some comments and pulled apart the loop to make the control flow easier. >> Alfredo, can you check please? I would be happy if we could get rid of >> the signals finally

Re: Road to rc2 - fixIfBroken

2007-06-09 Thread Abdelrazak Younes
Stefan Schimanski wrote: It works fine (as far as I can judge after 2 minutes testing). I added some comments and pulled apart the loop to make the control flow easier. Alfredo, can you check please? I would be happy if we could get rid of the signals finally like this. I am not Alfredo but i

Re: Road to rc2 - fixIfBroken

2007-06-09 Thread Stefan Schimanski
Am 09.06.2007 um 13:09 schrieb Alfredo Braunstein: Stefan Schimanski wrote: It works fine (as far as I can judge after 2 minutes testing). I added some comments and pulled apart the loop to make the control flow easier. Alfredo, can you check please? I would be happy if we could get rid of th

Re: Road to rc2 - fixIfBroken

2007-06-09 Thread Alfredo Braunstein
Stefan Schimanski wrote: > It works fine (as far as I can judge after 2 minutes testing). I > added some comments and pulled apart the loop to make the control > flow easier. Alfredo, can you check please? I would be happy if we > could get rid of the signals finally like this. Sure, but I cannot

Re: Road to rc2 - fixIfBroken

2007-06-09 Thread Stefan Schimanski
It works fine (as far as I can judge after 2 minutes testing). I added some comments and pulled apart the loop to make the control flow easier. Alfredo, can you check please? I would be happy if we could get rid of the signals finally like this. Stefan Index: lyx-devel/src/CursorSlice.cpp

Re: Road to rc2 - fixIfBroken

2007-06-09 Thread Alfredo Braunstein
Stefan Schimanski wrote: >>> Some small questions: >>> Why don't you like comments? >> >> ? Be more specific. OTOH, I would have like some comment of yours >> when I >> asked for them a week ago... ;-) > > Sorry, meant something like two lines describing what the big loop is > doing. Not the comm

Re: Road to rc2 - fixIfBroken

2007-06-09 Thread Jürgen Spitzmüller
Stefan Schimanski wrote: > I guess yes. Compiling right now. If it does, that would be great.   > Signals in those CursorSlices, always feel in a strange way when   > thinking about it :) Since you are at it, could you please just commit if you think it is correct? Jürgen

Re: Road to rc2 - fixIfBroken

2007-06-09 Thread Stefan Schimanski
Some small questions: Why don't you like comments? ? Be more specific. OTOH, I would have like some comment of yours when I asked for them a week ago... ;-) Sorry, meant something like two lines describing what the big loop is doing. Not the comments here :) Why do you need this compli

Re: Road to rc2 - fixIfBroken

2007-06-09 Thread Alfredo Braunstein
Stefan Schimanski wrote: > Some small questions: > Why don't you like comments? ? Be more specific. OTOH, I would have like some comment of yours when I asked for them a week ago... ;-) > Why do you need this complicated logic to set the inset to 0 in many > cases. Won't that end the loop anyway

Re: Road to rc2 - fixIfBroken

2007-06-09 Thread Stefan Schimanski
Am 09.06.2007 um 00:28 schrieb Alfredo Braunstein: Jean-Marc Lasgouttes wrote: Yes, the patch looks good, except that the messages are not very informative (but as a usr I would be scared to see all these messages in normal operation). And there is a very long line. Fixed. Note that the sca

Re: Road to rc2

2007-06-08 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > Yes, the patch looks good, except that the messages are not very > informative (but as a usr I would be scared to see all these messages > in normal operation). And there is a very long line. Fixed. Note that the scary messages are already there in svn. Please apply

Re: Road to rc2

2007-06-08 Thread christian . ridderstrom
On Fri, 8 Jun 2007, José Matos wrote: On Friday 08 June 2007 16:59:35 [EMAIL PROTECTED] wrote: In Sweden, June 22nd would be a bad choice because it's a big holiday - everybody is off. I'll be in the archipelago for instance. I'm guessing Martin might be off as well? What is the problem? If

Re: Road to rc2

2007-06-08 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Alfredo> José Matos wrote: >> - What are the patches submitted that you think deserve attention? >> I would like to give special attention to critical bugs and so >> on... Alfredo> This fixes a crash with multiple views... Alfredo

Re: Road to rc2

2007-06-08 Thread José Matos
On Friday 08 June 2007 16:59:35 [EMAIL PROTECTED] wrote: > In Sweden, June 22nd would be a bad choice because it's a big holiday - > everybody is off. I'll be in the archipelago for instance. I'm guessing > Martin might be off as well? What is the problem? If you have one more reason to celebrat

Re: Road to rc2

2007-06-08 Thread christian . ridderstrom
On Fri, 8 Jun 2007, José Matos wrote: in the release of rc1. The new schedule can be found in the usual place: http://wiki.lyx.org/Devel/ReleaseSchedule (Executive summary: rc2 - 15 June; final - 22 June) In Sweden, June 22nd would be a bad choice because it's a big holiday - everybody is off

Re: Road to rc2

2007-06-08 Thread christian . ridderstrom
On Fri, 8 Jun 2007, Bo Peng wrote: Christian and I have to fix the dictionary downloading problem of the windows installer before RC2. I agree. My problem is a lack of a Windows machine at home, but I think I can work on it during next week. Has anyone heard from Joost in a while? /Christi

Re: Road to rc2

2007-06-08 Thread Alfredo Braunstein
José Matos wrote: > - What are the patches submitted that you think deserve attention? > I would like to give special attention to critical bugs and so on... This fixes a crash with multiple views... http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg119336.html A/

Re: Road to rc2

2007-06-08 Thread Bo Peng
I do not really care about math hover and splitlayout patches, they can go in or be reverted as you wish. I do want the 'allowing arbitrary listings parameter' patch to go in before rc2. Otherwise, new features of listings can not be used. Christian and I have to fix the dictionary downloading p

Re: Road to rc2

2007-06-08 Thread Bo Peng
http://bugzilla.lyx.org/show_bug.cgi?id=3313 Strongly agreed. Bo

Re: Road to rc2

2007-06-08 Thread hzluo
I think this one should be in as it is marked critical now: http://bugzilla.lyx.org/show_bug.cgi?id=3750 If somebody can make a better patch I'm happy for that :-) BTW, there are several other latex syntax that lyx output but tex2lyx can't translate, results in the lyx-exported .tex can't be i

Re: Road to rc2

2007-06-08 Thread Jürgen Spitzmüller
José Matos wrote: > That is in my todo list as well, I will work on the patch to fix it. Thanks. Attached is the recent patch. Jürgen Index: lib/lyx2lyx/LyX.py === --- lib/lyx2lyx/LyX.py (Revision 18710) +++ lib/lyx2lyx/LyX.py (Arbei

Re: Road to rc2

2007-06-08 Thread José Matos
On Friday 08 June 2007 07:33:49 Jürgen Spitzmüller wrote: > I really like to finally get the patch for bug 1749 in. Just lyx2lyx is > missing (but nobody seems to hear my call for help). That is in my todo list as well, I will work on the patch to fix it. > Jürgen -- José Abílio

Re: Road to rc2

2007-06-08 Thread José Matos
On Friday 08 June 2007 06:45:14 Anders Ekberg wrote: > Since the most need for saving as 1.4.x should occur in the   > transition to 1.5, I think > http://bugzilla.lyx.org/show_bug.cgi?id=3313 > should be addressed in 1.5.0. If the patch doesn't go in at least the   > error message needs to be impr

Re: Road to rc2

2007-06-07 Thread Jürgen Spitzmüller
José Matos wrote: > - What are the patches submitted that you think deserve attention? > I would like to give special attention to critical bugs and so > on... I really like to finally get the patch for bug 1749 in. Just lyx2lyx is missing (but nobody seems to hear my call for help). Jür

Re: Road to rc2

2007-06-07 Thread Anders Ekberg
José Matos Thu, 07 Jun 2007 16:05:49 -0700 - What are the patches submitted that you think deserve attention? I would like to give special attention to critical bugs and so on. Since the most need for saving as 1.4.x should occur in the transition to 1.5, I think http://bugz

Re: Road to rc2

2007-06-07 Thread Stefan Schimanski
Am 08.06.2007 um 01:22 schrieb Bennett Helm: On Jun 7, 2007, at 7:01 PM, José Matos wrote: Hi, I have changed the proposed schedule for 1.5.0 taking into account the delay in the release of rc1. The new schedule can be found in the usual place: http://wiki.lyx.org/Devel/ReleaseSchedule

Re: Road to rc2

2007-06-07 Thread Bennett Helm
On Jun 7, 2007, at 7:01 PM, José Matos wrote: Hi, I have changed the proposed schedule for 1.5.0 taking into account the delay in the release of rc1. The new schedule can be found in the usual place: http://wiki.lyx.org/Devel/ReleaseSchedule (Executive summary: rc2 - 15 June; final - 22 Ju

Road to rc2

2007-06-07 Thread José Matos
Hi, I have changed the proposed schedule for 1.5.0 taking into account the delay in the release of rc1. The new schedule can be found in the usual place: http://wiki.lyx.org/Devel/ReleaseSchedule (Executive summary: rc2 - 15 June; final - 22 June) I would like to only allow fixes