John Levon wrote:
> This seems too risky for 1.3.0 now IMO. Can you open a bug on bugzilla
> and put the patch there ?
Done.
>
> Same goes for your other remaining patch, I think ...
Added the patch to the existing bug.
> Also, neither are regressions from 1.2.x
Agree.
>
> regards
> john
On Wed, Dec 18, 2002 at 12:08:26PM +0100, Alfredo Braunstein wrote:
> Ok. I've unlocked the inset and seems to work. Seems that there is no need
> to actually lock the target (ok, it's a different problem that we have
> already: going to a reference or bookmark inside a float leaves you before
On Tue, Dec 17, 2002 at 02:58:04PM +0100, Alfredo Braunstein wrote:
> >
> > I only want the _minimal_ fix for this problem now, even if that might
> > be a bit hackish or over-simplified.
> >
>
> This would be it.
[the double-dialog patch]
It worked for me - I applied it.
regards
john
--
"
Andre Poenitz wrote:
> Probably by unlocking all insets and re-locking the target position... But
> as I never really understood how this is supposed to work this might be
> complete bogus. In any case, this has bitten us so often that using proper
> document iterators instead of the current "dist
On Tue, Dec 17, 2002 at 04:15:25PM +0100, Alfredo Braunstein wrote:
> Further on this one: its not related to the insert-reference stuff. Go
> inside an inset (colapsable, math, etc) and run "reference-goto somelabel"
> lfun, with a valid label outside the inset. The real cursor seem to remain
>
Alfredo Braunstein wrote:
> Well, this is only for non isHiglyEditable() insets, which do not have a
> localDispatch() anyway. Since we are effectively handling the event there
> (calling edit()), it seems correct not to call it. But it's up to you.
So? Should I make again the patch, including th
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
Jean-Marc> There are several functions that suffer from this problem:
Jean-Marc> Insert>LyX File in a float, go to bookmark, etc. In
Jean-Marc> general, it seems that fixing these is messy and we need
Jean-Marc> good inset itera
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes:
Alfredo> Alfredo Braunstein wrote:
>> Btw: I've found an (unrelated) bug. If you insert a reference
>> within a float, choose a label from the list (located outside the
>> float), and click GOTO, the cursor ends up on wrong or unexi
Alfredo Braunstein wrote:
> Btw: I've found an (unrelated) bug. If you insert a reference within a
> float, choose a label from the list (located outside the float), and click
> GOTO, the cursor ends up on wrong or unexistent positions. Will try to dig
> further.
Further on this one: its not rela
>>Btw: I've found an (unrelated) bug. If you insert a reference within a
>>float, choose a label from the list (located outside the float),and click
>>GOTO, the cursor ends up on wrong or unexistent positions. Will try to dig
>>further.
> I.e. the call to localDispatch() is completely gone?
> And
Lars Gullik Bjønnes wrote:
> Andre Poenitz <[EMAIL PROTECTED]> writes:
>
> | On Tue, Dec 17, 2002 at 09:38:47AM +0100, Alfredo Braunstein wrote:
> | > It fixes a critical bug (subject of the thread)...
> |
> | Aehm. Already forgot that...
> |
> | Ok, so let's have Lars' nod on that.
>
> I only
> > It fixes a critical bug (subject of the thread)...
>
> Aehm. Already forgot that...
>
> Ok, so let's have Lars' nod on that.
It seems that this bug is also a regression to 1.2.2cvs.
Michael
Andre Poenitz <[EMAIL PROTECTED]> writes:
| On Tue, Dec 17, 2002 at 09:38:47AM +0100, Alfredo Braunstein wrote:
| > It fixes a critical bug (subject of the thread)...
|
| Aehm. Already forgot that...
|
| Ok, so let's have Lars' nod on that.
I only want the _minimal_ fix for this problem now, ev
On Tue, Dec 17, 2002 at 09:38:47AM +0100, Alfredo Braunstein wrote:
> It fixes a critical bug (subject of the thread)...
Aehm. Already forgot that...
Ok, so let's have Lars' nod on that.
Andre'
--
Those who desire to give up Freedom in order to gain Security,
will not have, nor do they deserve
Andre Poenitz wrote:
> On Tue, Dec 17, 2002 at 09:10:29AM +0100, Alfredo Braunstein wrote:
>> > with a default edit() { return UNDISPATCHED; }
>>
>> But edit() is declared as returning void. Should I prepare a patch like
>> my first suggestion (+whitespaces) or will you do it?
>
> Hang on wit
On Tue, Dec 17, 2002 at 09:10:29AM +0100, Alfredo Braunstein wrote:
> > with a default edit() { return UNDISPATCHED; }
>
> But edit() is declared as returning void. Should I prepare a patch like my
> first suggestion (+whitespaces) or will you do it?
Hang on with patches until 1.4.0cvs is ope
Andre Poenitz wrote:
> Something like that. [modulo whitespace ;-)]
>
> This still has the 'right mouse <-> edit' association hard coded, we had
> been thinking about something more flexible lately but there was no
> decision how to do it...>
Ok.
> And this even could be a
>
>case LFU
On Mon, Dec 16, 2002 at 07:27:48PM +0100, Alfredo Braunstein wrote:
> Something like this?
>
> Inset::RESULT InsetButton::localDispatch(FuncRequest const & ev)
> {
> switch (ev.action) {
>
> case LFUN_MOUSE_RELEASE:
> if(editable()) {
> edit
On Mon, Dec 16, 2002 at 08:41:48PM +0100, Alfredo Braunstein wrote:
> > I think whatever it does should be done in the inset's localDispatch(),
> > but the call has been there "since ever"...
>
> Seems that edit() is used like a poor man's localDispatch(), a remaining
> from the past?
Sounds sen
Andre Poenitz wrote:
> I think whatever it does should be done in the inset's localDispatch(),
> but the call has been there "since ever"...
Seems that edit() is used like a poor man's localDispatch(), a remaining
from the past?
Not the right time for this, but I want to get sure I understand: i
Andre Poenitz wrote:
> On Mon, Dec 16, 2002 at 06:17:03PM +, John Levon wrote:
>> On Mon, Dec 16, 2002 at 04:46:02PM +0100, Alfredo Braunstein wrote:
>>
>> > opens simultanously both the reference menu and the float menu.
>>
>> I guess this will fix the release-critical similar bug listed on
On Mon, Dec 16, 2002 at 06:17:03PM +, John Levon wrote:
> On Mon, Dec 16, 2002 at 04:46:02PM +0100, Alfredo Braunstein wrote:
>
> > opens simultanously both the reference menu and the float menu.
>
> I guess this will fix the release-critical similar bug listed on
> bugzilla too. Good stuff.
On Mon, Dec 16, 2002 at 04:46:02PM +0100, Alfredo Braunstein wrote:
> opens simultanously both the reference menu and the float menu.
I guess this will fix the release-critical similar bug listed on
bugzilla too. Good stuff.
> The problem is in InsetText::lfunMouseRelease(...), it checks if an i
opens simultanously both the reference menu and the float menu.
The problem is in InsetText::lfunMouseRelease(...), it checks if an inset
was hit, and then calls localDispatch of that inset with the mouse release
event. On InsetReference (and pretty much on all "button" insets, i.e. all
except
24 matches
Mail list logo
