On Mon, Dec 16, 2002 at 04:46:02PM +0100, Alfredo Braunstein wrote:
> opens simultanously both the reference menu and the float menu.
I guess this will fix the release-critical similar bug listed on
bugzilla too. Good stuff.
> The problem is in InsetText::lfunMouseRelease(...), it checks if an inset
Andre needs to ack this, he was in there last.
> //NEXT LINE IS THE PROBLEM:
> ret = inset->localDispatch(cmd1);
> inset->edit(bv, cmd1.x, cmd1.y, cmd.button());
> }
> updateLocal(bv, CURSOR_PAR, false);
> }
> return ret;
> }
>
> The bug can be easily avoided by replacing the offending line with ret=true;
> but I fail to see the logic here. Shouldn't we overload
> Inset::localDispatch() on, say, InsetButton, making it to catch
> LFUN_MOUSE_RELEASE and call edit() by itself?
A button is not necessarily editable ....
> PD: What's the logic behind changing coordinates of the mouse event for
> different types of insets (if isHiglyEditable() or not)? Shouldn't the
> inset itself take care of that?
There's no real logic in this area at all, it has become a terrible mess
I'm afraid :(
regards
john
--
"ALL television is children's television."
- Richard Adler
