Re: another regression in branch

Am 18.11.2011 03:14, schrieb Richard Heck: I've gone all the way back to LyX 2.0.0, and I still see this. Oops, sorry. It is indeed a regression to LyX 1.6.10: www.lyx.org/trac/ticket/7905 But I found today a real regression to LyX 2.0.1: http://www.lyx.org/trac/ticket/7907 This should be

Re: another regression in branch

On 11/17/2011 08:56 PM, Richard Heck wrote: > On 11/17/2011 08:00 PM, Uwe Stöhr wrote: >> There is a small but nasty regression: insert an index entry via the >> toolbar. >> Result: the cursor is outside of the index entry instead of inside it. >> >> This is quite annoying and perhaps it is easy to

Re: another regression in branch

On 11/17/2011 08:00 PM, Uwe Stöhr wrote: > There is a small but nasty regression: insert an index entry via the > toolbar. > Result: the cursor is outside of the index entry instead of inside it. > > This is quite annoying and perhaps it is easy to fix. > Same from the menus. I'll try bisecting. R

another regression in branch

There is a small but nasty regression: insert an index entry via the toolbar. Result: the cursor is outside of the index entry instead of inside it. This is quite annoying and perhaps it is easy to fix. regards Uwe

Re: Regression in branch

Richard Heck wrote: > Just to check, did you apply both patches? The second of the two only > affects autosave. no only the second one... pavel

Re: Regression in branch

On 11/15/2011 08:24 PM, Pavel Sanda wrote: Richard Heck wrote: So, a different crash, but probably related. It certainly feels like a double delete still. Are there other changes in your source? Line #6 has a different line number from what I'm seeing, at least in trunk, though #4 and #5 are co

Re: Regression in branch

Pavel Sanda wrote: > i will try to find some small example parent->c1->c3 parent->c2->c3 try viewing the attached. pavel f.tgz Description: application/tar-gz

Re: Regression in branch

Richard Heck wrote: > So, a different crash, but probably related. It certainly feels like a > double delete still. > > Are there other changes in your source? Line #6 has a different line > number from what I'm seeing, at least in trunk, though #4 and #5 are > correct. it was trunk patched by yo

Re: Regression in branch

On 11/15/2011 04:13 PM, Pavel Sanda wrote: > Richard Heck wrote: >> On 11/15/2011 12:20 PM, Pavel Sanda wrote: >>> Pavel Sanda wrote: the crash with the original document is gone with this patch. >>> chmm, but trying to build pdf still crashes lyx :( >>> >> I get no crash here with the attache

Re: Regression in branch

Richard Heck wrote: > On 11/15/2011 12:20 PM, Pavel Sanda wrote: > > Pavel Sanda wrote: > >> the crash with the original document is gone with this patch. > > chmm, but trying to build pdf still crashes lyx :( > > > I get no crash here with the attached set, which has the structure you > mentioned.

Re: Regression in branch

On 11/15/2011 12:20 PM, Pavel Sanda wrote: > Pavel Sanda wrote: >> the crash with the original document is gone with this patch. > chmm, but trying to build pdf still crashes lyx :( > I get no crash here with the attached set, which has the structure you mentioned. Same backtrace in your crash? R

Re: Regression in branch

Pavel Sanda wrote: > the crash with the original document is gone with this patch. chmm, but trying to build pdf still crashes lyx :( > pavel

Re: Regression in branch

Richard Heck wrote: > On 11/14/2011 11:27 PM, Vincent van Ravesteijn wrote: > > Do we clone all children when running asynchronous autosave? We shouldnt. > > > > Maybe the guard doesn't function when deleting the cloned buffers. > > > The attached patch tries to address this issue. Seems to work. >

Re: Regression in branch

On 11/14/2011 11:27 PM, Vincent van Ravesteijn wrote: > Do we clone all children when running asynchronous autosave? We shouldnt. > > Maybe the guard doesn't function when deleting the cloned buffers. > The attached patch tries to address this issue. Seems to work. There's also, by the way a memor

Re: Regression in branch

On 11/14/2011 11:27 PM, Vincent van Ravesteijn wrote: > > > Op 15 nov. 2011 03:35 schreef "Richard Heck" > het volgende: > > > > On 11/14/2011 04:36 PM, Pavel Sanda wrote: > >> > >> Richard Heck wrote: > >>> > >>> Something like that may be happening. Pavel, can you prod

Re: Regression in branch

Op 15 nov. 2011 03:35 schreef "Richard Heck" het volgende: > > On 11/14/2011 04:36 PM, Pavel Sanda wrote: >> >> Richard Heck wrote: >>> >>> Something like that may be happening. Pavel, can you produce a minimal set >>> just replicating the structure? >> >> confirming that the cause is r39599. >> >

Re: Regression in branch

On 11/14/2011 04:36 PM, Pavel Sanda wrote: Richard Heck wrote: Something like that may be happening. Pavel, can you produce a minimal set just replicating the structure? confirming that the cause is r39599. the structure causing warning is: parent->child1 parent->child2->child1 Weird. I'll ha

Re: Regression in branch

Richard Heck wrote: > Something like that may be happening. Pavel, can you produce a minimal set > just replicating the structure? confirming that the cause is r39599. the structure causing warning is: parent->child1 parent->child2->child1 see attached. pavel files.tgz Description: applicati

Re: Regression in branch

On 11/14/2011 07:46 AM, Vincent van Ravesteijn wrote: Op 14-11-2011 13:04, Pavel Sanda schreef: Richard Heck wrote: deleting that child's pimpl. Is there something odd about the structure of your document set? yes, it has quite complicated structure, after opening i get Buffer.cpp(286): Warni

Re: Regression in branch

Op 14-11-2011 13:04, Pavel Sanda schreef: Richard Heck wrote: deleting that child's pimpl. Is there something odd about the structure of your document set? yes, it has quite complicated structure, after opening i get Buffer.cpp(286): Warning: a buffer should not have two parents! on console. p

Re: Regression in branch

Richard Heck wrote: > deleting that child's pimpl. Is there something odd about the structure of > your document set? yes, it has quite complicated structure, after opening i get Buffer.cpp(286): Warning: a buffer should not have two parents! on console. pavel

Re: Regression in branch

On 11/13/2011 09:06 PM, Pavel Sanda wrote: Pavel Sanda wrote: Pavel Sanda wrote: will try to come up with backtrace soon. #0 0x03f1 in ?? () #1 0x081298e4 in lyx::Buffer::Impl::~Impl() () #2 0x080f76de in lyx::Buffer::~Buffer() () #3 0x080f71ff in lyx::Buffer::~Buffer() () #4 0x086858

Re: Regression in branch

Pavel Sanda wrote: > Pavel Sanda wrote: > > will try to come up with backtrace soon. > > #0 0x03f1 in ?? () > #1 0x081298e4 in lyx::Buffer::Impl::~Impl() () > #2 0x080f76de in lyx::Buffer::~Buffer() () > #3 0x080f71ff in lyx::Buffer::~Buffer() () > #4 0x0868581a in > lyx::frontend::GuiVi

Re: Regression in branch

Pavel Sanda wrote: > will try to come up with backtrace soon. #0 0x03f1 in ?? () #1 0x081298e4 in lyx::Buffer::Impl::~Impl() () #2 0x080f76de in lyx::Buffer::~Buffer() () #3 0x080f71ff in lyx::Buffer::~Buffer() () #4 0x0868581a in lyx::frontend::GuiView::GuiViewPrivate::autosaveAndDestro

Regression in branch

hi, seems we have new crashing regression in branch. since it happens each few minutes without clear action i guess something is rotten in autosave. will try to come up with backtrace soon. anyone saw this last days/weeks? pavel

Re: another tex2lyx regression in branch

Uwe Stöhr writes: > Hello JMarc, > > the Unicode support for tex2lyx has introduced another regression at it seems: > http://www.lyx.org/trac/ticket/5935 > > Can you please have a look? For information, I am working on it, but the reason is not clear. I narrowed it on the use of the Parser in ta

another tex2lyx regression in branch

Hello JMarc, the Unicode support for tex2lyx has introduced another regression at it seems: http://www.lyx.org/trac/ticket/5935 Can you please have a look? regards Uwe

Re: !LyX 1.6.2 release stopper! major regression in branch

Jürgen Spitzmüller wrote: > > Jürgen, you still don't reply my private emails. I've sent you this email > > CC to your spitzmueller.org address, can you please have a look if it > > reached you. > > No, it didn't. Solved now. My bad. Apologies to everyone who attempted to reach me and wondered wh

Re: !LyX 1.6.2 release stopper! major regression in branch

Uwe Stöhr wrote: > Jürgen, you still don't reply my private emails. I've sent you this email > CC to your spitzmueller.org address, can you please have a look if it > reached you. No, it didn't. Jürgen

Re: !LyX 1.6.2 release stopper! major regression in branch

> I think we will just delay the release for some days until all issues with the > fix are sorted out. We can still revert if it turns out to be necessary. ATM I > do not see the need to do this. OK, but then Vincent's http://www.lyx.org/trac/changeset/28633 should then also go to branch to be a

Re: !LyX 1.6.2 release stopper! major regression in branch

Jürgen Spitzmüller wrote: Uwe Stöhr wrote: It is already fixed, in trunk at least. See the other mails sent this night... I see them now and agree with Pavel that it is perhaps better to postpone this fix to LyX 1.6.3 because it is the second time something went wrong. Not that you w

Re: !LyX 1.6.2 release stopper! major regression in branch

Uwe Stöhr wrote: > > It is already fixed, in trunk at least. > > > > See the other mails sent this night... > > I see them now and agree with Pavel that it is perhaps better to postpone > this fix to LyX 1.6.3 because it is the second time something went wrong. > Not that you wrote bad code, but it

RE: !LyX 1.6.2 release stopper! major regression in branch

>I see them now and agree with Pavel that it is perhaps better to >postpone this fix to LyX 1.6.3 because it is the second time >something went wrong. It is not that bad, it is the same error.. When committing the first fix I totally forgot to check for virtual and overloaded functions, I just

Re: !LyX 1.6.2 release stopper! major regression in branch

Vincent van Ravesteijn schrieb: It is already fixed, in trunk at least. See the other mails sent this night... I see them now and agree with Pavel that it is perhaps better to postpone this fix to LyX 1.6.3 because it is the second time something went wrong. Not that you wrote bad code, but

Re: !LyX 1.6.2 release stopper! major regression in branch

Uwe Stöhr schreef: Since today it is no longer possible to open the table settings for tables in table floats (e.g. to set the border settings to formal style). The bug is that the context menu does not appear when right clicking inside floats. The same applies for images in graphics floats.

!LyX 1.6.2 release stopper! major regression in branch

Since today it is no longer possible to open the table settings for tables in table floats (e.g. to set the border settings to formal style). The bug is that the context menu does not appear when right clicking inside floats. The same applies for images in graphics floats. regards Uwe

Re: Regression in branch

Vincent van Ravesteijn wrote: > Also for branch ? Yes, this looks good. Jürgen

Re: Regression in branch

Ah, that's not good. I forgot to update all other setButtonLabel() calls indeed (as it obviously didn't generate compiler errors). Fixing this would be straightforward <=> someone didn't decide to call gui-functions from within the read function... But, I'll fix it nevertheless. I'm p

RE: Re: Regression in branch

>> ert no more displays the text inside when collapsed. This >>must have changed in last few days. i dont have time to >>inspect more atm. > >I think the cause is the fix to bug 4346. Now, InsetERT and >others have setButtonLabel(BufferView const & bv), but >InsetCollapsable still calls setButtonLa

Re: Regression in branch

Pavel Sanda wrote: > ert no more displays the text inside when collapsed. this must have > changed in last few days. i dont have time to inspect more atm. I think the cause is the fix to bug 4346. Now, InsetERT and others have setButtonLabel(BufferView const & bv), but InsetCollapsable still call

Regression in branch

hi, ert no more displays the text inside when collapsed. this must have changed in last few days. i dont have time to inspect more atm. pavel

Re: [patch] fix regression in branch

> Even better, I've now made the command itself robust. Please test: > http://www.lyx.org/trac/changeset/28236 Works as it should. Thanks. regards Uwe

Re: [patch] fix regression in branch

Jürgen Spitzmüller wrote: > > I'd rather like to know what's happening. I really prefer one over two > > separate commands. I cannot imagine that hyperref has problems with such > > a basic command as \...@ifstar. > > lyxarrow is fragile. The attached patch fixes the problem. Even better, I've now

Re: [patch] fix regression in branch

Jürgen Spitzmüller wrote: > I'd rather like to know what's happening. I really prefer one over two > separate commands. I cannot imagine that hyperref has problems with such a > basic command as \...@ifstar. lyxarrow is fragile. The attached patch fixes the problem. Jürgen Index: src/insets/Inset

Re: [patch] fix regression in branch

Uwe Stöhr wrote: > The bugfix for http://bugzilla.lyx.org/show_bug.cgi?id=3560 introduces a > regression. \...@ifstar is not fully compatible with hyperref. When you use a > menu separator in a section heading, like in the German UserGuide and > create PDF bookmarks, the document becomes uncompilab

Re: [patch] fix regression in branch

Uwe Stöhr schrieb: The attached patch fixes this. Now it is attached. regards Uwe Index: insets/InsetSpecialChar.cpp === --- insets/InsetSpecialChar.cpp (revision 28224) +++ insets/InsetSpecialChar.cpp (working copy) @@ -222,7 +2

[patch] fix regression in branch

The bugfix for http://bugzilla.lyx.org/show_bug.cgi?id=3560 introduces a regression. \...@ifstar is not fully compatible with hyperref. When you use a menu separator in a section heading, like in the German UserGuide and create PDF bookmarks, the document becomes uncompilable. The attached patc