Re: r38025 - lyx-devel/trunk/src/insets

2011-04-03 Thread Jürgen Spitzmüller
Julien Rioux wrote: > It turns out that isLatex returns true for lilypond document, which made > this test wrong and unreliable. Also, setting isLiterate to true for > lilypond causes other problems. > > The real test here is whether we have created the file we want created, > so I have done th

Re: r38025 - lyx-devel/trunk/src/insets

2011-03-29 Thread Julien Rioux
On 28/03/2011 12:17 PM, Jürgen Spitzmüller wrote: Jean-Marc Lasgouttes wrote: I have not followed the discussion well enough, but somehow I do not like to hard-code the format name in there. Unfortunately I do not have time to look at it seriously, just to send annoying emails. Julien, am I ri

Re: r38025 - lyx-devel/trunk/src/insets

2011-03-28 Thread Jean-Marc Lasgouttes
Le 28/03/11 19:14, Jürgen Spitzmüller a écrit : Jean-Marc Lasgouttes wrote: It might be a good occasion to redefine what isLiterate means (and whether we still need it) and maybe create new such methods (instead of doing a direct test). ... and leave this to you who are in the know about liter

Re: r38025 - lyx-devel/trunk/src/insets

2011-03-28 Thread Jürgen Spitzmüller
Julien Rioux wrote: > > Your patch looks good. The broader scope is desired I think. I don't > > expect isLiterate() to be correct in all cases given that users could > > define their own backends through modules. isLatex should cover most > > cases (until a new flavor of latex comes about). OK, I

Re: r38025 - lyx-devel/trunk/src/insets

2011-03-28 Thread Jean-Marc Lasgouttes
Le 28/03/11 19:00, Julien Rioux a écrit : Your patch looks good. The broader scope is desired I think. I don't expect isLiterate() to be correct in all cases given that users could define their own backends through modules. isLatex should cover most cases (until a new flavor of latex comes about)

Re: r38025 - lyx-devel/trunk/src/insets

2011-03-28 Thread Julien Rioux
On 28/03/2011 12:17 PM, Jürgen Spitzmüller wrote: Jean-Marc Lasgouttes wrote: I have not followed the discussion well enough, but somehow I do not like to hard-code the format name in there. Unfortunately I do not have time to look at it seriously, just to send annoying emails. Julien, am I ri

Re: r38025 - lyx-devel/trunk/src/insets

2011-03-28 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > I have not followed the discussion well enough, but somehow I do not > like to hard-code the format name in there. Unfortunately I do not have > time to look at it seriously, just to send annoying emails. Julien, am I right that we need this conversion only if the c

Re: r38025 - lyx-devel/trunk/src/insets

2011-03-26 Thread Jean-Marc Lasgouttes
Le 26/03/11 15:56, Julien Rioux a écrit : On 26/03/2011 5:53 AM, Jürgen Spitzmüller wrote: Julien Rioux wrote: Perhaps we can just check on the file extension formats.extension(inc_format). Call the converter only when it is not ".tex" Like this? I came up with this but was waiting for tr

Re: r38025 - lyx-devel/trunk/src/insets

2011-03-26 Thread Jürgen Spitzmüller
Julien Rioux wrote: > I came up with this but was waiting for trunk to reopen. Fine as well, but to me, it looks more transparent to special case the whole conversion attempt (it's clearer what we want to do). Jürgen

Re: r38025 - lyx-devel/trunk/src/insets

2011-03-26 Thread Julien Rioux
On 26/03/2011 5:53 AM, Jürgen Spitzmüller wrote: Julien Rioux wrote: Perhaps we can just check on the file extension formats.extension(inc_format). Call the converter only when it is not ".tex" Like this? Jürgen I came up with this but was waiting for trunk to reopen. -- Julien Index: src

Re: r38025 - lyx-devel/trunk/src/insets

2011-03-26 Thread Jürgen Spitzmüller
Julien Rioux wrote: > Perhaps we can just check on the file extension > formats.extension(inc_format). > > Call the converter only when it is not ".tex" Like this? Jürgen Index: src/insets/InsetInclude.cpp === --- src/insets/InsetI

Re: r38025 - lyx-devel/trunk/src/insets

2011-03-25 Thread Jürgen Spitzmüller
Julien Rioux wrote: > Perhaps we can just check on the file extension > formats.extension(inc_format). > > Call the converter only when it is not ".tex" OK. If this suits your (i.e., literate's) needs. Go for it. Jürgen

Re: r38025 - lyx-devel/trunk/src/insets

2011-03-25 Thread Julien Rioux
On 25/03/2011 10:09 AM, Jürgen Spitzmüller wrote: Julien Rioux wrote: Thanks. But actually won't we need to special case all three of: pdflatex, lualatex, xelatex? Yes, bufferFormat() actually does not return the adequate information. The attached patch will do (although I do not like this sp

Re: r38025 - lyx-devel/trunk/src/insets

2011-03-25 Thread Jürgen Spitzmüller
Julien Rioux wrote: > Thanks. But actually won't we need to special case all three of: > pdflatex, lualatex, xelatex? Yes, bufferFormat() actually does not return the adequate information. The attached patch will do (although I do not like this special casing). Jürgen Index: src/insets/InsetIn

Re: r38025 - lyx-devel/trunk/src/insets

2011-03-25 Thread Julien Rioux
On 25/03/2011 6:10 AM, Jürgen Spitzmüller wrote: Jürgen Spitzmüller wrote: As of this change, I am bombarded by warnings "Included file xxx was not exported correctly. Warning: LaTeX export is probably incomplete." when viewing/updating a master file with children. After I have clicked away all

Re: r38025 - lyx-devel/trunk/src/insets

2011-03-25 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > As of this change, I am bombarded by warnings "Included file xxx was not > exported correctly. Warning: LaTeX export is probably incomplete." when > viewing/updating a master file with children. After I have clicked away > all the warnings, the view is successful. >

Re: r38025 - lyx-devel/trunk/src/insets

2011-03-25 Thread Jürgen Spitzmüller
jrioux wrote: > Author: jrioux > Date: Thu Mar 24 16:47:40 2011 > New Revision: 38025 > URL: http://www.lyx.org/trac/changeset/38025 > > Log: > handle 'literate' lyx child documents (lilypond and sweave) >- don't assume that the exported file extension is .tex >- use converter tool chain t