RE: r33329 - in lyx-devel/trunk/src: . mathed

2010-02-05 Thread Vincent van Ravesteijn - TNW
>>> + const char *font_name; >>> + switch (type_) { >>> + return from_ascii(font_name); >>> } >>> >> >> Please use "docstring font_name;" and "font_name = from_ascii(..);" >> >What do we gain ? Isn't it only more overhead ? We create another >docstring instance which then needs to be

Re: r33329 - in lyx-devel/trunk/src: . mathed

2010-02-05 Thread Tommaso Cucinotta
Vincent van Ravesteijn - TNW wrote: Author: tommaso Date: Fri Feb 5 10:00:40 2010 New Revision: 33329 URL: http://www.lyx.org/trac/changeset/33329 docstring InsetMathHull::standardFont() const { - return from_ascii(type_ == hullNone ? "lyxnochange" : "mathnormal"); + cons

RE: r33329 - in lyx-devel/trunk/src: . mathed

2010-02-05 Thread Vincent van Ravesteijn - TNW
>Author: tommaso >Date: Fri Feb 5 10:00:40 2010 >New Revision: 33329 >URL: http://www.lyx.org/trac/changeset/33329 > > docstring InsetMathHull::standardFont() const { >- return from_ascii(type_ == hullNone ? "lyxnochange" : "mathnormal"); >+ const char *font_name; >+ switch (type_)