Vincent van Ravesteijn - TNW wrote:
Author: tommaso
Date: Fri Feb  5 10:00:40 2010
New Revision: 33329
URL: http://www.lyx.org/trac/changeset/33329

docstring InsetMathHull::standardFont() const  {
-       return from_ascii(type_ == hullNone ? "lyxnochange" :
"mathnormal");
+       const char *font_name;
+       switch (type_) {
+       return from_ascii(font_name);
}

Please use "docstring font_name;" and "font_name = from_ascii(..);"
What do we gain ? Isn't it only more overhead ? We create another docstring instance which then needs to be copied.

   T.

Reply via email to