>> Do not use /// but // and just // FIXME. Why the \TODO ?
>
>Because I was assuming that the code documentation is for developers,
>and if I put a "///" and a "@todo", then in the "Todo List page"
>generated by Doxygen I get this item included. Now that you make me
>think of this, I see I pi
forgot to deal with cursor: is it possible to move dispatching to the
cursor inside BufferView::dispatch() ?
T.
Tommaso Cucinotta ha scritto:
Vincent van Ravesteijn ha scritto:
Tommaso Cucinotta schreef:
+case LFUN_BUFFER_CHKTEX: // TODO: test if doc_buffer here
+LASSE
Vincent van Ravesteijn ha scritto:
Tommaso Cucinotta schreef:
+case LFUN_BUFFER_CHKTEX: // TODO: test if doc_buffer here
+LASSERT(doc_buffer, /**/);
+doc_buffer->runChktex();
break;
What do you mean with the TODO.. doc_buffer is OK here if that's wh
Tommaso Cucinotta schreef:
Tommaso Cucinotta ha scritto:
Abdelrazak Younes ha scritto:
Yes they help, and I hope they will help you in fixing all these
cases. I only had a quick look at them but your analysis seems correct.
Ok, I'll try to produce a patch, make some tests and send it to the
li
Tommaso Cucinotta ha scritto:
Abdelrazak Younes ha scritto:
Yes they help, and I hope they will help you in fixing all these
cases. I only had a quick look at them but your analysis seems correct.
Ok, I'll try to produce a patch, make some tests and send it to the list.
Please, find it attached
On Wed, Sep 09, 2009 at 01:35:09AM +0200, Tommaso Cucinotta wrote:
> Vincent van Ravesteijn ha scritto:
>> I did expect. Actually I listed a long list of LFUNS in LyXFunc which
>> should work on the document buffer long ago. After this, only the
>> calls to view() have been altered and Abdel di
Vincent van Ravesteijn wrote:
Tommaso Cucinotta schreef:
... continuing ...
In LyXFunc::dispatch():
L950:
case LFUN_BUILD_PROGRAM:
LASSERT(lyx_view_ && buffer, /**/);
buffer->doExport("program", true);
break;
case LFUN_BUFFER_CHKTEX:
L
Vincent van Ravesteijn wrote:
Pavel Sanda schreef:
Vincent van Ravesteijn wrote:
Or, I am missing something, or we can move masses of these LFUNS.
this was long time plan but nobody went for this mass movement of
lfuns into the correct dispatch hierarchy level...
Well, you say that b
Tommaso Cucinotta schreef:
Abdelrazak Younes ha scritto:
LyXView::buffer() and GuiView::buffer() is no more in trunk. So the
first thing to do is to review all currentBufferView() and
documentBufferView() calls and replace one by the other when it makes
sense.
I've one too, the default buff
Vincent van Ravesteijn ha scritto:
I did expect. Actually I listed a long list of LFUNS in LyXFunc which
should work on the document buffer long ago. After this, only the
calls to view() have been altered and Abdel didn't look at any of the
buffers (I think).
I saved that list.
I think we shou
Pavel Sanda schreef:
Vincent van Ravesteijn wrote:
Or, I am missing something, or we can move masses of these LFUNS.
this was long time plan but nobody went for this mass movement of
lfuns into the correct dispatch hierarchy level... this would need
some time to get right and i suppose
Vincent van Ravesteijn wrote:
> Or, I am missing something, or we can move masses of these LFUNS.
this was long time plan but nobody went for this mass movement of
lfuns into the correct dispatch hierarchy level... this would need
some time to get right and i suppose many things will break down :)
Tommaso Cucinotta schreef:
... continuing ...
In LyXFunc::dispatch():
L950:
case LFUN_BUILD_PROGRAM:
LASSERT(lyx_view_ && buffer, /**/);
buffer->doExport("program", true);
break;
case LFUN_BUFFER_CHKTEX:
LASSERT(lyx_view_ && buffer, /**
Abdelrazak Younes ha scritto:
On 08/09/2009 21:00, Tommaso Cucinotta wrote:
Hope these comments help (apologies for the length, it was not
expected).
Yes they help, and I hope they will help you in fixing all these
cases. I only had a quick look at them but your analysis seems correct.
Ok, I
On 08/09/2009 20:28, Tommaso Cucinotta wrote:
Abdelrazak Younes ha scritto:
LyXView::buffer() and GuiView::buffer() is no more in trunk. So the
first thing to do is to review all currentBufferView() and
documentBufferView() calls and replace one by the other when it makes
sense.
why checkin
On 08/09/2009 21:00, Tommaso Cucinotta wrote:
Hope these comments help (apologies for the length, it was not expected).
Yes they help, and I hope they will help you in fixing all these cases.
I only had a quick look at them but your analysis seems correct.
Abdel.
... continuing ...
In LyXFunc::dispatch():
L950:
case LFUN_BUILD_PROGRAM:
LASSERT(lyx_view_ && buffer, /**/);
buffer->doExport("program", true);
break;
case LFUN_BUFFER_CHKTEX:
LASSERT(lyx_view_ && buffer, /**/);
buffer->runCh
Abdelrazak Younes ha scritto:
LyXView::buffer() and GuiView::buffer() is no more in trunk. So the
first thing to do is to review all currentBufferView() and
documentBufferView() calls and replace one by the other when it makes
sense.
In LyXFunc::dispatch():
... L825:
} else {
Buff
Vincent van Ravesteijn - TNW wrote:
I think the idea is to remove all calls to buffer() and get to the
buffer through either currentBufferView()->buffer() or
documentBufferView()->buffer(). Outside the GUI we will probably
rename all buffer() calls to documentBuffer() and currentBuffer().
>> I think the idea is to remove all calls to buffer() and get to the
>> buffer through either currentBufferView()->buffer() or
>> documentBufferView()->buffer(). Outside the GUI we will probably
>> rename all buffer() calls to documentBuffer() and currentBuffer().
>
>sorry i may be just skipp
Vincent van Ravesteijn - TNW wrote:
> >Tommaso, i just checked this breaks more things than
> >just version control. even normal save functions are
> >affected and are touching wrong buffers. please take
> >the API of buffer() being only main edited document
> >back either by reverting the patch or
>> has been this fixed meanwhile?
>
>ping!
Reply with message->size()*sizeof(char) bytes of data:
>Tommaso, i just checked this breaks more things than
>just version control. even normal save functions are
>affected and are touching wrong buffers. please take
>the API of buffer() being only main
Pavel Sanda wrote:
> Vincent van Ravesteijn wrote:
> > tomm...@lyx.org schreef:
> >> Author: tommaso
> >> Date: Sat Aug 22 18:16:56 2009
> >> New Revision: 31203
> >> URL: http://www.lyx.org/trac/changeset/31203
> >>
> >> Log:
> >> Added at the LyXView level distinction among currently selected Wor
Vincent van Ravesteijn wrote:
> tomm...@lyx.org schreef:
>> Author: tommaso
>> Date: Sat Aug 22 18:16:56 2009
>> New Revision: 31203
>> URL: http://www.lyx.org/trac/changeset/31203
>>
>> Log:
>> Added at the LyXView level distinction among currently selected WorkArea
>> (and BufferView) and docume
tomm...@lyx.org schreef:
Author: tommaso
Date: Sat Aug 22 18:16:56 2009
New Revision: 31203
URL: http://www.lyx.org/trac/changeset/31203
Log:
Added at the LyXView level distinction among currently selected WorkArea (and
BufferView) and document WorkArea (and BufferView).
Fixes crash when openin
25 matches
Mail list logo
