Pavel Sanda wrote: > Vincent van Ravesteijn wrote: > > tomm...@lyx.org schreef: > >> Author: tommaso > >> Date: Sat Aug 22 18:16:56 2009 > >> New Revision: 31203 > >> URL: http://www.lyx.org/trac/changeset/31203 > >> > >> Log: > >> Added at the LyXView level distinction among currently selected WorkArea > >> (and BufferView) and document WorkArea (and BufferView). > >> Fixes crash when opening both Toc Panel and Advanced Find and Replace > >> Panel. > >> Fixes preview of document (as opposed of previewing the search/replace > >> text) while search/replace WorkArea selected. > >> > >> Modified: > >> lyx-devel/trunk/src/LyXFunc.cpp > >> lyx-devel/trunk/src/frontends/LyXView.h > >> lyx-devel/trunk/src/frontends/qt4/GuiView.cpp > >> lyx-devel/trunk/src/frontends/qt4/GuiView.h > >> > >> Modified: lyx-devel/trunk/src/LyXFunc.cpp > >> ============================================================================== > >> --- lyx-devel/trunk/src/LyXFunc.cpp Sat Aug 22 18:09:44 2009 > >> (r31202) > >> +++ lyx-devel/trunk/src/LyXFunc.cpp Sat Aug 22 18:16:56 2009 > >> (r31203) > >> @@ -900,38 +900,42 @@ > >> } > >> case LFUN_BUFFER_UPDATE: { > >> - LASSERT(lyx_view_ && buffer, /**/); > >> + LASSERT(lyx_view_ && lyx_view_->documentBuffer(), /**/); > >> + Buffer * doc_buffer = lyx_view_->documentBuffer(); > > > Didn't we discuss this ? I can't remember we were all very happy to see > > this to get in. > > has been this fixed meanwhile?
ping! Tommaso, i just checked this breaks more things than just version control. even normal save functions are affected and are touching wrong buffers. please take the API of buffer() being only main edited document back either by reverting the patch or refactorising the current code. > pavel
