Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-31 Thread Enrico Forestieri
On Fri, Oct 31, 2008 at 06:18:38PM +0100, Abdelrazak Younes wrote: > On 31/10/2008 18:14, Pavel Sanda wrote: > > Enrico Forestieri wrote: > > > >> On Fri, Oct 31, 2008 at 02:46:07PM +, José Matos wrote: > >> > >>> On Friday 31 October 2008 12:44:12 Enrico Forestieri wrote: > >>>

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-31 Thread Abdelrazak Younes
On 31/10/2008 18:14, Pavel Sanda wrote: Enrico Forestieri wrote: On Fri, Oct 31, 2008 at 02:46:07PM +, José Matos wrote: On Friday 31 October 2008 12:44:12 Enrico Forestieri wrote: I figured it out. With the attached patch it is impossible to create bad math insets like t

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-31 Thread Pavel Sanda
Enrico Forestieri wrote: > On Fri, Oct 31, 2008 at 02:46:07PM +, José Matos wrote: > > On Friday 31 October 2008 12:44:12 Enrico Forestieri wrote: > > > > > > I figured it out. With the attached patch it is impossible to create > > > bad math insets like the above. > > > > > > I think I need a

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-31 Thread Enrico Forestieri
On Fri, Oct 31, 2008 at 02:46:07PM +, José Matos wrote: > On Friday 31 October 2008 12:44:12 Enrico Forestieri wrote: > > > > I figured it out. With the attached patch it is impossible to create > > bad math insets like the above. > > > > I think I need a nod before applying it, though. > > If

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-31 Thread José Matos
On Friday 31 October 2008 12:44:12 Enrico Forestieri wrote: > > I figured it out. With the attached patch it is impossible to create > bad math insets like the above. > > I think I need a nod before applying it, though. If you are confident on the code you can proceed. -- José Abílio

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-31 Thread Enrico Forestieri
On Wed, Oct 29, 2008 at 08:33:09PM +0100, Abdelrazak Younes wrote: > On 29/10/2008 20:15, Enrico Forestieri wrote: > > The attached patch makes it impossible to create certain bad math insets. > > For example, when selecting $\[x\]$ and then hitting Ctrl+M, LyX will > > complain that that is a bad

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Abdelrazak Younes
On 29/10/2008 20:15, Enrico Forestieri wrote: On Wed, Oct 29, 2008 at 04:40:13PM +0100, Enrico Forestieri wrote: On Wed, Oct 29, 2008 at 04:30:41PM +0100, Abdelrazak Younes wrote: So my initial assumption that it is wrong to allow InsetMathHull inside InsetMathHull was right?

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Enrico Forestieri
On Wed, Oct 29, 2008 at 04:40:13PM +0100, Enrico Forestieri wrote: > On Wed, Oct 29, 2008 at 04:30:41PM +0100, Abdelrazak Younes wrote: > > So my initial assumption that it is wrong to allow InsetMathHull inside > > InsetMathHull was right? > > Yep. I was too quick here (no time to think), see b

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Abdelrazak Younes
On 29/10/2008 16:11, Abdelrazak Younes wrote: On 29/10/2008 16:05, Pavel Sanda wrote: Abdelrazak Younes wrote: By the way, it seems that copy in Firefox and paste into LyX doesn't work! here it works. Here only internal C&Paste, external copy from any app gives a 'Command is disabled'...

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Enrico Forestieri
On Wed, Oct 29, 2008 at 04:30:41PM +0100, Abdelrazak Younes wrote: > So my initial assumption that it is wrong to allow InsetMathHull inside > InsetMathHull was right? Yep. > FWIW, the same bug plagues LyX-1.5. I'll try to have a look later tonight, if nobody beats me to it. -- Enrico

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Abdelrazak Younes
On 29/10/2008 16:14, Enrico Forestieri wrote: On Wed, Oct 29, 2008 at 04:02:53PM +0100, Abdelrazak Younes wrote: On 29/10/2008 15:52, Enrico Forestieri wrote: On Wed, Oct 29, 2008 at 10:56:17AM +0100, Abdelrazak Younes wrote: Hum, this commit fixes the right and left movemen

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Enrico Forestieri
On Wed, Oct 29, 2008 at 04:21:35PM +0100, Abdelrazak Younes wrote: > On 29/10/2008 16:15, Stefan Schimanski wrote: > > > > Am 29.10.2008 um 16:08 schrieb Abdelrazak Younes: > > > >> On 29/10/2008 15:58, Stefan Schimanski wrote: > >>> >> I noticed that we call those notifies handler twice if you cli

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Pavel Sanda
Abdelrazak Younes wrote: > To get the patch set, say of three last commits: > > | git-format-patch -3 --stdout i'm afraid svn won't take it. if i remember from my exchange with Uwe svn doesn't accept normal patch but needs special headers given by svn itself. > I can't apply with svn because the

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Enrico Forestieri
On Wed, Oct 29, 2008 at 04:02:53PM +0100, Abdelrazak Younes wrote: > On 29/10/2008 15:52, Enrico Forestieri wrote: > > On Wed, Oct 29, 2008 at 10:56:17AM +0100, Abdelrazak Younes wrote: > > > >> Hum, this commit fixes the right and left movement but not the up and > >> down... > >> > >> André,

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Abdelrazak Younes
On 29/10/2008 16:15, Stefan Schimanski wrote: Am 29.10.2008 um 16:08 schrieb Abdelrazak Younes: On 29/10/2008 15:58, Stefan Schimanski wrote: >> I noticed that we call those notifies handler twice if you click >> with the mouse into some math. I will investigate that, but it >> should not mat

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Stefan Schimanski
Am 29.10.2008 um 16:08 schrieb Abdelrazak Younes: On 29/10/2008 15:58, Stefan Schimanski wrote: >> I noticed that we call those notifies handler twice if you click >> with the mouse into some math. I will investigate that, but it >> should not matter for your problem. > > Could you send a svn

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Abdelrazak Younes
On 29/10/2008 16:05, Pavel Sanda wrote: Abdelrazak Younes wrote: By the way, it seems that copy in Firefox and paste into LyX doesn't work! here it works. Here only internal C&Paste, external copy from any app gives a 'Command is disabled'... Abdel.

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Abdelrazak Younes
On 29/10/2008 15:58, Stefan Schimanski wrote: >> I noticed that we call those notifies handler twice if you click >> with the mouse into some math. I will investigate that, but it >> should not matter for your problem. > > Could you send a svn patch please? I don't use svn, but git with git-svn

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Pavel Sanda
Abdelrazak Younes wrote: > By the way, it seems that copy in Firefox and paste into LyX doesn't work! here it works. pavel

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Abdelrazak Younes
On 29/10/2008 15:52, Enrico Forestieri wrote: On Wed, Oct 29, 2008 at 10:56:17AM +0100, Abdelrazak Younes wrote: Hum, this commit fixes the right and left movement but not the up and down... André, Stefan, Enrico, could you please comment on the possibility to have InsetMathHull inside Ins

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Enrico Forestieri
On Wed, Oct 29, 2008 at 10:56:17AM +0100, Abdelrazak Younes wrote: > Hum, this commit fixes the right and left movement but not the up and > down... > > André, Stefan, Enrico, could you please comment on the possibility to > have InsetMathHull inside InsetMathHull? I can imagine that it is usef

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Stefan Schimanski
I noticed that we call those notifies handler twice if you click with the mouse into some math. I will investigate that, but it should not matter for your problem. Could you send a svn patch please? I don't use svn, but git with git-svn. If you tell me how to create a "svn patch"... Her

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Abdelrazak Younes
On 29/10/2008 15:29, Stefan Schimanski wrote: Am 29.10.2008 um 14:52 schrieb Abdelrazak Younes: On 29/10/2008 14:50, Stefan Schimanski wrote: Am 29.10.2008 um 10:56 schrieb Abdelrazak Younes: Hum, this commit fixes the right and left movement but not the up and down... Putting leavePreview

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Stefan Schimanski
Am 29.10.2008 um 14:52 schrieb Abdelrazak Younes: On 29/10/2008 14:50, Stefan Schimanski wrote: Am 29.10.2008 um 10:56 schrieb Abdelrazak Younes: Hum, this commit fixes the right and left movement but not the up and down... Putting leavePreview into idxFirst/idxLast looks wrong. See below.

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Stefan Schimanski
Am 29.10.2008 um 14:52 schrieb Abdelrazak Younes: On 29/10/2008 14:50, Stefan Schimanski wrote: Am 29.10.2008 um 10:56 schrieb Abdelrazak Younes: Hum, this commit fixes the right and left movement but not the up and down... Putting leavePreview into idxFirst/idxLast looks wrong. See below.

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Stefan Schimanski
Am 29.10.2008 um 10:56 schrieb Abdelrazak Younes: Hum, this commit fixes the right and left movement but not the up and down... Putting leavePreview into idxFirst/idxLast looks wrong. See below. André, Stefan, Enrico, could you please comment on the possibility to have InsetMathHull inside

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Abdelrazak Younes
On 29/10/2008 14:50, Stefan Schimanski wrote: Am 29.10.2008 um 10:56 schrieb Abdelrazak Younes: Hum, this commit fixes the right and left movement but not the up and down... Putting leavePreview into idxFirst/idxLast looks wrong. See below. André, Stefan, Enrico, could you please comment on t

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Abdelrazak Younes
On 29/10/2008 10:56, Abdelrazak Younes wrote: Hum, this commit fixes the right and left movement but not the up and down... André, Stefan, Enrico, could you please comment on the possibility to have InsetMathHull inside InsetMathHull? I can imagine that it is useful for XYmatrix purpose so th

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Abdelrazak Younes
On 29/10/2008 10:56, Abdelrazak Younes wrote: Hum, this commit fixes the right and left movement but not the up and down... André, Stefan, Enrico, could you please comment on the possibility to have InsetMathHull inside InsetMathHull? I can imagine that it is useful for XYmatrix purpose so th

Re: r27186 - in /lyx-devel/trunk/src/mathed: InsetMathHull.cp...

2008-10-29 Thread Abdelrazak Younes
Hum, this commit fixes the right and left movement but not the up and down... André, Stefan, Enrico, could you please comment on the possibility to have InsetMathHull inside InsetMathHull? I can imagine that it is useful for XYmatrix purpose so that you don't have the full raw equation when y