Re: Weird Language Bug

2009-10-19 Thread Enrico Forestieri
On Mon, Oct 19, 2009 at 09:46:00AM +0200, Jürgen Spitzmüller wrote: > Enrico Forestieri wrote: > > I have committed the patch in trunk with this change. > > After some testing, this can go to branch as well. I have committed a patch correcting a thinko which was affecting childs inside childs. I

Re: Weird Language Bug

2009-10-19 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: > I have committed the patch in trunk with this change. After some testing, this can go to branch as well. Jürgen

Re: Weird Language Bug

2009-10-18 Thread Enrico Forestieri
On Sun, Oct 18, 2009 at 07:56:12PM +0200, Enrico Forestieri wrote: > On Sun, Oct 18, 2009 at 01:42:30PM -0400, rgheck wrote: > > > On 10/18/2009 01:04 PM, Jürgen Spitzmüller wrote: > > > rgheck wrote: > > > > > >> I like this approach. It's clean, an the master_language param may be > > >> us

Re: Weird Language Bug

2009-10-18 Thread Enrico Forestieri
On Sun, Oct 18, 2009 at 01:42:30PM -0400, rgheck wrote: > On 10/18/2009 01:04 PM, Jürgen Spitzmüller wrote: > > rgheck wrote: > > > >> I like this approach. It's clean, an the master_language param may be > >> useful for something else. > >> > > +1. > > > > > That said, do we actuall

Re: Weird Language Bug

2009-10-18 Thread rgheck
On 10/18/2009 01:04 PM, Jürgen Spitzmüller wrote: rgheck wrote: I like this approach. It's clean, an the master_language param may be useful for something else. +1. That said, do we actually need the param? Or can we just get this from Buffer::masterBuffer()->params().language()

Re: Weird Language Bug

2009-10-18 Thread Jürgen Spitzmüller
rgheck wrote: > I like this approach. It's clean, an the master_language param may be > useful for something else. +1. Jürgen

Re: Weird Language Bug

2009-10-18 Thread rgheck
On 10/18/2009 11:45 AM, Enrico Forestieri wrote: On Sun, Oct 18, 2009 at 11:37:42AM +0200, Jürgen Spitzmüller wrote: Enrico Forestieri wrote: The attached patch fixes the bug for me, but I have no idea if it is correct in a CJK environment. It looks correct, but of course so

Re: Weird Language Bug

2009-10-18 Thread Enrico Forestieri
On Sun, Oct 18, 2009 at 11:37:42AM +0200, Jürgen Spitzmüller wrote: > Enrico Forestieri wrote: > > The attached patch fixes the bug for me, but I have no idea if it is > > correct in a CJK environment. > > It looks correct, but of course some testing will not harm. We know how > sensitive this a

Re: Weird Language Bug

2009-10-18 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: > The attached patch fixes the bug for me, but I have no idea if it is > correct in a CJK environment. It looks correct, but of course some testing will not harm. We know how sensitive this area is. Jürgen

Re: Weird Language Bug

2009-10-17 Thread Enrico Forestieri
On Fri, Oct 16, 2009 at 11:45:53AM -0400, rgheck wrote: > On 10/16/2009 10:43 AM, J�rgen Spitzm�ller wrote: > > rgheck wrote: > > > >> The attached files illustrate the bug. We have an English document that > >> includes a file marked for Spanish and one marked for English. The > >> English do

Re: Weird Language Bug

2009-10-16 Thread Jürgen Spitzmüller
rgheck wrote: > That's not what I see. Sorry, I did not look close enough. I was rather guessing. Jürgen

Re: Weird Language Bug

2009-10-16 Thread rgheck
On 10/16/2009 10:43 AM, Jürgen Spitzmüller wrote: rgheck wrote: The attached files illustrate the bug. We have an English document that includes a file marked for Spanish and one marked for English. The English document ends up also being in Spanish, as the appearance of the word "Figura" sh

Re: Weird Language Bug

2009-10-16 Thread Jürgen Spitzmüller
rgheck wrote: > The attached files illustrate the bug. We have an English document that > includes a file marked for Spanish and one marked for English. The > English document ends up also being in Spanish, as the appearance of the > word "Figura" shows. There's some bug here then about language