On Sun, Oct 18, 2009 at 07:56:12PM +0200, Enrico Forestieri wrote: > On Sun, Oct 18, 2009 at 01:42:30PM -0400, rgheck wrote: > > > On 10/18/2009 01:04 PM, Jürgen Spitzmüller wrote: > > > rgheck wrote: > > > > > >> I like this approach. It's clean, an the master_language param may be > > >> useful for something else. > > >> > > > +1. > > > > > > > > That said, do we actually need the param? Or can we just get this from > > Buffer::masterBuffer()->params().language()? Maybe that wouldn't be > > right, though, because you could have a child inside a child, with > > multiple languages along the way. > > Yep. And master_language should also be saved and then restored > (as already done with encoding) for that same reason.
I have committed the patch in trunk with this change. -- Enrico
