Re: Warnings for Pavel

2008-02-23 Thread Angus Leeming
Dov Feldstern wrote: So now the question is: do we need this function at all at this point? Since it seems to have been doing nothing for the past three years, can we just get rid of it? Does anyone know if what the code that's in there *should* have been doing is still needed? You should nev

Re: Warnings for Pavel

2008-02-23 Thread Dov Feldstern
Angus Leeming wrote: Pavel Sanda wrote: Pavel Sanda wrote: I purposely left RC_VISUAL_CURSOR out of this function, because something is fishy about it. AFAICT, this function doesn't do anything... JMarc took a look and I think he also wasn't sure about it... So before just fixing the warnings

Re: Warnings for Pavel

2008-02-22 Thread Angus Leeming
Pavel Sanda wrote: Pavel Sanda wrote: I purposely left RC_VISUAL_CURSOR out of this function, because something is fishy about it. AFAICT, this function doesn't do anything... JMarc took a look and I think he also wasn't sure about it... So before just fixing the warnings, we ought to try and

Re: Warnings for Pavel

2008-02-22 Thread Pavel Sanda
> Pavel Sanda wrote: >>> I purposely left RC_VISUAL_CURSOR out of this function, because something >>> is fishy about it. AFAICT, this function doesn't do anything... JMarc >>> took a look and I think he also wasn't sure about it... So before just >>> fixing the warnings, we ought to try and fig

Re: Warnings for Pavel

2008-02-22 Thread Dov Feldstern
Pavel Sanda wrote: I purposely left RC_VISUAL_CURSOR out of this function, because something is fishy about it. AFAICT, this function doesn't do anything... JMarc took a look and I think he also wasn't sure about it... So before just fixing the warnings, we ought to try and figure out what this

Re: Warnings for Pavel

2008-02-21 Thread Pavel Sanda
> I purposely left RC_VISUAL_CURSOR out of this function, because something > is fishy about it. AFAICT, this function doesn't do anything... JMarc took > a look and I think he also wasn't sure about it... So before just fixing > the warnings, we ought to try and figure out what this function *s

Re: Warnings for Pavel

2008-02-21 Thread Dov Feldstern
Richard Heck wrote: LyXFunc.cpp: In function 'void lyxactOnUpdatedPrefs(const lyx::LyXRC&, const lyx::LyXRC&)': LyXFunc.cpp:1885: warning: enumeration value 'RC_FULL_SCREEN_LIMIT' not handled in switch LyXFunc.cpp:1885: warning: enumeration value 'RC_FULL_SCREEN_SCROLLBAR' not handled in sw

Re: Warnings for Pavel

2008-02-20 Thread Pavel Sanda
> LyXFunc.cpp: In function 'void lyxactOnUpdatedPrefs(const > lyx::LyXRC&, const lyx::LyXRC&)': > LyXFunc.cpp:1885: warning: enumeration value 'RC_FULL_SCREEN_LIMIT' not > handled in switch > LyXFunc.cpp:1885: warning: enumeration value 'RC_FULL_SCREEN_SCROLLBAR' not > handled in switch > Ly