Angus Leeming wrote:
Pavel Sanda wrote:
Pavel Sanda wrote:
I purposely left RC_VISUAL_CURSOR out of this function, because
something is fishy about it. AFAICT, this function doesn't do
anything... JMarc took a look and I think he also wasn't sure about
it... So before just fixing the warnings, we ought to try and
figure out what this function *should* be doing, and whether it's
necessary at all. I'm pretty sure I went quite far back in history,
and it hasn't been doing anything for ages...
but there is some code for certain cases, no?
Yes, but that code is never executed, which is even more disturbing.
Notice that the just before the switch, tag is set to RC_LAST, which
is the *last* case in the switch...
Looks like I was smoking something funny at the time ;-)
i see now. i would ask Angus http://www.lyx.org/trac/changeset/9485 ,
whats the purpose of that
code.
If memory serves, the idea was to enable LyX to handle updates to the
preferences that traditionally required the user to restart LyX for the
changed preference to take effect.
I've no idea why I initialized tag as I did. Maybe, LyX just blew up
when the switch was executed?
1876 LyXRC::LyXRCTags tag = LyXRC::RC_LAST;
1877 switch (tag) {
Angus
So now the question is: do we need this function at all at this point?
Since it seems to have been doing nothing for the past three years, can
we just get rid of it? Does anyone know if what the code that's in there
*should* have been doing is still needed?
