Re: Small docbook refactoring

2003-10-30 Thread Jose' Matos
On Wednesday 29 October 2003 10:04, Martin Vermeer wrote: > On Tue, Oct 28, 2003 at 11:32:40AM +, Jose' Matos spake thusly: > > This code is a mess (it is my code so I am allowed to say that). I have > > discussed this two years ago with Jürgen Vigna and it appears that the > > latex output c

Re: Small docbook refactoring

2003-10-29 Thread Jose' Matos
On Wednesday 29 October 2003 11:44, Angus Leeming wrote: > > > > I worked pretty hard to get it out of Paragraph and Buffer. > > latex_generation.[Ch] perhaps? I was just thinking that > paragraph_funcs.C would start to get pretty cluttered if a whole heap > of sgml_generation stuff went in there t

Re: Small docbook refactoring

2003-10-29 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > | or move the latex generation stuff out... > > out where? > > I worked pretty hard to get it out of Paragraph and Buffer. latex_generation.[Ch] perhaps? I was just thinking that paragraph_funcs.C would start to get pretty cluttered if a whole heap of sgml_generati

Re: Small docbook refactoring

2003-10-29 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Jose' Matos wrote: > >> On Wednesday 29 October 2003 10:04, Martin Vermeer wrote: >>> >>> ...and should we somehow get rid of the '// environment tag >>> closing' stanza at the beginning? Yes, this looks messy :-) but I >>> don't dare to touch it without

Re: Small docbook refactoring

2003-10-29 Thread Angus Leeming
Jose' Matos wrote: > On Wednesday 29 October 2003 10:04, Martin Vermeer wrote: >> >> ...and should we somehow get rid of the '// environment tag >> closing' stanza at the beginning? Yes, this looks messy :-) but I >> don't dare to touch it without a non-trivial DocBook LyX test >> file... > > N

Re: Small docbook refactoring

2003-10-29 Thread Jose' Matos
On Wednesday 29 October 2003 10:04, Martin Vermeer wrote: > > ...and should we somehow get rid of the '// environment tag closing' > stanza at the beginning? Yes, this looks messy :-) but I don't dare to > touch it without a non-trivial DocBook LyX test file... Notice that now most of the code f

Re: Small docbook refactoring

2003-10-29 Thread Jose' Matos
On Wednesday 29 October 2003 10:04, Martin Vermeer wrote: > On Tue, Oct 28, 2003 at 11:32:40AM +, Jose' Matos spake thusly: > > This code is a mess (it is my code so I am allowed to say that). I have > > discussed this two years ago with Jürgen Vigna and it appears that the > > latex output c

Re: Small docbook refactoring

2003-10-29 Thread Jose' Matos
On Wednesday 29 October 2003 08:30, Martin Vermeer wrote: > On Tue, Oct 28, 2003 at 01:10:39PM +, Angus Leeming spake thusly: > > OK, so done. > > I plan to commit the attached later today. Ok. > - Martin > > BTW does anyone have a large and complex LyX source file in the > docbook class? T

Re: Small docbook refactoring

2003-10-29 Thread Martin Vermeer
On Tue, Oct 28, 2003 at 11:32:40AM +, Jose' Matos spake thusly: > This code is a mess (it is my code so I am allowed to say that). I have > discussed this two years ago with Jürgen Vigna and it appears that the latex > output code was redone to take in account the nested environments. Sp

Re: Small docbook refactoring

2003-10-29 Thread Martin Vermeer
On Tue, Oct 28, 2003 at 01:10:39PM +, Angus Leeming spake thusly: ... > The philosophy is that Buffer should be minimal but complete and that > we should provide free functions that operate on a Buffer instance. > Clearly this isn't the case at the moment but small steps... > > In this in

Re: Small docbook refactoring

2003-10-28 Thread Angus Leeming
Martin Vermeer wrote: > As for buffer_funcs or sgml, what is the philosophy for putting > things there? I just placed this thing together with > simpleDocBookOnePar based on similarity. Please advise, I have no > strong feelings. The philosophy is that Buffer should be minimal but complete and tha

Re: Small docbook refactoring

2003-10-28 Thread Martin Vermeer
On Tue, Oct 28, 2003 at 12:13:30PM +0100, Lars Gullik Bjønnes spake thusly: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | Attached. > > > | Introduces a method 'closeEnvTags' (sensible name?) which allows us to > | replace a largish number of identical-looking stanzas. Saves only 15 > | li

Re: Small docbook refactoring

2003-10-28 Thread Jose' Matos
On Tuesday 28 October 2003 11:23, Martin Vermeer wrote: > Attached. > > Introduces a method 'closeEnvTags' (sensible name?) which allows us to > replace a largish number of identical-looking stanzas. Saves only 15 > lines but I think the refactoring 'feels' right. The name is sensible, sure.

Re: Small docbook refactoring

2003-10-28 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | Attached. > | Introduces a method 'closeEnvTags' (sensible name?) which allows us to | replace a largish number of identical-looking stanzas. Saves only 15 | lines but I think the refactoring 'feels' right. > | There would be other opportunities for re