On Tue, Oct 28, 2003 at 12:13:30PM +0100, Lars Gullik Bjønnes spake thusly: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | Attached. > > > | Introduces a method 'closeEnvTags' (sensible name?) which allows us to > | replace a largish number of identical-looking stanzas. Saves only 15 > | lines but I think the refactoring 'feels' right. > > > | There would be other opportunities for refactoring in this code. This > | is in preparation of supporting the AGU DTD, which seems to be also > | based on OASIS. My idea is to parametrize as much as possible in the > | .layout file. > > > | Does this look like it can go in (should be functionally neutral)? > > Does it have to be a member of class Buffer, or could it just be in a > anon namespace? Or in buffer_funcs? even perhaps sglm.h?
I have been thinking about that. If it is in anon, how to call it from the textinset? And shouldn't then simpleDocBookOnePar() be there as well? As for buffer_funcs or sgml, what is the philosophy for putting things there? I just placed this thing together with simpleDocBookOnePar based on similarity. Please advise, I have no strong feelings. > | Index: buffer.h > | =================================================================== > | RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/buffer.h,v > | retrieving revision 1.168 > | diff -u -p -r1.168 buffer.h > | --- buffer.h 22 Oct 2003 14:40:24 -0000 1.168 > | +++ buffer.h 28 Oct 2003 09:28:56 -0000 > | @@ -153,6 +153,11 @@ public: > | bool output_preamble = true, > | bool output_body = true); > | /// > | + unsigned int Buffer::closeEnvTags(std::ostream & os, > ^^^^^^ > should not be here. Ah. The wonders of cut'n paste. > -- > Lgb - Martin
pgp00000.pgp
Description: PGP signature
