Re: Removal of Python 2 (Request for Comments)

2024-06-01 Thread Richard Kimberly Heck
On 6/1/24 06:53, José Matos wrote: On Fri, 2024-05-31 at 12:54 -0400, Richard Kimberly Heck wrote: I'm especially thinking of older files (say, lyx_1_5.py) that will not get much testing. It'd be bad to break one of those. I know that I am revisiting this but I want to give further context to w

Re: Removal of Python 2 (Request for Comments)

2024-06-01 Thread José Matos
On Fri, 2024-05-31 at 12:54 -0400, Richard Kimberly Heck wrote: > I'm especially thinking of older files (say, lyx_1_5.py) that will > not get much testing. It'd be bad to break one of those. I know that I am revisiting this but I want to give further context to why I am doing this. I am testing

Re: Removal of Python 2 (Request for Comments)

2024-05-31 Thread Richard Kimberly Heck
On 5/31/24 14:55, José Matos wrote: On Fri, 2024-05-31 at 12:54 -0400, Richard Kimberly Heck wrote: One question I had, though, was whether the formatted string changes in the lyx2lyx code are necessary. Or whether they're safe enough that I shouldn't worry. Those changes have been done automat

Re: Removal of Python 2 (Request for Comments)

2024-05-31 Thread José Matos
On Fri, 2024-05-31 at 12:54 -0400, Richard Kimberly Heck wrote: > One question I had, though, was whether the formatted string changes > in the lyx2lyx code are necessary. Or whether they're safe enough > that I shouldn't worry. Those changes have been done automatically through pyupgrade: https:/

Re: Removal of Python 2 (Request for Comments)

2024-05-31 Thread Richard Kimberly Heck
On 5/31/24 10:40, José Matos wrote: This is the code that I intend to submit to remove Python 2 support. I am also using formatted strings heavily, so in this case I am using Python 3.8 syntax. FWIW this patch is a mix between manual changes and using $ pyupgrade --py38-plus file.py I am put