On 5/31/24 10:40, José Matos wrote:
This is the code that I intend to submit to remove Python 2 support.

I am also using formatted strings heavily, so in this case I am using
Python 3.8 syntax.

FWIW this patch is a mix between manual changes and using

$ pyupgrade --py38-plus file.py


I am putting this here before applying to get your opinion on this.

I am mainly waiting for those who usually apply Python changes like
Jürgen, Riki or Enrico. Naturally that everyone is welcome to express
their opinion on this. :-)

Assuming we're agreed on 3.8 as a minimum going forward, this generally looks fine to me.

One question I had, though, was whether the formatted string changes in the lyx2lyx code are necessary. Or whether they're safe enough that I shouldn't worry. I'm especially thinking of older files (say, lyx_1_5.py) that will not get much testing. It'd be bad to break one of those.

Riki


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to