Re: Note, branch mailer clean-up

2004-01-05 Thread Andre Poenitz
On Fri, Jan 02, 2004 at 08:11:05PM +0100, Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > > | Andre Poenitz wrote: > >> Have you considered changing that params2string interface to > | ... > >> (or when we are at it even > >> > >> ostream & InsetBranchMailer::operator<<(o

Re: Note, branch mailer clean-up

2004-01-04 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: >> | I'd prefer to leave things as they are until I have a working >> | export_inset lfun (to post the data through the lyxserver) and a >> | working register_dialog lfun (so that our dialog is not shown on, >> | say, a mouse c

Re: Note, branch mailer clean-up

2004-01-04 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > | I'd prefer to leave things as they are until I have a working > | export_inset lfun (to post the data through the lyxserver) and a > | working register_dialog lfun (so that our dialog is not shown on, > | say, a mouse click, but rather the data is posted through the >

Re: Note, branch mailer clean-up

2004-01-02 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: > Pass the whole InsetParamsXXX in a boost::any to where it is used. The sender and the receiver knows the type so now prob. Now all the mailer code can go. >>> >> | You replace 20 lines of code per inset with 20

Re: Note, branch mailer clean-up

2004-01-02 Thread Angus Leeming
Lars Gullik Bjønnes wrote: >>> Pass the whole InsetParamsXXX in a boost::any to where it is used. >>> The sender and the receiver knows the type so now prob. Now all >>> the mailer code can go. >> > | You replace 20 lines of code per inset with 20 lines of code per > | inset. > > I do not think s

Re: Note, branch mailer clean-up

2004-01-02 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: > >> Angus Leeming <[EMAIL PROTECTED]> writes: >> >> | Lars Gullik Bjønnes wrote: | No it's not. If the data is passed as a string then we allow the | outside world to receive the data, modify it and post it back >>>

Re: Note, branch mailer clean-up

2004-01-02 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > > | Lars Gullik Bjønnes wrote: >>> | No it's not. If the data is passed as a string then we allow the >>> | outside world to receive the data, modify it and post it back >>> | with no addditional effort to us. >>> >>> this

Re: Note, branch mailer clean-up

2004-01-02 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: >> | No it's not. If the data is passed as a string then we allow the >> | outside world to receive the data, modify it and post it back with >> | no addditional effort to us. >> >> this is the exception (external data), for a

Re: Note, branch mailer clean-up

2004-01-02 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > | No it's not. If the data is passed as a string then we allow the > | outside world to receive the data, modify it and post it back with > | no addditional effort to us. > > this is the exception (external data), for all internal stuff > serialization _and_ the mailer

Re: Note, branch mailer clean-up

2004-01-02 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: > >> Angus Leeming <[EMAIL PROTECTED]> writes: >> >> | Andre Poenitz wrote: Have you considered changing that params2string interface to >> | ... (or when we are at it even ostream & InsetBranchMailer::ope

Re: Note, branch mailer clean-up

2004-01-02 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > > | Andre Poenitz wrote: >>> Have you considered changing that params2string interface to > | ... >>> (or when we are at it even >>> >>> ostream & InsetBranchMailer::operator<<(ostream & os, >>> InsetBranchParams const &) >

Re: Note, branch mailer clean-up

2004-01-02 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Andre Poenitz wrote: >> Have you considered changing that params2string interface to | ... >> (or when we are at it even >> >> ostream & InsetBranchMailer::operator<<(ostream & os, >> InsetBranchParams const &) >> { >> os << name << ' '; >> os << name_

Re: Note, branch mailer clean-up

2003-12-11 Thread Andre Poenitz
On Thu, Dec 11, 2003 at 06:24:16PM +, Angus Leeming wrote: > > I just happened to notice that M-x accent-hungarian-umluat o does > > not work in 1.4.0cvs ;-) > > Depends how you define 'not working'. Here I get '\H{111}', which is > nice ;-) But somewhat surprising for the unsuspecting. A

Re: Note, branch mailer clean-up

2003-12-11 Thread Angus Leeming
Andre Poenitz wrote: > Not much. > So look for another playground. Not my playground anyway. It was you who was bothered by this, remember. I was sufficiently respectful to take the time to look into your ideas and sufficiently disrespectful to refute them once I'd done so ;-) > I just happene

Re: Note, branch mailer clean-up

2003-12-11 Thread Andre Poenitz
On Thu, Dec 11, 2003 at 05:57:57PM +, Angus Leeming wrote: > Andre Poenitz wrote: > In fact, InsetBibitem could have a constructor from a string and user > code would look like > > if (name == "bibitem") { > return new InsetBibitem(cmd.argument); > > I'd rather that we used a free f

Re: Note, branch mailer clean-up

2003-12-11 Thread Angus Leeming
Andre Poenitz wrote: In fact, InsetBibitem could have a constructor from a string and user code would look like if (name == "bibitem") { return new InsetBibitem(cmd.argument); I'd rather that we used a free function returning 0 if the data was bogus. InsetOld * InsetCommandMail

Re: Note, branch mailer clean-up

2003-12-11 Thread Andre Poenitz
On Thu, Dec 11, 2003 at 09:58:44AM +, Angus Leeming wrote: > 2. Example usage of string2params, in factory.C's createInset: > > case LFUN_INSET_INSERT: { > string const name = cmd.getArg(0); > > if (name == "bibitem") { > InsetCo

Re: Note, branch mailer clean-up

2003-12-11 Thread Angus Leeming
Andre Poenitz wrote: > Have you considered changing that params2string interface to ... > (or when we are at it even > > ostream & InsetBranchMailer::operator<<(ostream & os, > InsetBranchParams const &) > { > os << name << ' '; > os << name_ << ' '; > params.write(os); > // Add all_branches param

Re: Note, branch mailer clean-up

2003-12-10 Thread Angus Leeming
Jose' Matos wrote: > How about > > def convert_note(lines): > i = 0 > while 1: > i = find_tokens(lines, ["\\begin_inset Note", > "\\begin_inset Comment", > "\\begin_inset Greyedout"], i) > if i == -1: > break > > lines[i] = lines[i][8:] + 'Note ' + lines[i][:8] > > Not tested

Re: Note, branch mailer clean-up

2003-12-10 Thread Jose' Matos
On Wednesday 10 December 2003 15:40, Angus Leeming wrote: > > \begin_inset Note -> \begin_inset Note Note > \begin_inset Comment -> \begin_inset Note Comment > \begin_inset Greyedout -> \begin_inset Note Greyedout > > I'll up the file format to 226 and have been thinking about > lyxconvert_225.py >

Re: Note, branch mailer clean-up

2003-12-10 Thread Angus Leeming
Andre Poenitz wrote: > Have you considered changing that params2string interface to > void InsetBranchMailer::params2string(InsetBranchParams const &, > ostream & data) > { > data << name << ' '; > data << name_ << ' '; > params.write(data); >

Re: Note, branch mailer clean-up

2003-12-10 Thread Angus Leeming
Jose' Matos wrote: > On Wednesday 10 December 2003 14:49, Angus Leeming wrote: >> No need to pass the 'name' to each instance of InsetNoteMailer, >> InsetBranchMailer as this name is fixed for each Mailer type. >> >> Committing now. > > Is the fileformat changed? No, but my next one does chang

Re: Note, branch mailer clean-up

2003-12-10 Thread Andre Poenitz
On Wed, Dec 10, 2003 at 02:49:15PM +, Angus Leeming wrote: > No need to pass the 'name' to each instance of InsetNoteMailer, > InsetBranchMailer as this name is fixed for each Mailer type. > > Committing now. Concerning -string const InsetBranchMailer::params2string(string const & n

Re: Note, branch mailer clean-up

2003-12-10 Thread Jose' Matos
On Wednesday 10 December 2003 14:49, Angus Leeming wrote: > No need to pass the 'name' to each instance of InsetNoteMailer, > InsetBranchMailer as this name is fixed for each Mailer type. > > Committing now. Is the fileformat changed? -- José Abílio LyX and docbook, a perfect match. :-)