Re: Hello again!

2003-08-17 Thread Martin Vermeer
On Sat, Aug 16, 2003 at 07:19:01PM +0200, Lars Gullik Bjønnes spake thusly: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | See attached. Against CVS of an hour ago. > > I am not looking at how this work only on how it is implemented. > > | +string Branch::getBranch() const > | +{ > | + r

Re: Hello again!

2003-08-16 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | See attached. Against CVS of an hour ago. I am not looking at how this work only on how it is implemented. | +string Branch::getBranch() const | +{ | + return branch_; | +} Why are you not returning a const reference? | +string Branch::getColor(

Re: Hello again!

2003-08-16 Thread Martin Vermeer
On Wed, Aug 13, 2003 at 01:16:58AM +0200, Lars Gullik Bjønnes spake thusly: > ill (millstone?) of my own making. I would have liked Lars > | to review this one, or at least give the go-ahead as he is "Mr. LyX" > | and this *is* major new functionality. > > If you post a new patch fully up-to-dat

Re: Hello again!

2003-08-15 Thread John Levon
On Fri, Aug 15, 2003 at 06:57:22PM +0300, Martin Vermeer wrote: > > 2) when closing a branch and a cursor is inside, the cursor is not > > reset. > > I do not understand what you mean. > > If you mean: > - place cursor in inset > - close inset > - visible cursor lands on top of button Yes, but

Re: Hello again!

2003-08-15 Thread Martin Vermeer
On Wed, Aug 13, 2003 at 12:28:25AM +0100, John Levon spake thusly: > > On Mon, Aug 11, 2003 at 08:12:36PM +0300, Martin Vermeer wrote: > > > Here's an update. Two bugs squashed, an off-by-one in ColorHandler > > Generally seems OK. Problems : > > 1) the default color is black. This "should" giv

Re: Hello again!

2003-08-14 Thread Michael Schmitt
Andre Poenitz wrote: Do you know of a tool to identify "dead" code? I.e. not accessed by anything else? [gprof seems to be able to add usage count on a per-line base, but that's just for the things actually used in the profile run...] Andre, I have written a tiny shell script that retrieves all sy

Re: Hello again!

2003-08-14 Thread Andre Poenitz
On Mon, Aug 11, 2003 at 05:26:36PM +0200, Lars Gullik Bjønnes wrote: > Michael Schmitt <[EMAIL PROTECTED]> writes: > > | Andre Poenitz wrote: > > > >>Do you know of a tool to identify "dead" code? I.e. not accessed by > >>anything else? [gprof seems to be able to add usage count on a per-line > >>

Re: Hello again!

2003-08-14 Thread Angus Leeming
Andre Poenitz wrote: > On Mon, Aug 11, 2003 at 05:26:36PM +0200, Lars Gullik Bjønnes wrote: >> Michael Schmitt <[EMAIL PROTECTED]> writes: >> >> | Andre Poenitz wrote: >> > >> >>Do you know of a tool to identify "dead" code? I.e. not accessed >> >>by anything else? [gprof seems to be able to add

Re: Hello again!

2003-08-14 Thread John Levon
On Mon, Aug 11, 2003 at 08:12:36PM +0300, Martin Vermeer wrote: > Here's an update. Two bugs squashed, an off-by-one in ColorHandler missing using std::auto_ptr; in insetbranch.C john

Re: Hello again!

2003-08-14 Thread Martin Vermeer
On Tue, Aug 12, 2003 at 06:17:22PM +0100, John Levon spake thusly: > On Mon, Aug 11, 2003 at 08:12:36PM +0300, Martin Vermeer wrote: > > > Here's an update. Two bugs squashed, an off-by-one in ColorHandler > > + > + // Open insets of selected branches, close deselected ones > + // C

Re: Hello again!

2003-08-14 Thread Andre Poenitz
On Tue, Aug 12, 2003 at 06:17:22PM +0100, John Levon wrote: > I'm building this now. From looking at the patch, I'm OK if it's applied > (finally !). We really put you through the mill on this one :) Just commit what is there and fix the small stuff later. Makes people happy people. Andre' -- T

Re: Hello again!

2003-08-14 Thread Juergen Spitzmueller
Michael Schmitt wrote: > I am back from holidays what's holidays? ;-) > is there anything that requires testing? I think you can help Martin with testing his latest and greatest branch patch. Juergen.

Re: Hello again!

2003-08-14 Thread Martin Vermeer
On Mon, Aug 11, 2003 at 01:24:23PM +0200, Michael Schmitt spake thusly: > > Hi, > > I am back from holidays and I already managed to work through your > hundreds of emails and cvs commits. > > What is the current status of LyX? Is it usable again? Andre, is there > anything that requires testi

Re: Hello again!

2003-08-14 Thread John Levon
On Mon, Aug 11, 2003 at 08:12:36PM +0300, Martin Vermeer wrote: > Here's an update. Two bugs squashed, an off-by-one in ColorHandler + + // Open insets of selected branches, close deselected ones + // Currently only top-level insets in buffer handled (bug). + ParagraphList::iter

Re: Hello again!

2003-08-14 Thread John Levon
On Mon, Aug 11, 2003 at 08:12:36PM +0300, Martin Vermeer wrote: > Here's an update. Two bugs squashed, an off-by-one in ColorHandler Generally seems OK. Problems : 1) the default color is black. This "should" give a black background. It doesn't. There's also no indication in the dialog what the

Re: Hello again!

2003-08-14 Thread John Levon
On Tue, Aug 12, 2003 at 11:46:51PM +0300, Martin Vermeer wrote: > Great, thanks. One last-minute gremlin I found: missing using std::binary_function in BrancList.C regards john -- Khendon's Law: If the same point is made twice by the same person, the thread is over.

Re: Hello again!

2003-08-14 Thread Andre Poenitz
On Mon, Aug 11, 2003 at 01:24:23PM +0200, Michael Schmitt wrote: > Hi, > > I am back from holidays and I already managed to work through your > hundreds of emails and cvs commits. > > What is the current status of LyX? Is it usable again? Don't think so. > Andre, is there anything that require

Re: Hello again!

2003-08-14 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | Partly a mill (millstone?) of my own making. I would have liked Lars | to review this one, or at least give the go-ahead as he is "Mr. LyX" | and this *is* major new functionality. If you post a new patch fully up-to-date. I promise to take a look at i

Re: Hello again!

2003-08-11 Thread Martin Vermeer
On Mon, Aug 11, 2003 at 03:30:00PM +0300, Martin Vermeer spake thusly: > > > > Hi, > > > > I am back from holidays and I already managed to work through your > > hundreds of emails and cvs commits. > > > > What is the current status of LyX? Is it usable again? Andre, is there > > anything that

Re: Hello again!

2003-08-11 Thread Lars Gullik Bjønnes
Michael Schmitt <[EMAIL PROTECTED]> writes: | Andre Poenitz wrote: > >>Do you know of a tool to identify "dead" code? I.e. not accessed by >>anything else? [gprof seems to be able to add usage count on a per-line >>base, but that's just for the things actually used in the profile >>run...] >> > |

Re: Hello again!

2003-08-11 Thread John Levon
On Mon, Aug 11, 2003 at 02:09:07PM +0200, Andre Poenitz wrote: > Do you know of a tool to identify "dead" code? I.e. not accessed by -ffunction-sections, then ld --verbose --gc-sections *might* help. findstatic.pl also *might* help : http://kernelnewbies.org/scripts/ regards john -- Khendon's