On Tue, Aug 12, 2003 at 06:17:22PM +0100, John Levon spake thusly:
> On Mon, Aug 11, 2003 at 08:12:36PM +0300, Martin Vermeer wrote:
>
> > Here's an update. Two bugs squashed, an off-by-one in ColorHandler
>
> +
> + // Open insets of selected branches, close deselected ones
> + // Currently only top-level insets in buffer handled (bug).
> + ParagraphList::iterator pit = buffer()->paragraphs.begin();
> + ParagraphList::iterator pend = buffer()->paragraphs.end();
> + for (; pit != pend; ++pit) {
> + pit->insetlist.insetsOpenCloseBranch(bufferview());
> + }
>
> You can use a ParIterator to do this I think.Indeed. THANKS! Now it works on all branch insets, not only top level ones (i.e. also those within other insets). GREAT! > + void branch_input( FL_OBJECT *); > > whitespace OK > +int InsetBranch::latex(Buffer const * buf, ostream & os, > + LatexRunParams const & runparams) > const > > Your use of tabs for alignment means I see stuff like this. > > http://www.movement.uklinux.net/docs/whytabs/ Yeah... an eternal problem. Not using tabs as such, but too many of them here... > It would be nice to see some docs on this feature ... > > I'm building this now. From looking at the patch, I'm OK if it's applied > (finally !). Great, thanks. One last-minute gremlin I found: edit branch_apply to look like void FormDocument::branch_apply(BufferParams & params) { BufferParams & prms = controller().params(); if (branchlist_.empty()) branchlist_ = prms.branchlist; params.branchlist = branchlist_; branchlist_.clear(); } ...this is not in the patch. [...and the std:auto_ptr thing from your other mail, done, thx] > We really put you through the mill on this one :) Partly a mill (millstone?) of my own making. I would have liked Lars to review this one, or at least give the go-ahead as he is "Mr. LyX" and this *is* major new functionality. > I suggest that if you don't hear any more complaints in the next day > that you apply it That will be several days... > regards > john Best Martin
pgp00000.pgp
Description: PGP signature
