Re: Cut & Paste in tables is broken!

2005-09-19 Thread Andre Poenitz
On Tue, Sep 06, 2005 at 12:05:32PM +0300, Martin Vermeer wrote: > On Tue, 2005-09-06 at 09:45 +0200, Juergen Spitzmueller wrote: > > Martin Vermeer wrote: > > > I may be missing something, but wouldn't it be simpler to just > > > empty/invalidate the tabular paste buffer whenever the text paste buf

Re: bug 1765 (was: Re: Cut & Paste in tables is broken!)

2005-09-16 Thread Martin Vermeer
On Fri, 2005-09-16 at 11:59 +0200, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | On Thu, 2005-09-15 at 14:10 +0200, Juergen Spitzmueller wrote: > | > Martin Vermeer wrote: > | > > > Please post the patch to bugzilla. I'll be happy to test it once my > tree > | > >

Re: bug 1765 (was: Re: Cut & Paste in tables is broken!)

2005-09-16 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Thu, 2005-09-15 at 14:10 +0200, Juergen Spitzmueller wrote: | > Martin Vermeer wrote: | > > > Please post the patch to bugzilla. I'll be happy to test it once my tree | > > > is ready for it (i.e., my tabular changes are in). | > > | > > So done. | >

Re: bug 1765 (was: Re: Cut & Paste in tables is broken!)

2005-09-16 Thread Martin Vermeer
On Thu, 2005-09-15 at 14:10 +0200, Juergen Spitzmueller wrote: > Martin Vermeer wrote: > > > Please post the patch to bugzilla. I'll be happy to test it once my tree > > > is ready for it (i.e., my tabular changes are in). > > > > So done. > > The patch fixes the bug, as far a can tell from my tes

bug 1765 (was: Re: Cut & Paste in tables is broken!)

2005-09-15 Thread Juergen Spitzmueller
Martin Vermeer wrote: > > Please post the patch to bugzilla. I'll be happy to test it once my tree > > is ready for it (i.e., my tabular changes are in). > > So done. The patch fixes the bug, as far a can tell from my testing. Jürgen

Re: Cut & Paste in tables is broken!

2005-09-07 Thread Martin Vermeer
On Wed, 2005-09-07 at 10:27 +0200, Juergen Spitzmueller wrote: > Martin Vermeer wrote: > > BTW I have my patch for 1765 also still sitting in my tree, untested and > > uncommitted > > Please post the patch to bugzilla. I'll be happy to test it once my tree is > ready for it (i.e., my tabular chan

Re: Cut & Paste in tables is broken!

2005-09-07 Thread Juergen Spitzmueller
Martin Vermeer wrote: > BTW I have my patch for 1765 also still sitting in my tree, untested and > uncommitted Please post the patch to bugzilla. I'll be happy to test it once my tree is ready for it (i.e., my tabular changes are in). Jürgen

Re: Cut & Paste in tables is broken!

2005-09-06 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > > Yes, I guess os. > > Thanks. I'll add bold FIXME's. I've just applied the attached patch. Jürgen Index: ChangeLog === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/ChangeLog,v retrieving revision 1.22

Re: Cut & Paste in tables is broken!

2005-09-06 Thread Juergen Spitzmueller
Lars Gullik Bjønnes wrote: > | Lars, can Jürgen's patch go in? > > Yes, I guess os. Thanks. I'll add bold FIXME's. Jürgen

Re: Cut & Paste in tables is broken!

2005-09-06 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Tue, 2005-09-06 at 11:23 +0200, Juergen Spitzmueller wrote: >> Martin Vermeer wrote: >> > This explanation crossed my mind too, but can it be true? You only need >> > access to paste_tabular, which is a pointer. And isn't it global anyway? >> > You h

Re: Cut & Paste in tables is broken!

2005-09-06 Thread Martin Vermeer
On Tue, 2005-09-06 at 11:23 +0200, Juergen Spitzmueller wrote: > Martin Vermeer wrote: > > This explanation crossed my mind too, but can it be true? You only need > > access to paste_tabular, which is a pointer. And isn't it global anyway? > > You have only one tabular paste buffer for all of LyX.

Re: Cut & Paste in tables is broken!

2005-09-06 Thread Juergen Spitzmueller
Martin Vermeer wrote: > This explanation crossed my mind too, but can it be true? You only need > access to paste_tabular, which is a pointer. And isn't it global anyway? > You have only one tabular paste buffer for all of LyX. What about moving > this over to CutAndPaste? > > Wondering. Please co

Re: Cut & Paste in tables is broken!

2005-09-06 Thread Martin Vermeer
On Tue, 2005-09-06 at 09:45 +0200, Juergen Spitzmueller wrote: > Martin Vermeer wrote: > > I may be missing something, but wouldn't it be simpler to just > > empty/invalidate the tabular paste buffer whenever the text paste buffer > > is being filled by a cut/copy (and thus becomes fresher)? That w

Re: Cut & Paste in tables is broken!

2005-09-06 Thread Juergen Spitzmueller
Martin Vermeer wrote: > I may be missing something, but wouldn't it be simpler to just > empty/invalidate the tabular paste buffer whenever the text paste buffer > is being filled by a cut/copy (and thus becomes fresher)? That way you > don't have to introduce an extra state tracking boolean. I th

Re: Cut & Paste in tables is broken!

2005-09-04 Thread Martin Vermeer
On Thu, 01 Sep 2005 11:35:10 +0200 Juergen Spitzmueller <[EMAIL PROTECTED]> wrote: > Georg Baum wrote: > > > Confirmed. Undo is b0rked for tabular multi-cell content. > > > > > > Furthermore, undoing the deletion of a table cell content text will > > > result in the cell content being an *indente

Re: Cut & Paste in tables is broken!

2005-09-04 Thread Juergen Spitzmueller
Michael Gerz wrote: > The second patch cannot be applied: Here's a fresh one. Note, however, that you have to revert the other fix first to get this applied. Jürgen Index: insettabular.C === RCS file: /usr/local/lyx/cvsroot/lyx-deve

Re: Cut & Paste in tables is broken!

2005-09-03 Thread Andre Poenitz
On Thu, Sep 01, 2005 at 02:05:51PM +0200, Alfredo Braunstein wrote: > Yes, I know it sounds a bit of work to apparently get less functionality > (only 1 cut buffer) but I really think it would be much better ui-wise. > > For 1.5 if any. Thoughts? There should be only one cut buffer, and this shou

Re: Cut & Paste in tables is broken!

2005-09-01 Thread Juergen Spitzmueller
Michael Gerz wrote: > The second patch cannot be applied: I'll post an updated patch when cvs is up again. Note that both patches probably cannot be applied at the same time. I have done the changes in different trees, to keep them separate. Jürgen

Re: Cut & Paste in tables is broken!

2005-09-01 Thread Michael Gerz
Juergen Spitzmueller wrote: The other bug as well. Together with two patches, which are waiting for testers for several weeks now. http://marc.theaimsgroup.com/?l=lyx-devel&m=112256299217504&w=2 http://marc.theaimsgroup.com/?l=lyx-devel&m=112255580906802&w=2 The second patch cannot be appli

Re: Cut & Paste in tables is broken!

2005-09-01 Thread Michael Gerz
Alfredo Braunstein wrote: I always hated this. In fact I think that we should hide this to the user. In particular with math (same thing happends) I find this very annoying (did I cut the equation inside math, or just the whole math inset?). It would be possible to take a note of which type the

Re: Cut & Paste in tables is broken!

2005-09-01 Thread Juergen Spitzmueller
Alfredo Braunstein wrote: > I always hated this. In fact I think that we should hide this to the user. > In particular with math (same thing happends) I find this very annoying > (did I cut the equation inside math, or just the whole math inset?). > > It would be possible to take a note of which ty

Re: Cut & Paste in tables is broken!

2005-09-01 Thread Michael Gerz
Martin Vermeer wrote: On Wed, Aug 31, 2005 at 10:23:38PM +0200, Michael Gerz wrote: Test case: 1. Create a new 5x5 table 2. Fill the cells in the first two rows with some random content 3. Cut the content of the fourth column (cells in 1st and 2rd row) 4. Cut some text from the first cell i

Re: Cut & Paste in tables is broken!

2005-09-01 Thread Juergen Spitzmueller
Georg Baum wrote: > > Confirmed. Undo is b0rked for tabular multi-cell content. > > > > Furthermore, undoing the deletion of a table cell content text will > > result in the cell content being an *indented* paragraph, which is wrong > > as well. > > > > Please put this into bugzilla once Lars gets

Re: Cut & Paste in tables is broken!

2005-09-01 Thread Juergen Spitzmueller
Georg Baum wrote: > > Confirmed. Undo is b0rked for tabular multi-cell content. > > > > Furthermore, undoing the deletion of a table cell content text will > > result in the cell content being an *indented* paragraph, which is wrong > > as well. > > > > Please put this into bugzilla once Lars gets

Re: Cut & Paste in tables is broken!

2005-09-01 Thread Alfredo Braunstein
Martin Vermeer wrote: > On Wed, Aug 31, 2005 at 10:23:38PM +0200, Michael Gerz wrote: >> Test case: >> >> 1. Create a new 5x5 table >> 2. Fill the cells in the first two rows with some random content >> 3. Cut the content of the fourth column (cells in 1st and 2rd row) >> 4. Cut some text from th

Re: Cut & Paste in tables is broken!

2005-09-01 Thread John Levon
On Thu, Sep 01, 2005 at 08:39:54AM +0300, Martin Vermeer wrote: > > 1. Create a new 5x5 table > > 2. Fill the cells in the first two rows with some random content > > 3. Cut the content of the fourth column (cells in 1st and 2rd row) > > 4. Cut some text from the first cell in row 1 > > 5. Paste i

Re: Cut & Paste in tables is broken!

2005-09-01 Thread Georg Baum
Martin Vermeer wrote: > Confirmed. Undo is b0rked for tabular multi-cell content. > > Furthermore, undoing the deletion of a table cell content text will > result in the cell content being an *indented* paragraph, which is wrong > as well. > > Please put this into bugzilla once Lars gets it up a

Re: Cut & Paste in tables is broken!

2005-08-31 Thread Martin Vermeer
On Wed, Aug 31, 2005 at 10:23:38PM +0200, Michael Gerz wrote: > Test case: > > 1. Create a new 5x5 table > 2. Fill the cells in the first two rows with some random content > 3. Cut the content of the fourth column (cells in 1st and 2rd row) > 4. Cut some text from the first cell in row 1 > 5. Past