Re: Big GUII patch

2002-05-23 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Thu, May 23, 2002 at 12:34:15PM +0200, Lars Gullik Bjønnes wrote: > >> I am not sure I am in complete agreement with this one... > | I think there needs to be some refactoring done here anyway. Many | of the accessors never made much sense to me. But I

Re: Big GUII patch

2002-05-23 Thread John Levon
On Thu, May 23, 2002 at 12:21:03PM +0100, Angus Leeming wrote: > of course, if you used namespace front, then you could even rename it as > Screen... , true... john -- "This is playing, not work, therefore it's not a waste of time." - Zath

Re: Big GUII patch

2002-05-23 Thread Angus Leeming
On Thursday 23 May 2002 11:06 am, John Levon wrote: > http://movementarian.org/q8.diff.bz2 > > I've written a short summary below of what the patch has done so far. > I'm not sure what I should merge next - there are still some "move this" > things to be done, but they get more tricky ... > > 2. s

Re: Big GUII patch

2002-05-23 Thread John Levon
On Thu, May 23, 2002 at 12:34:15PM +0200, Lars Gullik Bjønnes wrote: > I am not sure I am in complete agreement with this one... I think there needs to be some refactoring done here anyway. Many of the accessors never made much sense to me. But I feel really queasy about a setWindowTitle() metho

Re: Big GUII patch

2002-05-23 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Thu, May 23, 2002 at 12:22:16PM +0200, Lars Gullik Bjønnes wrote: > >> | 19,000 lines of diff ... yipes >> >> Are you able to break this one up? > | Heh, I'm not being very clear today am I. The URL is just for reference, | not a patch submission. > >>

Re: Big GUII patch

2002-05-23 Thread John Levon
On Thu, May 23, 2002 at 12:26:47PM +0200, Andre Poenitz wrote: > Does it work, John? Not really. And it will be split. Angus is dead right that it must be done in small logical changes, compiling all the time. It will triple the work load but it is the only honest way. If Al Viro can rewrite t

Re: Big GUII patch

2002-05-23 Thread John Levon
On Thu, May 23, 2002 at 12:22:16PM +0200, Lars Gullik Bjønnes wrote: > | 19,000 lines of diff ... yipes > > Are you able to break this one up? Heh, I'm not being very clear today am I. The URL is just for reference, not a patch submission. > It is a tiny bit larger than what I am confortable w

Re: Big GUII patch

2002-05-23 Thread Andre Poenitz
On Thu, May 23, 2002 at 12:22:16PM +0200, Lars Gullik Bjønnes wrote: > Are you able to break this one up? > > It is a tiny bit larger than what I am confortable with. > > breaking into say ... 17 patches would be good. If it works you don't win by splitting... Does it work, John? Andre' --

Re: Big GUII patch

2002-05-23 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | Against current CVS (modulo removed file clashes I still haven't | fixed) : > | http://movementarian.org/q8.diff.bz2 > | 19,000 lines of diff ... yipes Are you able to break this one up? It is a tiny bit larger than what I am confortable with. breaking