John Levon <[EMAIL PROTECTED]> writes: | On Thu, May 23, 2002 at 12:34:15PM +0200, Lars Gullik Bjønnes wrote: > >> I am not sure I am in complete agreement with this one... > | I think there needs to be some refactoring done here anyway. Many | of the accessors never made much sense to me. But I feel really queasy | about a setWindowTitle() method in core code, and the fact that it will | be the only case in a simple GUII inheritance hierarchy where the | toolkit-specific versions inherit from something in core code. Source | discoverability is good, and code to update the environment combo truly | belongs in frontends/ > | The important thing to note is that this is of course a first iteration. | It's not meant to be perfectly factored, and it certainly isn't. > >> send the patch for a lookee.. > | Attached. Boring huh ? Shout if you want a look at the proper GUII | LyXView files too (iirc they're not that different) > >> And we get one humongous merge into head later on... eh... > | Actually I was thinking of the exact opposite. We create a branch, apply | the huge patch to it, fix stuff up, then merge bit by bit back to the | trunk.
Yes, that sounds ok. and just apply this patch. -- Lgb