Re: Behavior of second preview after error

2015-09-11 Thread Scott Kostyshak
On Fri, Sep 11, 2015 at 06:26:41AM +, Guenter Milde wrote: > On 2015-09-11, Scott Kostyshak wrote: > > On Tue, Sep 08, 2015 at 07:16:52AM +, Guenter Milde wrote: > >> On 2015-09-08, Scott Kostyshak wrote: > >> > On Mon, Sep 7, 2015 at 9:57 PM, Enrico Forestieri wrote: > > ... > > >>S

Re: Behavior of second preview after error

2015-09-10 Thread Guenter Milde
On 2015-09-11, Scott Kostyshak wrote: > On Tue, Sep 08, 2015 at 07:16:52AM +, Guenter Milde wrote: >> On 2015-09-08, Scott Kostyshak wrote: >> > On Mon, Sep 7, 2015 at 9:57 PM, Enrico Forestieri wrote: ... >>Sometimes get an compilation error when removing a language option >>from a

Re: Behavior of second preview after error

2015-09-10 Thread Scott Kostyshak
On Tue, Sep 08, 2015 at 07:16:52AM +, Guenter Milde wrote: > On 2015-09-08, Scott Kostyshak wrote: > > On Mon, Sep 7, 2015 at 9:57 PM, Enrico Forestieri wrote: > >> On Mon, Sep 07, 2015 at 04:11:07PM -0400, Scott Kostyshak wrote: > >>> On Sun, May 03, 2015 at 02:02:06AM +0200, Enrico Forestier

Re: Behavior of second preview after error

2015-09-08 Thread Guenter Milde
On 2015-09-08, Scott Kostyshak wrote: > On Mon, Sep 7, 2015 at 9:57 PM, Enrico Forestieri wrote: >> On Mon, Sep 07, 2015 at 04:11:07PM -0400, Scott Kostyshak wrote: >>> On Sun, May 03, 2015 at 02:02:06AM +0200, Enrico Forestieri wrote: >>> > On Sat, May 02, 2015 at 07:03:53PM -0400, Scott Kostysha

Re: Behavior of second preview after error

2015-09-07 Thread Scott Kostyshak
On Mon, Sep 7, 2015 at 9:57 PM, Enrico Forestieri wrote: > On Mon, Sep 07, 2015 at 04:11:07PM -0400, Scott Kostyshak wrote: > >> On Sun, May 03, 2015 at 02:02:06AM +0200, Enrico Forestieri wrote: >> > On Sat, May 02, 2015 at 07:03:53PM -0400, Scott Kostyshak wrote: >> > > >> > > Attached is a patc

Re: Behavior of second preview after error

2015-09-07 Thread Enrico Forestieri
On Mon, Sep 07, 2015 at 04:11:07PM -0400, Scott Kostyshak wrote: > On Sun, May 03, 2015 at 02:02:06AM +0200, Enrico Forestieri wrote: > > On Sat, May 02, 2015 at 07:03:53PM -0400, Scott Kostyshak wrote: > > > > > > Attached is a patch. I have tested it and it works well for me. I'm > > > not sure

Re: Behavior of second preview after error

2015-09-07 Thread Scott Kostyshak
On Sun, May 03, 2015 at 02:02:06AM +0200, Enrico Forestieri wrote: > On Sat, May 02, 2015 at 07:03:53PM -0400, Scott Kostyshak wrote: > > > > Attached is a patch. I have tested it and it works well for me. I'm > > not sure about one part of the implementation. I have > > Converters::runLaTeX() che

Re: Behavior of second preview after error

2015-05-04 Thread Scott Kostyshak
On Sun, May 3, 2015 at 7:09 PM, Scott Kostyshak wrote: > On Sun, May 3, 2015 at 5:21 PM, Enrico Forestieri wrote: >> On Sun, May 03, 2015 at 04:07:28PM -0400, Scott Kostyshak wrote: >> >>> On Sun, May 3, 2015 at 11:00 AM, Enrico Forestieri wrote: >>> > On Sun, May 03, 2015 at 01:52:33AM -0400, S

Re: Behavior of second preview after error

2015-05-04 Thread Scott Kostyshak
On Mon, May 4, 2015 at 3:39 AM, Kornel Benko wrote: > Am Sonntag, 3. Mai 2015 um 19:09:35, schrieb Scott Kostyshak > >> >> OK I'll rename to removeAuxiliaryFiles. I'll do that as soon as master >> is compilable again. >> >> Scott > > For now I suggest simply add '\n' to the string at po/ar.po:22

Re: Behavior of second preview after error

2015-05-04 Thread Kornel Benko
Am Sonntag, 3. Mai 2015 um 19:09:35, schrieb Scott Kostyshak > > OK I'll rename to removeAuxiliaryFiles. I'll do that as soon as master > is compilable again. > > Scott For now I suggest simply add '\n' to the string at po/ar.po:22581. At least this makes master compilable again. Korne

Re: Behavior of second preview after error

2015-05-03 Thread Scott Kostyshak
On Sun, May 3, 2015 at 5:21 PM, Enrico Forestieri wrote: > On Sun, May 03, 2015 at 04:07:28PM -0400, Scott Kostyshak wrote: > >> On Sun, May 3, 2015 at 11:00 AM, Enrico Forestieri wrote: >> > On Sun, May 03, 2015 at 01:52:33AM -0400, Scott Kostyshak wrote: >> > >> >> On Sat, May 2, 2015 at 8:02 P

Re: Behavior of second preview after error

2015-05-03 Thread Enrico Forestieri
On Sun, May 03, 2015 at 04:07:28PM -0400, Scott Kostyshak wrote: > On Sun, May 3, 2015 at 11:00 AM, Enrico Forestieri wrote: > > On Sun, May 03, 2015 at 01:52:33AM -0400, Scott Kostyshak wrote: > > > >> On Sat, May 2, 2015 at 8:02 PM, Enrico Forestieri wrote: > >> > On Sat, May 02, 2015 at 07:03

Re: Behavior of second preview after error

2015-05-03 Thread Scott Kostyshak
On Sun, May 3, 2015 at 11:00 AM, Enrico Forestieri wrote: > On Sun, May 03, 2015 at 01:52:33AM -0400, Scott Kostyshak wrote: > >> On Sat, May 2, 2015 at 8:02 PM, Enrico Forestieri wrote: >> > On Sat, May 02, 2015 at 07:03:53PM -0400, Scott Kostyshak wrote: >> >> >> >> An alternative would be to a

Re: Behavior of second preview after error

2015-05-03 Thread Enrico Forestieri
On Sun, May 03, 2015 at 01:52:33AM -0400, Scott Kostyshak wrote: > On Sat, May 2, 2015 at 8:02 PM, Enrico Forestieri wrote: > > On Sat, May 02, 2015 at 07:03:53PM -0400, Scott Kostyshak wrote: > >> > >> An alternative would be to add a parameter to LaTeX::LaTeX() that says > >> whether to do a fr

Re: Behavior of second preview after error

2015-05-02 Thread Scott Kostyshak
On Sat, May 2, 2015 at 8:02 PM, Enrico Forestieri wrote: > On Sat, May 02, 2015 at 07:03:53PM -0400, Scott Kostyshak wrote: >> >> An alternative would be to add a parameter to LaTeX::LaTeX() that says >> whether to do a fresh compile. > > This alternative seems the most logical one to me. Add a bo

Re: Behavior of second preview after error

2015-05-02 Thread Enrico Forestieri
On Sat, May 02, 2015 at 07:03:53PM -0400, Scott Kostyshak wrote: > > Attached is a patch. I have tested it and it works well for me. I'm > not sure about one part of the implementation. I have > Converters::runLaTeX() check the buffer member storing whether there > was an error, and if so it calls

Re: Behavior of second preview after error

2015-05-02 Thread Scott Kostyshak
On Tue, Apr 28, 2015 at 5:15 PM, Scott Kostyshak wrote: > On Tue, Apr 28, 2015 at 10:09 AM, Enrico Forestieri wrote: >> On Mon, Apr 27, 2015 at 08:54:30PM -0400, Scott Kostyshak wrote: >>> >>> A related question is what to do when we know there is an error. >>> Before, we reran LaTeX. I'm wonderi

Re: Behavior of second preview after error

2015-04-28 Thread Scott Kostyshak
On Tue, Apr 28, 2015 at 10:09 AM, Enrico Forestieri wrote: > On Mon, Apr 27, 2015 at 08:54:30PM -0400, Scott Kostyshak wrote: >> >> A related question is what to do when we know there is an error. >> Before, we reran LaTeX. I'm wondering why we didn't just show the same >> LaTeX Errors dialog agai

Re: Behavior of second preview after error

2015-04-28 Thread Enrico Forestieri
On Mon, Apr 27, 2015 at 08:54:30PM -0400, Scott Kostyshak wrote: > > A related question is what to do when we know there is an error. > Before, we reran LaTeX. I'm wondering why we didn't just show the same > LaTeX Errors dialog again if the .tex file did not change. For example > we could have ch

Re: Behavior of second preview after error

2015-04-27 Thread Scott Kostyshak
On Sat, Apr 25, 2015 at 6:17 PM, Richard Heck wrote: > On 04/24/2015 11:52 PM, Scott Kostyshak wrote: >> >> Suppose there is an error during LaTeX compilation, and then the user >> immediate previews again. We should show the same error again. >> >> This doesn't happen since adding a "show output

Re: Behavior of second preview after error

2015-04-25 Thread Richard Heck
On 04/24/2015 11:52 PM, Scott Kostyshak wrote: Suppose there is an error during LaTeX compilation, and then the user immediate previews again. We should show the same error again. This doesn't happen since adding a "show output anyway" button at 09700d5b. The reason for this is that before, we u