On Sat, Apr 25, 2015 at 6:17 PM, Richard Heck <rgh...@lyx.org> wrote: > On 04/24/2015 11:52 PM, Scott Kostyshak wrote: >> >> Suppose there is an error during LaTeX compilation, and then the user >> immediate previews again. We should show the same error again. >> >> This doesn't happen since adding a "show output anyway" button at >> 09700d5b. The reason for this is that before, we used to remove output >> files on error. This way, in the above case to know whether to show >> the error again, we just would check whether there was a PDF file. >> Now, however, we keep PDF files around even if there is an error (in >> case the user wants to use the "show output anyway" button). >> >> To fix this, I propose to store the error status in a buffer variable. >> Then on preview, if there is already a valid cached PDF, we can just >> check log_status and process it accordingly. >> >> Any thoughts? > > > Seems reasonable. And it's hard to see any alternative.
A related question is what to do when we know there is an error. Before, we reran LaTeX. I'm wondering why we didn't just show the same LaTeX Errors dialog again if the .tex file did not change. For example we could have checked that the error list was not empty, or reprocessed the .log file which I think we kept around because it was not removed in deleteFilesOnError(). So my question is: if nothing has changed, should we rerun LaTeX (like we did before) or should we ideally show the same error as we showed the first time? Scott On Sat, Apr 25, 2015 at 6:17 PM, Richard Heck <rgh...@lyx.org> wrote: > On 04/24/2015 11:52 PM, Scott Kostyshak wrote: >> >> Suppose there is an error during LaTeX compilation, and then the user >> immediate previews again. We should show the same error again. >> >> This doesn't happen since adding a "show output anyway" button at >> 09700d5b. The reason for this is that before, we used to remove output >> files on error. This way, in the above case to know whether to show >> the error again, we just would check whether there was a PDF file. >> Now, however, we keep PDF files around even if there is an error (in >> case the user wants to use the "show output anyway" button). >> >> To fix this, I propose to store the error status in a buffer variable. >> Then on preview, if there is already a valid cached PDF, we can just >> check log_status and process it accordingly. >> >> Any thoughts? > > > Seems reasonable. And it's hard to see any alternative. > > Richard >
