Re: [patch] tabular

2003-06-12 Thread Andre Poenitz
On Thu, Jun 12, 2003 at 01:54:28PM +0200, Jean-Marc Lasgouttes wrote: > Andre> Do you see any reason for this linear 'index' numbering of > Andre> cells? [I do not really want to touch it now, but I have the > Andre> impression that the current code is a bit more complex that it > Andre> would be w

Re: [patch] tabular

2003-06-12 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> Do you see any reason for this linear 'index' numbering of Andre> cells? [I do not really want to touch it now, but I have the Andre> impression that the current code is a bit more complex that it Andre> would be with a simple row/c

Re: [patch] tabular

2003-06-12 Thread Andre Poenitz
On Thu, Jun 12, 2003 at 01:40:33PM +0200, Lars Gullik Bjønnes wrote: > Looks ok to me. Fine. As you were moving in that direction: Do you see any reason for this linear 'index' numbering of cells? [I do not really want to touch it now, but I have the impression that the current code is a bit mor

Re: [patch] tabular

2003-06-12 Thread Andre Poenitz
On Thu, Jun 12, 2003 at 12:29:10PM +0100, John Levon wrote: > On Thu, Jun 12, 2003 at 01:25:10PM +0200, Andre Poenitz wrote: > > > - Read(buf, lex); > > + read(buf, lex); > > Perhaps confusing it with InsetTabular::read(), but I think there are > two versions of read: read() and Read(). I do

Re: [patch] tabular

2003-06-12 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | Mostly renaming SomeFunctions() to someFunctions(), | various issues with whitespace and excessive use of parantheses | and some public->private. | | No user visible change. Looks ok to me. -- Lgb

Re: [patch] tabular

2003-06-12 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | Mostly renaming SomeFunctions() to someFunctions(), The exact thing that I planned to do now. | various issues with whitespace and excessive use of parantheses | and some public->private. | | No user visible change. Let me have a quick look. --

Re: [patch] tabular

2003-06-12 Thread John Levon
On Thu, Jun 12, 2003 at 01:25:10PM +0200, Andre Poenitz wrote: > - Read(buf, lex); > + read(buf, lex); Perhaps confusing it with InsetTabular::read(), but I think there are two versions of read: read() and Read(). If not, please ignore me. So, you are tabular maintainer now right ? >:)