Re: [patch] next

2003-11-17 Thread Alfredo Braunstein
Andre Poenitz wrote: > Looks as if it works... Cool. ;-) Alfredo

Re: [patch] Next rowlist patch

2003-03-28 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | | > Me too... I have been looking too much at this code, and making so | > many small alterations, that I almost forget what I am looking at. | > (And seeing bugs are just our of the question...) | | /Courage/! You're

Re: [patch] Next rowlist patch

2003-03-28 Thread Alfredo Braunstein
Lars Gullik Bjønnes wrote: > Yes, I saw this too. > > Can you try changing it (reverting this chunk), and see if that fixes > the problems? Like a charm. > > Then I'll have something to move forward from. > Go for it. Alfredo ps: can you send the patch to lyxtext.h on a separate file if th

Re: [patch] Next rowlist patch

2003-03-28 Thread Alfredo Braunstein
Lars Gullik Bjønnes wrote: > Me too... I have been looking too much at this code, and making so > many small alterations, that I almost forget what I am looking at. > (And seeing bugs are just our of the question...) /Courage/! You're doing a huge step forward, and you're not far from the end. Y

Re: [patch] Next rowlist patch

2003-03-28 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | | > still have problems with row reordering, and I do not really see why. | > | > But it is better I guess. | | Dindn't finished compiling it yet, but I think that this is the problem: now | insertRow and appendParagr

Re: [patch] Next rowlist patch

2003-03-28 Thread Alfredo Braunstein
Lars Gullik Bjønnes wrote: > still have problems with row reordering, and I do not really see why. > > But it is better I guess. Dindn't finished compiling it yet, but I think that this is the problem: now insertRow and appendParagraph and insertParagraph behave exactly as before, but you have c

Re: [patch] Next rowlist patch

2003-03-28 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | So, how do you want insertRow to behave, in _this_ patch? I want it to behave as I described, but it seems that warrants a bit too many changes a bit too soon. So I feel my way along... | > | Note that you have losed | > | completely the ability

Re: [patch] Next rowlist patch

2003-03-28 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | So the change of behaviour of insertRow is intended? (now insertRow(0,...) | will insert at the end, instead of the beginning). Note that you have losed | completely the ability to insert at the beginning (this may be the reason | it doesn't work).

Re: [patch] Next rowlist patch

2003-03-28 Thread Alfredo Braunstein
Lars Gullik Bjønnes wrote: > | -if (!row) { > | -rowlist_.insert(rowlist_.begin(), tmprow); > | -} else { > | -rowlist_.insert(row->next(), tmprow); > | -} > | +if (rowit == rowlist_.end()) > | +return rowlist_.insert(

Re: [patch] Next rowlist patch

2003-03-28 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | | > This is the second patch in the series. This one has known problems. I | > am pretty sure that this is due to (Row*)0 being used both for | > inserting at beginning of rowlist and as the end of the rowlist. | | -

Re: [patch] Next rowlist patch

2003-03-28 Thread Alfredo Braunstein
Lars Gullik Bjønnes wrote: > This is the second patch in the series. This one has known problems. I > am pretty sure that this is due to (Row*)0 being used both for > inserting at beginning of rowlist and as the end of the rowlist. -if (!row) { -rowlist_.insert(rowlist_.be

Re: [patch] Next rowlist patch

2003-03-28 Thread Alfredo Braunstein
Lars Gullik Bjønnes wrote: > Would be really nice if you could have a quick look Alfredo. > (and sorry for using you as my private bug-hunter) :) I'm having a look... Alfredo

Re: [PATCH] next dispatch patch

2002-07-18 Thread John Levon
On Thu, Jul 18, 2002 at 05:36:34PM +0200, Jean-Marc Lasgouttes wrote: > You should set the fontstate (or whatever) message only if > the lfun has not provided its own message. How difficult is > that? That already happens, that isn't where the problem is occuring. But if you do : LFUN_

Re: [PATCH] next dispatch patch

2002-07-18 Thread Jean-Marc Lasgouttes
John Levon wrote: > On Thu, Jul 18, 2002 at 04:09:44PM +0200, Andre Poenitz wrote: > > >>? > > > e.g. C-m, one message overwrites another (and in several other cases) > insert->math->cases didn't clear minibuffer > > Most ->message() calls aren't going to be too useful. You should set the f

Re: [PATCH] next dispatch patch

2002-07-18 Thread John Levon
On Thu, Jul 18, 2002 at 04:09:44PM +0200, Andre Poenitz wrote: > ? e.g. C-m, one message overwrites another (and in several other cases) insert->math->cases didn't clear minibuffer Most ->message() calls aren't going to be too useful. But we can work on these ... john -- "Of all manifestat

Re: [PATCH] next dispatch patch

2002-07-18 Thread Andre Poenitz
On Thu, Jul 18, 2002 at 02:53:34PM +0100, John Levon wrote: > There are some mathed problems with various things but I have the > feeling I'm tickling latent problems there rather than introducing new > ones ? Andre' -- Those who desire to give up Freedom in order to gain Security, will not ha

Re: [PATCH] next dispatch patch

2002-07-18 Thread John Levon
On Thu, Jul 18, 2002 at 03:49:29PM +0200, Jean-Marc Lasgouttes wrote: > Nothing there makes me jump to the ceiling. Fine praise indeed ! > I cannot test much :( Maybe I should just apply it and we can see what breaks compared to what I've fixed There are some mathed problems with various thin

Re: [PATCH] next dispatch patch

2002-07-18 Thread Jean-Marc Lasgouttes
John Levon wrote: > Contains a couple more previously discussed changes. Please test this > so we can see what problems there might be. > > If there are no objections I'll commit it later. Nothing there makes me jump to the ceiling. However, since I had the good idea to apply a mandrake security

Re: [PATCH] next dispatch patch

2002-07-18 Thread Andre Poenitz
On Thu, Jul 18, 2002 at 02:34:34PM +0100, John Levon wrote: > If there are no objections I'll commit it later. I like the lines starting with '-' in the patch ;-) Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jeffer