Re: [patch] Improved GuiSendTo Dialog implementation

2008-09-04 Thread Andre Poenitz
On Thu, Sep 04, 2008 at 11:54:13AM +0200, Abdelrazak Younes wrote: > Jürgen Spitzmüller wrote: >> Vincent van Ravesteijn - TNW wrote: >> >>> + // Save the current selection if any >>> + Format const * current_format = 0; >>> + int const line = formatLW->currentRow(); >>> +

Re: [patch] Improved GuiSendTo Dialog implementation

2008-09-04 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > > We use space rather than tab here. > >     > > Are you sure? Yes. This is how I see it overall in our sources. Jürgen

Re: [patch] Improved GuiSendTo Dialog implementation

2008-09-04 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Jürgen Spitzmüller wrote: Vincent van Ravesteijn - TNW wrote: + // Save the current selection if any + Format const * current_format = 0; + int const line = formatLW->currentRow(); + if (line>= 0&& line<= formatLW->count() +&& formatLW->selecte

Re: [patch] Improved GuiSendTo Dialog implementation

2008-09-04 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Vincent van Ravesteijn - TNW wrote: + // Save the current selection if any + Format const * current_format = 0; + int const line = formatLW->currentRow(); + if (line>= 0&& line<= formatLW->count() +&& formatLW->selectedItems().size()> 0)

Re: [patch] Improved GuiSendTo Dialog implementation

2008-09-04 Thread Jürgen Spitzmüller
Vincent van Ravesteijn - TNW wrote: > A new patch is attached. Thanks (I'm glad to see I'm not the only user of that dialog). I did some further polishing and committed. First, I do not like the passing around of signals. So I implemented the combo handling in GuiSendto itself. Then, there wer

RE: [patch] Improved GuiSendTo Dialog implementation

2008-09-03 Thread Vincent van Ravesteijn - TNW
> If ok, this might also be used in the GuiSearch dialog (note that we > reimplemented the uniqueInsert behaviour and that the items are > added to the wrong side of the list). Hereby, a proposal for the GuiSearch dialog. The same signal connections are used to interact with the comboboxes: F

RE: [patch] Improved GuiSendTo Dialog implementation

2008-09-03 Thread Vincent van Ravesteijn - TNW
> Incidentally, _q_returnPressed() looks _fairly_ internal to Qt. > > Would connecting to commandCO->lineEdit() / SIGNAL(returnedPressed()) > be an option? > > Andre' As usual, you're completely right. Didn't yet realize the possibility of connecting two SIGNALs to each other. Thank you f

Re: [patch] Improved GuiSendTo Dialog implementation

2008-09-03 Thread Andre Poenitz
On Wed, Sep 03, 2008 at 08:36:11PM +0200, Vincent van Ravesteijn - TNW wrote: > P.S. I hope I applied the style guidelines correctly this time. Getting better ;-) Nevertheless: > + // Save the current selection if any > + const Format * current_format = 0; Format const * current_format