Vincent van Ravesteijn - TNW wrote:
> A new patch is attached.

Thanks (I'm glad to see I'm not the only user of that dialog). 

I did some further polishing and committed. First, I do not like the passing 
around of signals. So I implemented the combo handling in GuiSendto itself.

Then, there were still some nitpicks, see below.

> +       // Save the current selection if any
> +       Format const * current_format = 0;
> +       int const line = formatLW->currentRow();
> +       if (line >= 0 && line <= formatLW->count()
> +               && formatLW->selectedItems().size() > 0)

We use space rather than tab here.

> +               if (current_format
> +                       && (*it)->prettyname() ==

dto.

> +       return formatLW->selectedItems().size()>0 &&

space around ">".

Jürgen

Reply via email to