Re: [patch] Bug 1937: undo of table cut is losing data

2005-07-28 Thread Juergen Spitzmueller
Georg Baum wrote: > > Actually, I wonder why it is there at all. Isn't it called in > > cell(cur.idx())->dispatch anyway? > > I think it should be. I didn't encounter any problems when deliting it. John, could you please comment out that line when testing or use the attached updated patch? Jürge

Re: [patch] Bug 1937: undo of table cut is losing data

2005-07-28 Thread Georg Baum
Juergen Spitzmueller wrote: > Actually, I wonder why it is there at all. Isn't it called in > cell(cur.idx())->dispatch anyway? I think it should be. Georg

Re: [patch] Bug 1937: undo of table cut is losing data

2005-07-28 Thread Juergen Spitzmueller
Georg Baum wrote: > I think that the recordUndo() should be put into the else branch. Actually, I wonder why it is there at all. Isn't it called in cell(cur.idx())->dispatch anyway? (and if not, why does LFUN_CUT do without?) Jürgen

Re: [patch] Bug 1937: undo of table cut is losing data

2005-07-28 Thread Georg Baum
Juergen Spitzmueller wrote: > The patch fixes the behavior of cut, delete and paste in multiple cells. > The question is: Are there some recordUndoInset calls missing? I can > imagine that (some of) the tabular features need this too. Georg, do you > have an idea? No, but the patch looks good apa

Re: [patch] Bug 1937: undo of table cut is losing data

2005-07-28 Thread Juergen Spitzmueller
John Levon wrote: > > OK. John, can you test if this cures the undo woes? > > Yep, but maybe not a for a couple of days No hurry. Just tell me when you're done. Jürgen

Re: [patch] Bug 1937: undo of table cut is losing data

2005-07-28 Thread John Levon
On Thu, Jul 28, 2005 at 11:38:01AM +0200, Juergen Spitzmueller wrote: > > Please get someone to test it. If the test turns out ok, please commit. > > OK. John, can you test if this cures the undo woes? Yep, but maybe not a for a couple of days john

Re: [patch] Bug 1937: undo of table cut is losing data

2005-07-28 Thread Juergen Spitzmueller
Lars Gullik Bjønnes wrote: > | Answering my own question, I think that the following is needed. > > Please get someone to test it. If the test turns out ok, please commit. OK. John, can you test if this cures the undo woes? Jürgen

Re: [patch] Bug 1937: undo of table cut is losing data

2005-07-28 Thread Lars Gullik Bjønnes
Juergen Spitzmueller <[EMAIL PROTECTED]> writes: | Juergen Spitzmueller wrote: >> Are there some recordUndoInset calls missing? I can imagine that >> (some of) the tabular features need this too. > | Answering my own question, I think that the following is needed. Please get someone to test it. I

Re: [patch] Bug 1937: undo of table cut is losing data

2005-07-28 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > Are there some recordUndoInset calls missing? I can imagine that > (some of) the tabular features need this too. Answering my own question, I think that the following is needed. Jürgen Index: insets/insettabular.C =