Juergen Spitzmueller wrote:

> The patch fixes the behavior of cut, delete and paste in multiple cells.
> The question is: Are there some recordUndoInset calls missing? I can
> imagine that (some of) the tabular features need this too. Georg, do you
> have an idea?

No, but the patch looks good apart from the place shown below.

> Unfortunately, the font changes are recorded atomically, since the font
> changes are applied one by one. Is there any possibility to group them?

I don't know.

> @@ -632,8 +632,10 @@ void InsetTabular::doDispatch(LCursor &
>  case LFUN_BACKSPACE:
>  case LFUN_DELETE:
>  recordUndo(cur, Undo::DELETE);
> -                if (tablemode(cur))
> +                if (tablemode(cur)) {
> +                        recordUndoInset(cur, Undo::DELETE);
>  cutSelection(cur);
> +                }
>  else
>  cell(cur.idx())->dispatch(cur, cmd);
>  break;

I think that the recordUndo() should be put into the else branch.


Georg

Reply via email to