Re: [Patch] Re: LyX cvs (Qt frontend) is still sloooooooooooooooowwwwwwwwwwwwwww

2005-10-10 Thread Andre Poenitz
On Sat, Sep 24, 2005 at 09:11:19AM +0300, Martin Vermeer wrote: > I propose to put the attached summarizing patch in, and test and > profile again. At least the update parts could be committed immediately as far as I am coconcerned. They fix regressions. Andre'

Re: [Patch] Re: LyX cvs (Qt frontend) is still sloooooooooooooooowwwwwwwwwwwwwww

2005-09-24 Thread Martin Vermeer
On Sat, 24 Sep 2005 10:34:25 +0100 Angus Leeming <[EMAIL PROTECTED]> wrote: > Martin Vermeer wrote: > > I propose to put the attached summarizing patch in, and test and > profile > > again. > > My comments are those of someone who is entirely ignorant of this part > of > the code, so please take

Re: [Patch] Re: LyX cvs (Qt frontend) is still sloooooooooooooooowwwwwwwwwwwwwww

2005-09-24 Thread Angus Leeming
Martin Vermeer wrote: > I propose to put the attached summarizing patch in, and test and profile > again. My comments are those of someone who is entirely ignorant of this part of the code, so please take them with a pinch of salt. Well meaning interference :) Angus Why the two if statements ra

Re: [Patch] Re: LyX cvs (Qt frontend) is still sloooooooooooooooowwwwwwwwwwwwwww

2005-09-24 Thread Andre Poenitz
On Sat, Sep 24, 2005 at 08:56:58AM +0300, Martin Vermeer wrote: > BTW am I right in understanding that descending into the cursor stack means > moving from bottom downward to top (tip?), increasing depth all the time? How > logical... Depends on your point of view. Implementation-wise it's certain

Re: [Patch] Re: LyX cvs (Qt frontend) is still sloooooooooooooooowwwwwwwwwwwwwww

2005-09-23 Thread Martin Vermeer
On Sat, 24 Sep 2005 08:56:58 +0300 (EEST) Martin Vermeer <[EMAIL PROTECTED]> wrote: > On Fri, 23 Sep 2005 17:26:48 +0200 Jean-Marc Lasgouttes > <[EMAIL PROTECTED]> wrote: > > > Martin Vermeer wrote: > > > I believe the culprit is > > > > > > if (!singlepar || pit1 == cursor_.pit(

Re: [Patch] Re: LyX cvs (Qt frontend) is still sloooooooooooooooowwwwwwwwwwwwwww

2005-09-23 Thread Martin Vermeer
On Fri, 23 Sep 2005 17:26:48 +0200 Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: > Martin Vermeer wrote: > > I believe the culprit is > > > > if (!singlepar || pit1 == cursor_.pit()) > > > > which I added several times to BufferView_pimpl.C:s metrics method. > It > > tests for

Re: [Patch] Re: LyX cvs (Qt frontend) is still sloooooooooooooooowwwwwwwwwwwwwww

2005-09-23 Thread Bennett Helm
On Sep 23, 2005, at 10:26 AM, Martin Vermeer wrote: On Fri, 2005-09-23 at 09:07 -0400, Bennett Helm wrote: On Sep 23, 2005, at 8:59 AM, Bennett Helm wrote: Cursor movement is a bit strange. This is especially noticeable with page-up and page-down: it seems like the cursor moves, but the scr

Re: [Patch] Re: LyX cvs (Qt frontend) is still sloooooooooooooooowwwwwwwwwwwwwww

2005-09-23 Thread Jean-Marc Lasgouttes
Martin Vermeer wrote: I believe the culprit is if (!singlepar || pit1 == cursor_.pit()) which I added several times to BufferView_pimpl.C:s metrics method. It tests for being in the paragraph containing the cursor... but I believe cursor_.pit() refers to the paragraph iterator _

Re: [Patch] Re: LyX cvs (Qt frontend) is still sloooooooooooooooowwwwwwwwwwwwwww

2005-09-23 Thread Martin Vermeer
On Fri, Sep 23, 2005 at 08:59:26AM -0400, Bennett Helm wrote: > On Sep 22, 2005, at 5:57 PM, Martin Vermeer wrote: ... > This patch does not help typing in footnotes, TeX Code, or other > insets (margin pars, minipages, LyX notes, etc.). Insets within > insets work, but are predictably slow a

Re: [Patch] Re: LyX cvs (Qt frontend) is still sloooooooooooooooowwwwwwwwwwwwwww

2005-09-23 Thread Martin Vermeer
On Fri, 2005-09-23 at 09:07 -0400, Bennett Helm wrote: > On Sep 23, 2005, at 8:59 AM, Bennett Helm wrote: > > > Cursor movement is a bit strange. This is especially noticeable > > with page-up and page-down: it seems like the cursor moves, but the > > screen doesn't get redrawn. It also happen

Re: [Patch] Re: LyX cvs (Qt frontend) is still sloooooooooooooooowwwwwwwwwwwwwww

2005-09-23 Thread Bennett Helm
On Sep 23, 2005, at 8:59 AM, Bennett Helm wrote: Cursor movement is a bit strange. This is especially noticeable with page-up and page-down: it seems like the cursor moves, but the screen doesn't get redrawn. It also happens with moving the cursor left and right (though not with up and down

Re: [Patch] Re: LyX cvs (Qt frontend) is still sloooooooooooooooowwwwwwwwwwwwwww

2005-09-23 Thread Bennett Helm
On Sep 22, 2005, at 5:57 PM, Martin Vermeer wrote: Give the attached a try. I think it is quite a bit faster, and fixes your noticed side effect. Wow! What a difference! Typing in long documents feels almost as fast as 1.3.6, and processor usage no longer gets pegged at absurdly high leve

Re: [Patch] Re: LyX cvs (Qt frontend) is still sloooooooooooooooowwwwwwwwwwwwwww

2005-09-23 Thread Helge Hafting
Martin Vermeer wrote: On Fri, 2005-09-23 at 08:58 +0200, Helge Hafting wrote: Martin Vermeer wrote: Give the attached a try. I think it is quite a bit faster, and fixes your noticed side effect. There may be other side effects; this patch touches so many things, it scares me a bit

Re: [Patch] Re: LyX cvs (Qt frontend) is still sloooooooooooooooowwwwwwwwwwwwwww

2005-09-23 Thread Martin Vermeer
On Fri, 2005-09-23 at 08:58 +0200, Helge Hafting wrote: > Martin Vermeer wrote: > > >Give the attached a try. > > > >I think it is quite a bit faster, and fixes your noticed side effect. > > > >There may be other side effects; this patch touches so many things, it > >scares me a bit. But the spee

Re: [Patch] Re: LyX cvs (Qt frontend) is still sloooooooooooooooowwwwwwwwwwwwwww

2005-09-22 Thread Helge Hafting
Martin Vermeer wrote: Give the attached a try. I think it is quite a bit faster, and fixes your noticed side effect. There may be other side effects; this patch touches so many things, it scares me a bit. But the speedup is so substantial that perhaps we should just take the jump, and clean

Re: [Patch] Re: LyX cvs (Qt frontend) is still sloooooooooooooooowwwwwwwwwwwwwww

2005-09-22 Thread Martin Vermeer
On Thu, Sep 22, 2005 at 09:21:31AM -0400, Bennett Helm wrote: > On Sep 22, 2005, at 4:08 AM, Martin Vermeer wrote: > > >Here is a better patch, taking care of rowpainter too. metrics is > >still > >called twice, but now (generally) only for the current paragraph, not > >the whole screen. Ought t

Re: [Patch] Re: LyX cvs (Qt frontend) is still sloooooooooooooooowwwwwwwwwwwwwww

2005-09-22 Thread Bennett Helm
On Sep 22, 2005, at 4:08 AM, Martin Vermeer wrote: Here is a better patch, taking care of rowpainter too. metrics is still called twice, but now (generally) only for the current paragraph, not the whole screen. Ought to be faster. I saw no side effects. I tried it, and it generally feels qu

Re: [Patch] Re: LyX cvs (Qt frontend) is still sloooooooooooooooowwwwwwwwwwwwwww

2005-09-22 Thread Helge Hafting
Martin Vermeer wrote: On Thu, 2005-09-22 at 03:26 +0300, Martin Vermeer wrote: I also noted that metrics is called twice for every keystroke. Surely one of those isn't necessary. Sounds reasonable? Please test. Is it faster, or is it my imagination? Here is a better patch, taking c