Martin Vermeer wrote:
On Fri, 2005-09-23 at 08:58 +0200, Helge Hafting wrote:
Martin Vermeer wrote:
Give the attached a try.
I think it is quite a bit faster, and fixes your noticed side effect.
There may be other side effects; this patch touches so many things, it
scares me a bit. But the speedup is so substantial that perhaps we
should just take the jump, and clean up afterwards. And I have a good
feeling that now SinglePar works as it was intended to.
I tried the patch and saw no problems with it. Moving around and
editing a document with lots of short paragraphs works very well,
I can't force a load spike.
The crazy 100k paragraph improved too, although I can still
type faster than lyx in this case. Scrolling to the bottom with the
"page down" key wasn't painful this time though - a clear improvement.
Opening a 30-page real document worked fine too, I could scroll through
it very fast with either pagedown or scrollbar. Great speed, and no
load spike.
Helge Hafting
Thanks Helge! This is good news.
Did you try any out-of-the-ordinary things? Different types of insets,
insets-within-insets, cut/paste, undo, ...
That attempt was only opening the document, and writing some text.
I also scrolled through that 30-page document which contains
some graphichs, tables bullet lists, sectioning and a TOC.
Now I tried making a new document, paste in chapters from
the user guide, and modify them. A deeply nested list
with enumerations and bullets worked well.
A table oddity: mark several cells, turn them all bold in one go,
undo undoes bold in one cell at a time. (I.e. undo,undo,undo...)
in order to undo all of it. The display is correct through all of this,
but it'd be nice if I could undo everything with the same ease
as _doing_ it. (Well, I can by marking it and un-bolding it.)
Changed the amount of vertical spacing in a vert. spacing inset,
"undo" did not undo that, instead one more bold table cell
was undone. Vertical inset editing isn't registered with the
undo mechanism? I'll write a separate bug report on that.
Stuck a box in a table, a nested bullet/enumerated list in that,
a table in that, a box inside that again. Copied the entire
outer box into some other table cell. No problems.
Undo crash: Entered some math:
1+"Normal text"
--------------------------
_
Cut the "+", try to insert it in the denominator (nothing happens)
Undo does nothing
Undo does nothing
Undo crashes lyx:
#### pasteSelection 0
### should be handled in MathNest/GridInset
cutSelection in mathed
copySelection in mathed
#### pasteSelection 0
### should be handled in MathNest/GridInset
#### pasteSelection 0
### should be handled in MathNest/GridInset
action: 12
action: 12
action: 12
DocIterator StableDocIterator::asDocIterator(InsetBase*) const Should
not happen
, but does e.g. after C-n C-l C-z S-C-z
dit: inset: 0x8ab35d4 idx: 0 par: 117 pos: 0
inset: 0x8abcdd0 idx: 0 par: 0 pos: 0
inset: 0x8e16288 idx: 0 par: 0 pos: 2
lastpos: 2
Assertion triggered in DocIterator StableDocIterator::asDocIterator
I guess this wasn't related to the display speedup? I saw no
display peculiarities at all.
Helge Hafting
