On Wed, Feb 18, 2004 at 12:37:32PM +0100, Juergen Spitzmueller wrote:
> Andre Poenitz wrote:
> > If it is an error to have style_ >= dialog_->typeCO->count() you should
> > assert here...
>
> It's not really an error. And we have a comfortable fallback.
So it is fine then...
Andre'
--
Those w
Andre Poenitz wrote:
> If it is an error to have style_ >= dialog_->typeCO->count() you should
> assert here...
It's not really an error. And we have a comfortable fallback.
Jürgen.
On Wed, Feb 18, 2004 at 12:14:52PM +0100, Juergen Spitzmueller wrote:
> Angus Leeming wrote:
> > Can style_ ever be less than '0'?
>
> Yes, I think it can be -1 in some cases (I forgot which). Also, I've added a
> second test. i.e.:
>
> if (style_ >= 0 && style_ < dialog_->typeCO->count())
>
Juergen Spitzmueller wrote:
> > Can style_ ever be less than '0'?
>
> Yes, I think it can be -1 in some cases (I forgot which)
I seem to rember now that QComboBox::currentItem() returns '-1' if the widget
is disabled (which is the case for non natbib users).
Jürgen.
Angus Leeming wrote:
> Can style_ ever be less than '0'?
Yes, I think it can be -1 in some cases (I forgot which). Also, I've added a
second test. i.e.:
if (style_ >= 0 && style_ < dialog_->typeCO->count())
dialog_->typeCO->setCurrentItem(setCurrentItem(style_);
Currently, the n
Juergen Spitzmueller wrote:
> This patch contains the qcitation fix (bug 1146) plus:
> - a fix for bug 1037 (disable the goto button in the qref dialog if
> there is no reference at all)
> - a fix for bug 1511 (restore the settings of the buffer combo in
> the qref dialog)
> - and an enhancement f
