Juergen Spitzmueller wrote:
> This patch contains the qcitation fix (bug 1146) plus:
> - a fix for bug 1037 (disable the goto button in the qref dialog if
> there is no reference at all)
> - a fix for bug 1511 (restore the settings of the buffer combo in
> the qref dialog)
> - and an enhancement for natbib users: restore the settings of the
> citation style combo. Normally, you have a default style (e.g.
> \citep), and it is very annoying to chose that any all time again.
>
> If there are no objections, I'll apply this.
Can style_ ever be less than '0'? If not this:
+ if (style_ >= 0)
+ dialog_->citationStyleCO->setCurrentItem(style_);
+ else
+ dialog_->citationStyleCO->setCurrentItem(0);
can be replaced with:
dialog_->citationStyleCO->setCurrentItem(style_);
You need to initialise style_ in the c-tor of course...
--
Angus
