Jean-Marc Lasgouttes wrote:
> Juergen, I propose to keep this patch somewhere and look at it again
> after the update() situation has stabilized. You could for example
I can keep the changes in my devel and stable tree (and therefor keep on
testing it). I'm not shure that the current update() iss
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes:
Andre> On Wed, Jun 18, 2003 at 01:57:45PM +0200, Jean-Marc Lasgouttes
Andre> wrote: Let him call it as much as he want if that's the only
Andre> objection to that patch. I doubt getLyXText() will survive next
Andre> Christmas...
>> Yes, b
On Wed, Jun 18, 2003 at 01:57:45PM +0200, Jean-Marc Lasgouttes wrote:
> Andre> Let him call it as much as he want if that's the only objection
> Andre> to that patch. I doubt getLyXText() will survive next
> Andre> Christmas...
>
> Yes, but I am concerned about 1.3.x too.
>
> Juergen, I propose t
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes:
>> But isn't ``*this'' a good enough LyXText when inside
>> LyXText::dispatch? Which LyXText do you want: the global one or the
>> local one?
Andre> Let him call it as much as he want if that's the only objection
Andre> to that patch. I
Andre Poenitz wrote:
> That's ok.
OK, then here returns my modified patch from yesterday which had already these
changes. Please apply if there are no further objections.
Thanks,
Jürgen.
Index: src/ChangeLog
===
RCS file: /cvs/lyx/l
On Wed, Jun 18, 2003 at 01:25:33PM +0200, Juergen Spitzmueller wrote:
> Andre Poenitz wrote:
> > What about using '.' instead. Or do not write '*this' at all?
>
> I think the problem is that I access the function from within dispatch, where
> the argument *this is LyXText and from outside, where
Andre Poenitz wrote:
> What about using '.' instead. Or do not write '*this' at all?
I think the problem is that I access the function from within dispatch, where
the argument *this is LyXText and from outside, where the available argument
lt is LyXText *. All of your proposals makes one of thes
On Wed, Jun 18, 2003 at 01:10:35PM +0200, Juergen Spitzmueller wrote:
> Jean-Marc Lasgouttes wrote:
> > But isn't ``*this'' a good enough LyXText when inside
> > LyXText::dispatch?
>
> Obviously not (or I am doing something wrong):
>
> text3.C: In member function `dispatch_result LyXText::dispat
Jean-Marc Lasgouttes wrote:
> But isn't ``*this'' a good enough LyXText when inside
> LyXText::dispatch?
Obviously not (or I am doing something wrong):
text3.C: In member function `dispatch_result LyXText::dispatch(const
FuncRequest&)':
text3.C:1044: error: cannot convert `LyXText' to `LyXTex
On Wed, Jun 18, 2003 at 12:31:34PM +0200, Jean-Marc Lasgouttes wrote:
> > "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
>
> Juergen> Jean-Marc Lasgouttes wrote:
> >> - why do you pass a BufferView as parameter, since you are only
> >> interested by a LyXText?
>
> Juergen> Beca
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc Lasgouttes wrote:
>> - why do you pass a BufferView as parameter, since you are only
>> interested by a LyXText?
Juergen> Because then I have to request getLyXText() only once and not
Juergen> in every function
Juergen Spitzmueller wrote:
> > - why do you pass a BufferView as parameter, since you are only
> > interested by a LyXText?
>
> Because then I have to request getLyXText() only once and not in every
> function I use the method (especially in dispatch()).
> Bad idea?
Ah, I see what you mean. Is
Jean-Marc Lasgouttes wrote:
> - why do you pass a BufferView as parameter, since you are only
> interested by a LyXText?
Because then I have to request getLyXText() only once and not in every
function I use the method (especially in dispatch()).
Bad idea?
> - why are there two update() calls?
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Digging for the inserting-x-does-not-overwrite-selection
Juergen> bugs, I came to a general solution. The patch fixes the bugs
Juergen> 673 (x=specialchar), 702 (x=quote), 954 (x=paste) and an
Juergen> undiscovered bug (x
14 matches
Mail list logo
