>>>>> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:

Juergen> Jean-Marc Lasgouttes wrote:
>> - why do you pass a BufferView as parameter, since you are only
>> interested by a LyXText?

Juergen> Because then I have to request getLyXText() only once and not
Juergen> in every function I use the method (especially in
Juergen> dispatch()). Bad idea?

But isn't ``*this'' a good enough LyXText when inside
LyXText::dispatch? Which LyXText do you want: the global one or the
local one?

>> - why are there two update() calls?

Juergen> I had random crashes without the update calls (after
Juergen> inserting 5-6 quotes over a selection). I have adapted the
Juergen> method with the two update() calls then directly from CUT. So
Juergen> basically, this method does the same as LFUN_CUT (plus the
Juergen> test).

I have to admit that I do not understand this code very well, and I
feel nervous at the idea of adding it to 1.3.x without knowing exactly
why and how it works.

JMarc

Reply via email to