Re: [PATCH] move BufferView cached pointer out of LyXText

2006-10-30 Thread Abdelrazak Younes
José Matos wrote: On Monday 30 October 2006 10:35 am, Abdelrazak Younes wrote: As Georg said, this is up to José. Pretty please Jose! ;-) I feel a bit uneasy with this patch, for obvious reasons. :-( I understand and that's why I asked. But rest assured that it works well. As an added bo

Re: [PATCH] move BufferView cached pointer out of LyXText

2006-10-30 Thread José Matos
On Monday 30 October 2006 10:35 am, Abdelrazak Younes wrote: > > > > As Georg said, this is up to José. > > Pretty please Jose! ;-) I feel a bit uneasy with this patch, for obvious reasons. :-( On the other hand I agree with Jean-Marc. Since Jean-Marc and Georg like the patch you have a go.

Re: [PATCH] move BufferView cached pointer out of LyXText

2006-10-30 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hello, As promised this patch fixes most (all?) the Abdelrazak> crashes obtained when switching windows. Abdelrazak> This may look like a cleanup, and it is in a sense, but Abdelrazak> IMHO th

Re: [PATCH] move BufferView cached pointer out of LyXText

2006-10-30 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hello, As promised this patch fixes most (all?) the Abdelrazak> crashes obtained when switching windows. Abdelrazak> This may look like a cleanup, and it is in a sense, but Abdelrazak> IMHO this was the only way to ha

Re: [PATCH] move BufferView cached pointer out of LyXText

2006-10-29 Thread Georg Baum
Am Sonntag, 29. Oktober 2006 18:48 schrieb Abdelrazak Younes: > Here's what remains: > > Find all "text() == this", Match case, Whole word, Subfolders, Find > Results 1, "lyx-trunk", > "*.c;*.cpp;*.cxx;*.cc;*.tli;*.tlh;*.h;*.hpp;*.hxx;*.hh" > src\text2.C(1001):if (cur.top().text() == this) >

Re: [PATCH] move BufferView cached pointer out of LyXText

2006-10-29 Thread Abdelrazak Younes
Georg Baum wrote: Am Sonntag, 29. Oktober 2006 18:10 schrieb Abdelrazak Younes: Georg Baum wrote: I am not surprised. You remember my words about multi-window support and core changes during Denmark? Yes, you were right. For my defense, I'd say that there's a lot of ugly corner cases inside

Re: [PATCH] move BufferView cached pointer out of LyXText

2006-10-29 Thread Abdelrazak Younes
Georg Baum wrote: Am Sonntag, 29. Oktober 2006 18:10 schrieb Abdelrazak Younes: Georg Baum wrote: Did you replace all tests for bv in InsetText with a proper ismainText call? There was not many of those test (only in the LyXText constructor I think). I am not quite sure what you are talking ab

Re: [PATCH] move BufferView cached pointer out of LyXText

2006-10-29 Thread Georg Baum
Am Sonntag, 29. Oktober 2006 18:10 schrieb Abdelrazak Younes: > Georg Baum wrote: > > I am not surprised. You remember my words about multi-window support and > > core changes during Denmark? > > Yes, you were right. For my defense, I'd say that there's a lot of ugly > corner cases inside the c

Re: [PATCH] move BufferView cached pointer out of LyXText

2006-10-29 Thread Abdelrazak Younes
Georg Baum wrote: Am Sonntag, 29. Oktober 2006 02:02 schrieb Abdelrazak Younes: Hello, As promised this patch fixes most (all?) the crashes obtained when switching windows. This may look like a cleanup, and it is in a sense, but IMHO this was the only way to have clean and non buggy multi-w

Re: [PATCH] move BufferView cached pointer out of LyXText

2006-10-29 Thread Georg Baum
Am Sonntag, 29. Oktober 2006 02:02 schrieb Abdelrazak Younes: > Hello, > > As promised this patch fixes most (all?) the crashes obtained when > switching windows. > > This may look like a cleanup, and it is in a sense, but IMHO this was > the only way to have clean and non buggy multi-window su