Georg Baum wrote:
Am Sonntag, 29. Oktober 2006 02:02 schrieb Abdelrazak Younes:
Hello,
As promised this patch fixes most (all?) the crashes obtained when
switching windows.
This may look like a cleanup, and it is in a sense, but IMHO this was
the only way to have clean and non buggy multi-window support.
I am not surprised. You remember my words about multi-window support and
core changes during Denmark?
Yes, you were right. For my defense, I'd say that there's a lot of ugly
corner cases inside the code ;-)
It was
quite a bit of work so, please Jose, is that fine with you?
Great! I tried to do the same some months ago, but failed.
It was even more spaghetti like than for the unicode work if you see
what I mean ;-)
In case you do
not know: This is a prerequisite to use a proper InsetText for text in
math instead of the current kludge. After the move to XML it will probably
be trivial to fix text in math.
Interesting.
Did you replace all tests for bv in InsetText with a proper ismainText
call?
There was not many of those test (only in the LyXText constructor I
think). I am not quite sure what you are talking about but I think I
have done some cleanup in the past that eliminated some of these tests.
Please keep this patch in a safe place if it is not fine with José. Since
having the bv pointer in LyXText was a design mistake, and it also caused
problems in tables removing it has indeed the potential to fix other
problems, so I would be in favor to put it in.
Good.
Thanks,
Abdel.
